-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Publish private branch 'release-azurestackhci-Microsoft.AzureStackHCI-2021-09-01-preview' #21296
Conversation
…21-09-01 to version 2021-09-01-preview
* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751) * initial commit * syntax error fix * move galleryimageversionproperties under galleryimageproperties * add galleryimageversion as child of galleryimageproperties * update create/get galleryimage json example * remove version readonly and fix version description * add imagesource and fix imagepath example * fix getgalleryimage.json * pending to inprogress * mark secret x-ms-secret * fix osdisk uri to id in vms * update to local * create marketplacegalleryimages * fix file name * filenmae fix * file rename * file rename * add missing exampl.es * add enum * update vm and vhd examples * add num to galleryimages as well * fix example: remove imagepath from response and fix sizeInMB * update vhd example response with other properties * fix vm create vlow * fix example imagereference * fix osdisk camel case * remove securityprofile from response * add readonly to sizeInMB * update disksizeBytes and readonly to sizeInMB * update missed diskSizeBytes in examples * fix camelcase * remove osprofile from response and request when osdisk is specified in vm put * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989) * add signature, set proper status properties * fix semantics * fix status for all resources and remove signature * remove imagePath from marketplacegalleryimage example * fix status name * add readonly to status * add x-ms-client-flatten, and align errorMessage/errorCode description * update property description * add powerstate to virtualmachinestatus * add provisioningstate enum and remove readonly for galleryimageversion.name * Sync azurestackhci 2021-07 changes to 2021-09 (#7106) * sync marketplacegalleryimage descriptions * Add to custom words and fix example * fix updatemarketplacegalleryimage.json * add marketplaceGalleryImages to readme * update all references to v3 * Revert "update all references to v3" This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a. * npm run prettier * User/vishalk/storage container rpsaasdev (#7084) * swagger chanfes * added availablesize and containersize in status Co-authored-by: Vishal Kadam <[email protected]> * V3 to v2 * fix typo * Revert "fix typo" This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9. * Revert "V3 to v2" This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e. * convert all to v3 * v3 to v2, add ListOperationByCluster example * linter feedback * more fix based on linter feedback * fix breaking change errors * continue fixing breaking change * User/vishalk/storage container (#5953) * updated VHD object * updated storage container swagger * added available size property * updated description of path Co-authored-by: Vishal Kadam <[email protected]> * Add canceled to provisioningState enum Co-authored-by: Arka <[email protected]> Co-authored-by: vishal-kadam <[email protected]> Co-authored-by: Vishal Kadam <[email protected]>
* storage container changes * added availableSizeGB and containerSizeGB properties * changed data type of containersize and availablesize * converted gb to mb * made availableSizeMB and containerSizeMB fields readonly Co-authored-by: Vishal Kadam <[email protected]>
* change hybrididentitymetadata vmid to resourceUid * update examples
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/9073 |
Hi, @pathuang-sia Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.2)] | new version | base version |
---|---|---|
arcSettings.json | 2021-09-01-preview(f4fee3c) | 2021-09-01(main) |
arcSettings.json | 2021-09-01-preview(f4fee3c) | 2021-01-01-preview(main) |
clusters.json | 2021-09-01-preview(f4fee3c) | 2021-09-01(main) |
clusters.json | 2021-09-01-preview(f4fee3c) | 2021-01-01-preview(main) |
common.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
extensions.json | 2021-09-01-preview(f4fee3c) | 2021-09-01(main) |
extensions.json | 2021-09-01-preview(f4fee3c) | 2021-01-01-preview(main) |
galleryImages.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
networkInterfaces.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
operations.json | 2021-09-01-preview(f4fee3c) | 2021-09-01(main) |
operations.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
virtualHardDisks.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
virtualMachines.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
virtualNetworks.json | 2021-09-01-preview(f4fee3c) | 2021-07-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 149 Warnings warning [Detail]
compared tags (via openapi-validator v2.0.0) | new version | base version |
---|---|---|
package-preview-2021-09 | package-preview-2021-09(f4fee3c) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
'GET' operation 'galleryimages_Retrieve' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L42 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L42 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L79 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L103 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L134 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L171 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L191 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L224 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L263 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L42 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L79 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L103 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L134 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L171 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L191 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L224 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L263 |
||
'GET' operation 'networkinterfaces_Retrieve' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L42 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L42 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L56 |
||
Operation should have a summary or description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L78 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L79 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L96 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L102 |
||
Operation should have a summary or description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L132 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L133 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L146 |
||
Operation should have a summary or description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L168 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L169 |
||
Parameter should have a description. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L182 |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/extensions.json#L458 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️
~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️
~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi, @pathuang-sia your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I think the first letter of the property name can be lower-case: for example, galleryimagesProperties is fine. But not GalleryimagesProperties |
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296) * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * resolve conflicts * [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147) * GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751) * initial commit * syntax error fix * move galleryimageversionproperties under galleryimageproperties * add galleryimageversion as child of galleryimageproperties * update create/get galleryimage json example * remove version readonly and fix version description * add imagesource and fix imagepath example * fix getgalleryimage.json * pending to inprogress * mark secret x-ms-secret * fix osdisk uri to id in vms * update to local * create marketplacegalleryimages * fix file name * filenmae fix * file rename * file rename * add missing exampl.es * add enum * update vm and vhd examples * add num to galleryimages as well * fix example: remove imagepath from response and fix sizeInMB * update vhd example response with other properties * fix vm create vlow * fix example imagereference * fix osdisk camel case * remove securityprofile from response * add readonly to sizeInMB * update disksizeBytes and readonly to sizeInMB * update missed diskSizeBytes in examples * fix camelcase * remove osprofile from response and request when osdisk is specified in vm put * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989) * add signature, set proper status properties * fix semantics * fix status for all resources and remove signature * remove imagePath from marketplacegalleryimage example * fix status name * add readonly to status * add x-ms-client-flatten, and align errorMessage/errorCode description * update property description * add powerstate to virtualmachinestatus * add provisioningstate enum and remove readonly for galleryimageversion.name * Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106) * sync marketplacegalleryimage descriptions * Add to custom words and fix example * fix updatemarketplacegalleryimage.json * add marketplaceGalleryImages to readme * update all references to v3 * Revert "update all references to v3" This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a. * npm run prettier * User/vishalk/storage container rpsaasdev (Azure#7084) * swagger chanfes * added availablesize and containersize in status Co-authored-by: Vishal Kadam <[email protected]> * V3 to v2 * fix typo * Revert "fix typo" This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9. * Revert "V3 to v2" This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e. * convert all to v3 * v3 to v2, add ListOperationByCluster example * linter feedback * more fix based on linter feedback * fix breaking change errors * continue fixing breaking change * User/vishalk/storage container (Azure#5953) * updated VHD object * updated storage container swagger * added available size property * updated description of path Co-authored-by: Vishal Kadam <[email protected]> * Add canceled to provisioningState enum Co-authored-by: Arka <[email protected]> Co-authored-by: vishal-kadam <[email protected]> Co-authored-by: Vishal Kadam <[email protected]> * cherry-pick merge conflict resolution * storage container changes (Azure#6614) * storage container changes * added availableSizeGB and containerSizeGB properties * changed data type of containersize and availablesize * converted gb to mb * made availableSizeMB and containerSizeMB fields readonly Co-authored-by: Vishal Kadam <[email protected]> * Change hybrididentitymetadata vmid to resourceUid (Azure#4921) * change hybrididentitymetadata vmid to resourceUid * update examples * fix missed merging changes * cherry-pick merge conflict resolution * remove 2022-09-01 examples * git difftool align differences with RPSaaSMaster * spellcheck fix * breaking change cross version fix * fix version * fix custom word typo * fix default tag to 2022-10 * address description and example feedback * address swagger modelvalidation errors * missed linter and model validation error * prettier fix * fixing breaking change errors * backport common.json from 2021-07-01-preview * prettier on common.json * replace Idenitty from v2 definitions * fix property bag capitalization * Add missed capitalization modifications * Add missed semantic fix * Add missed semantic fix * revert property definition capitalization according to reviewer feedback Co-authored-by: Arka <[email protected]> Co-authored-by: vishal-kadam <[email protected]> Co-authored-by: Vishal Kadam <[email protected]> Co-authored-by: aeweston-msft <[email protected]>
…ft.AzureStackHCI-2021-09-01-preview' (Azure#21296) * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * resolve conflicts * [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147) * GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751) * initial commit * syntax error fix * move galleryimageversionproperties under galleryimageproperties * add galleryimageversion as child of galleryimageproperties * update create/get galleryimage json example * remove version readonly and fix version description * add imagesource and fix imagepath example * fix getgalleryimage.json * pending to inprogress * mark secret x-ms-secret * fix osdisk uri to id in vms * update to local * create marketplacegalleryimages * fix file name * filenmae fix * file rename * file rename * add missing exampl.es * add enum * update vm and vhd examples * add num to galleryimages as well * fix example: remove imagepath from response and fix sizeInMB * update vhd example response with other properties * fix vm create vlow * fix example imagereference * fix osdisk camel case * remove securityprofile from response * add readonly to sizeInMB * update disksizeBytes and readonly to sizeInMB * update missed diskSizeBytes in examples * fix camelcase * remove osprofile from response and request when osdisk is specified in vm put * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989) * add signature, set proper status properties * fix semantics * fix status for all resources and remove signature * remove imagePath from marketplacegalleryimage example * fix status name * add readonly to status * add x-ms-client-flatten, and align errorMessage/errorCode description * update property description * add powerstate to virtualmachinestatus * add provisioningstate enum and remove readonly for galleryimageversion.name * Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106) * sync marketplacegalleryimage descriptions * Add to custom words and fix example * fix updatemarketplacegalleryimage.json * add marketplaceGalleryImages to readme * update all references to v3 * Revert "update all references to v3" This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a. * npm run prettier * User/vishalk/storage container rpsaasdev (Azure#7084) * swagger chanfes * added availablesize and containersize in status Co-authored-by: Vishal Kadam <[email protected]> * V3 to v2 * fix typo * Revert "fix typo" This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9. * Revert "V3 to v2" This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e. * convert all to v3 * v3 to v2, add ListOperationByCluster example * linter feedback * more fix based on linter feedback * fix breaking change errors * continue fixing breaking change * User/vishalk/storage container (Azure#5953) * updated VHD object * updated storage container swagger * added available size property * updated description of path Co-authored-by: Vishal Kadam <[email protected]> * Add canceled to provisioningState enum Co-authored-by: Arka <[email protected]> Co-authored-by: vishal-kadam <[email protected]> Co-authored-by: Vishal Kadam <[email protected]> * cherry-pick merge conflict resolution * storage container changes (Azure#6614) * storage container changes * added availableSizeGB and containerSizeGB properties * changed data type of containersize and availablesize * converted gb to mb * made availableSizeMB and containerSizeMB fields readonly Co-authored-by: Vishal Kadam <[email protected]> * Change hybrididentitymetadata vmid to resourceUid (Azure#4921) * change hybrididentitymetadata vmid to resourceUid * update examples * fix missed merging changes * cherry-pick merge conflict resolution * remove 2022-09-01 examples * git difftool align differences with RPSaaSMaster * spellcheck fix * breaking change cross version fix * fix version * fix custom word typo * fix default tag to 2022-10 * address description and example feedback * address swagger modelvalidation errors * missed linter and model validation error * prettier fix * fixing breaking change errors * backport common.json from 2021-07-01-preview * prettier on common.json * replace Idenitty from v2 definitions * fix property bag capitalization * Add missed capitalization modifications * Add missed semantic fix * Add missed semantic fix * revert property definition capitalization according to reviewer feedback Co-authored-by: Arka <[email protected]> Co-authored-by: vishal-kadam <[email protected]> Co-authored-by: Vishal Kadam <[email protected]> Co-authored-by: aeweston-msft <[email protected]>
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.