Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'release-azurestackhci-Microsoft.AzureStackHCI-2021-09-01-preview' #21296

Conversation

pathuang-sia
Copy link
Contributor

@pathuang-sia pathuang-sia commented Oct 26, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

pathuang-sia and others added 17 commits October 3, 2022 13:34
* GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (#6751)

* initial commit

* syntax error fix

* move galleryimageversionproperties under galleryimageproperties

* add galleryimageversion as child of galleryimageproperties

* update create/get galleryimage json example

* remove version readonly and fix version description

* add imagesource and fix imagepath example

* fix getgalleryimage.json

* pending to inprogress

* mark secret x-ms-secret

* fix osdisk uri to id in vms

* update to local

* create marketplacegalleryimages

* fix file name

* filenmae fix

* file rename

* file rename

* add missing exampl.es

* add enum

* update vm and vhd examples

* add num to galleryimages as well

* fix example: remove imagepath from response and fix sizeInMB

* update vhd example response with other properties

* fix vm create vlow

* fix example imagereference

* fix osdisk camel case

* remove securityprofile from response

* add readonly to sizeInMB

* update disksizeBytes and readonly to sizeInMB

* update missed diskSizeBytes in examples

* fix camelcase

* remove osprofile from response and request when osdisk is specified in vm put

* Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (#6989)

* add signature, set proper status properties

* fix semantics

* fix status for all resources and remove signature

* remove imagePath from marketplacegalleryimage example

* fix status name

* add readonly to status

* add x-ms-client-flatten, and align errorMessage/errorCode description

* update property description

* add powerstate to virtualmachinestatus

* add provisioningstate enum and remove readonly for galleryimageversion.name

* Sync azurestackhci 2021-07 changes to 2021-09 (#7106)

* sync marketplacegalleryimage descriptions

* Add to custom words and fix example

* fix updatemarketplacegalleryimage.json

* add marketplaceGalleryImages to readme

* update all references to v3

* Revert "update all references to v3"

This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.

* npm run prettier

* User/vishalk/storage container rpsaasdev (#7084)

* swagger chanfes

* added availablesize and containersize in status

Co-authored-by: Vishal Kadam <[email protected]>

* V3 to v2

* fix typo

* Revert "fix typo"

This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.

* Revert "V3 to v2"

This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.

* convert all to v3

* v3 to v2, add ListOperationByCluster example

* linter feedback

* more fix based on linter feedback

* fix breaking change errors

* continue fixing breaking change

* User/vishalk/storage container (#5953)

* updated VHD object

* updated storage container swagger

* added available size property

* updated description of path

Co-authored-by: Vishal Kadam <[email protected]>

* Add canceled to provisioningState enum

Co-authored-by: Arka <[email protected]>
Co-authored-by: vishal-kadam <[email protected]>
Co-authored-by: Vishal Kadam <[email protected]>
* storage container changes

* added availableSizeGB and containerSizeGB properties

* changed data type of containersize and availablesize

* converted gb to mb

* made availableSizeMB and containerSizeMB fields readonly

Co-authored-by: Vishal Kadam <[email protected]>
* change hybrididentitymetadata vmid to resourceUid

* update examples
@pathuang-sia
Copy link
Contributor Author

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/9073

@openapi-workflow-bot
Copy link

Hi, @pathuang-sia Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 27 Errors, 2 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.2)] new version base version
    arcSettings.json 2021-09-01-preview(f4fee3c) 2021-09-01(main)
    arcSettings.json 2021-09-01-preview(f4fee3c) 2021-01-01-preview(main)
    clusters.json 2021-09-01-preview(f4fee3c) 2021-09-01(main)
    clusters.json 2021-09-01-preview(f4fee3c) 2021-01-01-preview(main)
    common.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)
    extensions.json 2021-09-01-preview(f4fee3c) 2021-09-01(main)
    extensions.json 2021-09-01-preview(f4fee3c) 2021-01-01-preview(main)
    galleryImages.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)
    networkInterfaces.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)
    operations.json 2021-09-01-preview(f4fee3c) 2021-09-01(main)
    operations.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)
    virtualHardDisks.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)
    virtualMachines.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)
    virtualNetworks.json 2021-09-01-preview(f4fee3c) 2021-07-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L213:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L210:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualHardDisks.json#L210:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualMachines.json#L216:11
    1011 - AddingResponseCode The new version adds a response code '201'.
    New: Microsoft.AzureStackHCI/preview/2021-09-01-preview/virtualNetworks.json#L209:11
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: common-types/resource-management/v2/types.json#L98:7
    Old: common-types/resource-management/v3/types.json#L104:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L37:7
    Old: common-types/resource-management/v3/types.json#L43:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: common-types/resource-management/v3/types.json#L13:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L54:7
    Old: common-types/resource-management/v3/types.json#L60:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L37:7
    Old: common-types/resource-management/v3/types.json#L43:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: common-types/resource-management/v3/types.json#L13:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L54:7
    Old: common-types/resource-management/v3/types.json#L60:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L37:7
    Old: common-types/resource-management/v3/types.json#L43:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: common-types/resource-management/v3/types.json#L13:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L54:7
    Old: common-types/resource-management/v3/types.json#L60:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L37:7
    Old: common-types/resource-management/v3/types.json#L43:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: common-types/resource-management/v3/types.json#L13:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L98:7
    Old: common-types/resource-management/v3/types.json#L104:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L54:7
    Old: common-types/resource-management/v3/types.json#L60:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L37:7
    Old: common-types/resource-management/v3/types.json#L43:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: common-types/resource-management/v3/types.json#L13:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: common-types/resource-management/v2/types.json#L54:7
    Old: common-types/resource-management/v3/types.json#L60:7
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v2/types.json#L195:9
    Old: common-types/resource-management/v3/types.json#L179:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: common-types/resource-management/v2/types.json#L95:5
    Old: common-types/resource-management/v3/types.json#L101:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 149 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2021-09 package-preview-2021-09(f4fee3c) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Only 30 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    ⚠️ GetInOperationName 'GET' operation 'galleryimages_Retrieve' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L42
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L42
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L79
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L103
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L134
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L171
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L191
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L224
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'galleryimagesModel'. Consider using the plural form of 'galleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/galleryImages.json#L263
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L42
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L79
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L103
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L134
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L171
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L191
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L224
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'marketplacegalleryimagesModel'. Consider using the plural form of 'marketplacegalleryimages' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/marketplaceGalleryImages.json#L263
    ⚠️ GetInOperationName 'GET' operation 'networkinterfaces_Retrieve' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L42
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L42
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L56
    ⚠️ OperationSummaryOrDescription Operation should have a summary or description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L78
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L79
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L96
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L102
    ⚠️ OperationSummaryOrDescription Operation should have a summary or description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L132
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L133
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L146
    ⚠️ OperationSummaryOrDescription Operation should have a summary or description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L168
    ⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'networkinterfacesModel'. Consider using the plural form of 'networkinterfaces' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L169
    ⚠️ ParameterDescription Parameter should have a description.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/networkInterfaces.json#L182


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.AzureStackHCI/preview/2021-09-01-preview/extensions.json#L458
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-python-track2 - track2_azure-mgmt-azurestackhci - Approved - 7.0.0
    +	Model ArcSetting no longer has parameter created_at
    +	Model ArcSetting no longer has parameter created_by
    +	Model ArcSetting no longer has parameter created_by_type
    +	Model ArcSetting no longer has parameter last_modified_at
    +	Model ArcSetting no longer has parameter last_modified_by
    +	Model ArcSetting no longer has parameter last_modified_by_type
    +	Model Cluster no longer has parameter created_at
    +	Model Cluster no longer has parameter created_by
    +	Model Cluster no longer has parameter created_by_type
    +	Model Cluster no longer has parameter last_modified_at
    +	Model Cluster no longer has parameter last_modified_by
    +	Model Cluster no longer has parameter last_modified_by_type
    +	Model Extension no longer has parameter created_at
    +	Model Extension no longer has parameter created_by
    +	Model Extension no longer has parameter created_by_type
    +	Model Extension no longer has parameter last_modified_at
    +	Model Extension no longer has parameter last_modified_by
    +	Model Extension no longer has parameter last_modified_by_type

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8bcf420. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Hci [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8bcf420. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-azurestackhci [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation ClustersOperations.begin_extend_software_assurance_benefit
      info	[Changelog]   - Added operation group OffersOperations
      info	[Changelog]   - Added operation group PublishersOperations
      info	[Changelog]   - Added operation group SkusOperations
      info	[Changelog]   - Added operation group UpdateRunsOperations
      info	[Changelog]   - Added operation group UpdateSummariesOperations
      info	[Changelog]   - Added operation group UpdatesOperations
      info	[Changelog]   - Model ArcSetting has a new parameter system_data
      info	[Changelog]   - Model Cluster has a new parameter principal_id
      info	[Changelog]   - Model Cluster has a new parameter software_assurance_properties
      info	[Changelog]   - Model Cluster has a new parameter system_data
      info	[Changelog]   - Model Cluster has a new parameter tenant_id
      info	[Changelog]   - Model Cluster has a new parameter type_identity_type
      info	[Changelog]   - Model Cluster has a new parameter user_assigned_identities
      info	[Changelog]   - Model ClusterNode has a new parameter node_type
      info	[Changelog]   - Model ClusterNode has a new parameter os_display_version
      info	[Changelog]   - Model ClusterPatch has a new parameter principal_id
      info	[Changelog]   - Model ClusterPatch has a new parameter tenant_id
      info	[Changelog]   - Model ClusterPatch has a new parameter type
      info	[Changelog]   - Model ClusterPatch has a new parameter user_assigned_identities
      info	[Changelog]   - Model Extension has a new parameter system_data
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ArcSetting no longer has parameter created_at
      info	[Changelog]   - Model ArcSetting no longer has parameter created_by
      info	[Changelog]   - Model ArcSetting no longer has parameter created_by_type
      info	[Changelog]   - Model ArcSetting no longer has parameter last_modified_at
      info	[Changelog]   - Model ArcSetting no longer has parameter last_modified_by
      info	[Changelog]   - Model ArcSetting no longer has parameter last_modified_by_type
      info	[Changelog]   - Model Cluster no longer has parameter created_at
      info	[Changelog]   - Model Cluster no longer has parameter created_by
      info	[Changelog]   - Model Cluster no longer has parameter created_by_type
      info	[Changelog]   - Model Cluster no longer has parameter last_modified_at
      info	[Changelog]   - Model Cluster no longer has parameter last_modified_by
      info	[Changelog]   - Model Cluster no longer has parameter last_modified_by_type
      info	[Changelog]   - Model Extension no longer has parameter created_at
      info	[Changelog]   - Model Extension no longer has parameter created_by
      info	[Changelog]   - Model Extension no longer has parameter created_by_type
      info	[Changelog]   - Model Extension no longer has parameter last_modified_at
      info	[Changelog]   - Model Extension no longer has parameter last_modified_by
      info	[Changelog]   - Model Extension no longer has parameter last_modified_by_type
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8bcf420. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8bcf420. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/azurestackhci/armazurestackhci [View full logs]  [Release SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New const `UpdateSummariesPropertiesStateUpdateInProgress`
      info	[Changelog] - New const `UpdateRunPropertiesStateUnknown`
      info	[Changelog] - New const `ManagedServiceIdentityTypeNone`
      info	[Changelog] - New const `StateScanInProgress`
      info	[Changelog] - New const `StateDownloadFailed`
      info	[Changelog] - New const `StatePreparationFailed`
      info	[Changelog] - New const `StateReadyToInstall`
      info	[Changelog] - New const `StateNotApplicableBecauseAnotherUpdateIsInProgress`
      info	[Changelog] - New const `UpdateSummariesPropertiesStateUnknown`
      info	[Changelog] - New type alias `ClusterNodeType`
      info	[Changelog] - New type alias `AvailabilityType`
      info	[Changelog] - New type alias `UpdateRunPropertiesState`
      info	[Changelog] - New type alias `UpdateSummariesPropertiesState`
      info	[Changelog] - New type alias `ManagedServiceIdentityType`
      info	[Changelog] - New type alias `SoftwareAssuranceIntent`
      info	[Changelog] - New type alias `State`
      info	[Changelog] - New type alias `SoftwareAssuranceStatus`
      info	[Changelog] - New function `*SKUsClient.NewListByOfferPager(string, string, string, string, *SKUsClientListByOfferOptions) *runtime.Pager[SKUsClientListByOfferResponse]`
      info	[Changelog] - New function `PossibleClusterNodeTypeValues() []ClusterNodeType`
      info	[Changelog] - New function `PossibleSoftwareAssuranceIntentValues() []SoftwareAssuranceIntent`
      info	[Changelog] - New function `PossibleStateValues() []State`
      info	[Changelog] - New function `PossibleAvailabilityTypeValues() []AvailabilityType`
      info	[Changelog] - New function `*UpdatesClient.BeginPost(context.Context, string, string, string, *UpdatesClientBeginPostOptions) (*runtime.Poller[UpdatesClientPostResponse], error)`
      info	[Changelog] - New function `*PublishersClient.NewListByClusterPager(string, string, *PublishersClientListByClusterOptions) *runtime.Pager[PublishersClientListByClusterResponse]`
      info	[Changelog] - New function `NewUpdateRunsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdateRunsClient, error)`
      info	[Changelog] - New function `*PublishersClient.Get(context.Context, string, string, string, *PublishersClientGetOptions) (PublishersClientGetResponse, error)`
      info	[Changelog] - New function `NewOffersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OffersClient, error)`
      info	[Changelog] - New function `*OffersClient.Get(context.Context, string, string, string, string, *OffersClientGetOptions) (OffersClientGetResponse, error)`
      info	[Changelog] - New function `*UpdatesClient.Get(context.Context, string, string, string, *UpdatesClientGetOptions) (UpdatesClientGetResponse, error)`
      info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
      info	[Changelog] - New function `PossibleUpdateRunPropertiesStateValues() []UpdateRunPropertiesState`
      info	[Changelog] - New function `PossibleManagedServiceIdentityTypeValues() []ManagedServiceIdentityType`
      info	[Changelog] - New function `*UpdateRunsClient.Get(context.Context, string, string, string, string, *UpdateRunsClientGetOptions) (UpdateRunsClientGetResponse, error)`
      info	[Changelog] - New function `*ClustersClient.BeginExtendSoftwareAssuranceBenefit(context.Context, string, string, SoftwareAssuranceChangeRequest, *ClustersClientBeginExtendSoftwareAssuranceBenefitOptions) (*runtime.Poller[ClustersClientExtendSoftwareAssuranceBenefitResponse], error)`
      info	[Changelog] - New function `*SKUsClient.Get(context.Context, string, string, string, string, string, *SKUsClientGetOptions) (SKUsClientGetResponse, error)`
      info	[Changelog] - New function `*UpdateSummariesClient.Get(context.Context, string, string, *UpdateSummariesClientGetOptions) (UpdateSummariesClientGetResponse, error)`
      info	[Changelog] - New function `*OffersClient.NewListByPublisherPager(string, string, string, *OffersClientListByPublisherOptions) *runtime.Pager[OffersClientListByPublisherResponse]`
      info	[Changelog] - New function `*UpdateRunsClient.NewListPager(string, string, string, *UpdateRunsClientListOptions) *runtime.Pager[UpdateRunsClientListResponse]`
      info	[Changelog] - New function `PossibleUpdateSummariesPropertiesStateValues() []UpdateSummariesPropertiesState`
      info	[Changelog] - New function `*UpdatesClient.NewListPager(string, string, *UpdatesClientListOptions) *runtime.Pager[UpdatesClientListResponse]`
      info	[Changelog] - New function `*OffersClient.NewListByClusterPager(string, string, *OffersClientListByClusterOptions) *runtime.Pager[OffersClientListByClusterResponse]`
      info	[Changelog] - New function `*UpdateSummariesClient.NewListPager(string, string, *UpdateSummariesClientListOptions) *runtime.Pager[UpdateSummariesClientListResponse]`
      info	[Changelog] - New function `NewUpdateSummariesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdateSummariesClient, error)`
      info	[Changelog] - New function `PossibleSoftwareAssuranceStatusValues() []SoftwareAssuranceStatus`
      info	[Changelog] - New function `NewUpdatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdatesClient, error)`
      info	[Changelog] - New function `NewPublishersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PublishersClient, error)`
      info	[Changelog] - New struct `ClustersClientBeginExtendSoftwareAssuranceBenefitOptions`
      info	[Changelog] - New struct `ClustersClientExtendSoftwareAssuranceBenefitResponse`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `Offer`
      info	[Changelog] - New struct `OfferList`
      info	[Changelog] - New struct `OfferProperties`
      info	[Changelog] - New struct `OffersClient`
      info	[Changelog] - New struct `OffersClientGetOptions`
      info	[Changelog] - New struct `OffersClientGetResponse`
      info	[Changelog] - New struct `OffersClientListByClusterOptions`
      info	[Changelog] - New struct `OffersClientListByClusterResponse`
      info	[Changelog] - New struct `OffersClientListByPublisherOptions`
      info	[Changelog] - New struct `OffersClientListByPublisherResponse`
      info	[Changelog] - New struct `PackageVersionInfo`
      info	[Changelog] - New struct `Publisher`
      info	[Changelog] - New struct `PublisherList`
      info	[Changelog] - New struct `PublisherProperties`
      info	[Changelog] - New struct `PublishersClient`
      info	[Changelog] - New struct `PublishersClientGetOptions`
      info	[Changelog] - New struct `PublishersClientGetResponse`
      info	[Changelog] - New struct `PublishersClientListByClusterOptions`
      info	[Changelog] - New struct `PublishersClientListByClusterResponse`
      info	[Changelog] - New struct `SKU`
      info	[Changelog] - New struct `SKUList`
      info	[Changelog] - New struct `SKUMappings`
      info	[Changelog] - New struct `SKUProperties`
      info	[Changelog] - New struct `SKUsClient`
      info	[Changelog] - New struct `SKUsClientGetOptions`
      info	[Changelog] - New struct `SKUsClientGetResponse`
      info	[Changelog] - New struct `SKUsClientListByOfferOptions`
      info	[Changelog] - New struct `SKUsClientListByOfferResponse`
      info	[Changelog] - New struct `SoftwareAssuranceChangeRequest`
      info	[Changelog] - New struct `SoftwareAssuranceChangeRequestProperties`
      info	[Changelog] - New struct `SoftwareAssuranceProperties`
      info	[Changelog] - New struct `Step`
      info	[Changelog] - New struct `Update`
      info	[Changelog] - New struct `UpdateList`
      info	[Changelog] - New struct `UpdatePrerequisite`
      info	[Changelog] - New struct `UpdateProperties`
      info	[Changelog] - New struct `UpdateRun`
      info	[Changelog] - New struct `UpdateRunList`
      info	[Changelog] - New struct `UpdateRunProperties`
      info	[Changelog] - New struct `UpdateRunsClient`
      info	[Changelog] - New struct `UpdateRunsClientGetOptions`
      info	[Changelog] - New struct `UpdateRunsClientGetResponse`
      info	[Changelog] - New struct `UpdateRunsClientListOptions`
      info	[Changelog] - New struct `UpdateRunsClientListResponse`
      info	[Changelog] - New struct `UpdateStateProperties`
      info	[Changelog] - New struct `UpdateSummaries`
      info	[Changelog] - New struct `UpdateSummariesClient`
      info	[Changelog] - New struct `UpdateSummariesClientGetOptions`
      info	[Changelog] - New struct `UpdateSummariesClientGetResponse`
      info	[Changelog] - New struct `UpdateSummariesClientListOptions`
      info	[Changelog] - New struct `UpdateSummariesClientListResponse`
      info	[Changelog] - New struct `UpdateSummariesList`
      info	[Changelog] - New struct `UpdateSummariesProperties`
      info	[Changelog] - New struct `UpdatesClient`
      info	[Changelog] - New struct `UpdatesClientBeginPostOptions`
      info	[Changelog] - New struct `UpdatesClientGetOptions`
      info	[Changelog] - New struct `UpdatesClientGetResponse`
      info	[Changelog] - New struct `UpdatesClientListOptions`
      info	[Changelog] - New struct `UpdatesClientListResponse`
      info	[Changelog] - New struct `UpdatesClientPostResponse`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New field `SoftwareAssuranceProperties` in struct `ClusterProperties`
      info	[Changelog] - New field `OSDisplayVersion` in struct `ClusterNode`
      info	[Changelog] - New field `NodeType` in struct `ClusterNode`
      info	[Changelog] - New field `Identity` in struct `Cluster`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog] - New field `Identity` in struct `ClusterPatch`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 215 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8bcf420. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-azurestackhci [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group Offers
      info	[Changelog]   - Added operation group Publishers
      info	[Changelog]   - Added operation group Skus
      info	[Changelog]   - Added operation group UpdateRuns
      info	[Changelog]   - Added operation group Updates
      info	[Changelog]   - Added operation group UpdateSummariesOperations
      info	[Changelog]   - Added operation Clusters.beginExtendSoftwareAssuranceBenefit
      info	[Changelog]   - Added operation Clusters.beginExtendSoftwareAssuranceBenefitAndWait
      info	[Changelog]   - Added Interface ArcSetting
      info	[Changelog]   - Added Interface Cluster
      info	[Changelog]   - Added Interface ClustersExtendSoftwareAssuranceBenefitOptionalParams
      info	[Changelog]   - Added Interface Extension
      info	[Changelog]   - Added Interface Offer
      info	[Changelog]   - Added Interface OfferList
      info	[Changelog]   - Added Interface OffersGetOptionalParams
      info	[Changelog]   - Added Interface OffersListByClusterNextOptionalParams
      info	[Changelog]   - Added Interface OffersListByClusterOptionalParams
      info	[Changelog]   - Added Interface OffersListByPublisherNextOptionalParams
      info	[Changelog]   - Added Interface OffersListByPublisherOptionalParams
      info	[Changelog]   - Added Interface PackageVersionInfo
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface Publisher
      info	[Changelog]   - Added Interface PublisherList
      info	[Changelog]   - Added Interface PublishersGetOptionalParams
      info	[Changelog]   - Added Interface PublishersListByClusterNextOptionalParams
      info	[Changelog]   - Added Interface PublishersListByClusterOptionalParams
      info	[Changelog]   - Added Interface Sku
      info	[Changelog]   - Added Interface SkuList
      info	[Changelog]   - Added Interface SkuMappings
      info	[Changelog]   - Added Interface SkusGetOptionalParams
      info	[Changelog]   - Added Interface SkusListByOfferNextOptionalParams
      info	[Changelog]   - Added Interface SkusListByOfferOptionalParams
      info	[Changelog]   - Added Interface SoftwareAssuranceChangeRequest
      info	[Changelog]   - Added Interface SoftwareAssuranceChangeRequestProperties
      info	[Changelog]   - Added Interface SoftwareAssuranceProperties
      info	[Changelog]   - Added Interface Step
      info	[Changelog]   - Added Interface SystemData
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface Update
      info	[Changelog]   - Added Interface UpdateList
      info	[Changelog]   - Added Interface UpdatePrerequisite
      info	[Changelog]   - Added Interface UpdateRun
      info	[Changelog]   - Added Interface UpdateRunList
      info	[Changelog]   - Added Interface UpdateRunsGetOptionalParams
      info	[Changelog]   - Added Interface UpdateRunsListNextOptionalParams
      info	[Changelog]   - Added Interface UpdateRunsListOptionalParams
      info	[Changelog]   - Added Interface UpdatesGetOptionalParams
      info	[Changelog]   - Added Interface UpdatesListNextOptionalParams
      info	[Changelog]   - Added Interface UpdatesListOptionalParams
      info	[Changelog]   - Added Interface UpdatesPostOptionalParams
      info	[Changelog]   - Added Interface UpdateSummaries
      info	[Changelog]   - Added Interface UpdateSummariesGetOptionalParams
      info	[Changelog]   - Added Interface UpdateSummariesList
      info	[Changelog]   - Added Interface UpdateSummariesListNextOptionalParams
      info	[Changelog]   - Added Interface UpdateSummariesListOptionalParams
      info	[Changelog]   - Added Interface UserAssignedIdentity
      info	[Changelog]   - Added Type Alias AvailabilityType
      info	[Changelog]   - Added Type Alias ClusterNodeType
      info	[Changelog]   - Added Type Alias ClustersExtendSoftwareAssuranceBenefitResponse
      info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
      info	[Changelog]   - Added Type Alias OffersGetResponse
      info	[Changelog]   - Added Type Alias OffersListByClusterNextResponse
      info	[Changelog]   - Added Type Alias OffersListByClusterResponse
      info	[Changelog]   - Added Type Alias OffersListByPublisherNextResponse
      info	[Changelog]   - Added Type Alias OffersListByPublisherResponse
      info	[Changelog]   - Added Type Alias PublishersGetResponse
      info	[Changelog]   - Added Type Alias PublishersListByClusterNextResponse
      info	[Changelog]   - Added Type Alias PublishersListByClusterResponse
      info	[Changelog]   - Added Type Alias SkusGetResponse
      info	[Changelog]   - Added Type Alias SkusListByOfferNextResponse
      info	[Changelog]   - Added Type Alias SkusListByOfferResponse
      info	[Changelog]   - Added Type Alias SoftwareAssuranceIntent
      info	[Changelog]   - Added Type Alias SoftwareAssuranceStatus
      info	[Changelog]   - Added Type Alias State
      info	[Changelog]   - Added Type Alias UpdateRunPropertiesState
      info	[Changelog]   - Added Type Alias UpdateRunsGetResponse
      info	[Changelog]   - Added Type Alias UpdateRunsListNextResponse
      info	[Changelog]   - Added Type Alias UpdateRunsListResponse
      info	[Changelog]   - Added Type Alias UpdatesGetResponse
      info	[Changelog]   - Added Type Alias UpdatesListNextResponse
      info	[Changelog]   - Added Type Alias UpdatesListResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesGetResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesListNextResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesListResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesPropertiesState
      info	[Changelog]   - Interface ClusterNode has a new optional parameter nodeType
      info	[Changelog]   - Interface ClusterNode has a new optional parameter osDisplayVersion
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter principalId
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter tenantId
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter type
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter userAssignedIdentities
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Class AzureStackHCIClient has a new parameter offers
      info	[Changelog]   - Class AzureStackHCIClient has a new parameter publishers
      info	[Changelog]   - Class AzureStackHCIClient has a new parameter skus
      info	[Changelog]   - Class AzureStackHCIClient has a new parameter updateRuns
      info	[Changelog]   - Class AzureStackHCIClient has a new parameter updates
      info	[Changelog]   - Class AzureStackHCIClient has a new parameter updateSummariesOperations
      info	[Changelog]   - Added Enum KnownAvailabilityType
      info	[Changelog]   - Added Enum KnownClusterNodeType
      info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
      info	[Changelog]   - Added Enum KnownSoftwareAssuranceIntent
      info	[Changelog]   - Added Enum KnownSoftwareAssuranceStatus
      info	[Changelog]   - Added Enum KnownState
      info	[Changelog]   - Added Enum KnownUpdateRunPropertiesState
      info	[Changelog]   - Added Enum KnownUpdateSummariesPropertiesState
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 8bcf420. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️azurestackhci [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 8bcf420. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.StackHci [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 26, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/azurestackhci/armazurestackhci Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-azurestackhci Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Hci Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-azurestackhci Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 26, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @pathuang-sia your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @xiaoxuqi-ms
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @xiaoxuqi-ms
    Copy link
    Member

    I think the first letter of the property name can be lower-case: for example, galleryimagesProperties is fine. But not GalleryimagesProperties

    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels Nov 11, 2022
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 14, 2022
    @xiaoxuqi-ms xiaoxuqi-ms merged commit 8bcf420 into main Nov 15, 2022
    @xiaoxuqi-ms xiaoxuqi-ms deleted the published/pathuang-sia/azure-rest-api-specs-pr/release-azurestackhci-Microsoft.AzureStackHCI-2021-09-01-preview branch November 15, 2022 01:44
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    …ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)
    
    * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * resolve conflicts
    
    * [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)
    
    * GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)
    
    * initial commit
    
    * syntax error fix
    
    * move galleryimageversionproperties under galleryimageproperties
    
    * add galleryimageversion as child of galleryimageproperties
    
    * update create/get galleryimage json example
    
    * remove version readonly and fix version description
    
    * add imagesource and fix imagepath example
    
    * fix getgalleryimage.json
    
    * pending to inprogress
    
    * mark secret x-ms-secret
    
    * fix osdisk uri to id in vms
    
    * update to local
    
    * create marketplacegalleryimages
    
    * fix file name
    
    * filenmae fix
    
    * file rename
    
    * file rename
    
    * add missing exampl.es
    
    * add enum
    
    * update vm and vhd examples
    
    * add num to galleryimages as well
    
    * fix example: remove imagepath from response and fix sizeInMB
    
    * update vhd example response with other properties
    
    * fix vm create vlow
    
    * fix example imagereference
    
    * fix osdisk camel case
    
    * remove securityprofile from response
    
    * add readonly to sizeInMB
    
    * update disksizeBytes and readonly to sizeInMB
    
    * update missed diskSizeBytes in examples
    
    * fix camelcase
    
    * remove osprofile from response and request when osdisk is specified in vm put
    
    * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)
    
    * add signature, set proper status properties
    
    * fix semantics
    
    * fix status for all resources and remove signature
    
    * remove imagePath from marketplacegalleryimage example
    
    * fix status name
    
    * add readonly to status
    
    * add x-ms-client-flatten, and align errorMessage/errorCode description
    
    * update property description
    
    * add powerstate to virtualmachinestatus
    
    * add provisioningstate enum and remove readonly for galleryimageversion.name
    
    * Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)
    
    * sync marketplacegalleryimage descriptions
    
    * Add to custom words and fix example
    
    * fix updatemarketplacegalleryimage.json
    
    * add marketplaceGalleryImages to readme
    
    * update all references to v3
    
    * Revert "update all references to v3"
    
    This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.
    
    * npm run prettier
    
    * User/vishalk/storage container rpsaasdev (Azure#7084)
    
    * swagger chanfes
    
    * added availablesize and containersize in status
    
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * V3 to v2
    
    * fix typo
    
    * Revert "fix typo"
    
    This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.
    
    * Revert "V3 to v2"
    
    This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.
    
    * convert all to v3
    
    * v3 to v2, add ListOperationByCluster example
    
    * linter feedback
    
    * more fix based on linter feedback
    
    * fix breaking change errors
    
    * continue fixing breaking change
    
    * User/vishalk/storage container (Azure#5953)
    
    * updated VHD object
    
    * updated storage container swagger
    
    * added available size property
    
    * updated description of path
    
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * Add canceled to provisioningState enum
    
    Co-authored-by: Arka <[email protected]>
    Co-authored-by: vishal-kadam <[email protected]>
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * cherry-pick merge conflict resolution
    
    * storage container changes (Azure#6614)
    
    * storage container changes
    
    * added availableSizeGB and containerSizeGB properties
    
    * changed data type of containersize and availablesize
    
    * converted gb to mb
    
    * made availableSizeMB and containerSizeMB fields readonly
    
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * Change hybrididentitymetadata vmid to resourceUid (Azure#4921)
    
    * change hybrididentitymetadata vmid to resourceUid
    
    * update examples
    
    * fix missed merging changes
    
    * cherry-pick merge conflict resolution
    
    * remove 2022-09-01 examples
    
    * git difftool align differences with RPSaaSMaster
    
    * spellcheck fix
    
    * breaking change cross version fix
    
    * fix version
    
    * fix custom word typo
    
    * fix default tag to 2022-10
    
    * address description and example feedback
    
    * address swagger modelvalidation errors
    
    * missed linter and model validation error
    
    * prettier fix
    
    * fixing breaking change errors
    
    * backport common.json from 2021-07-01-preview
    
    * prettier on common.json
    
    * replace Idenitty from v2 definitions
    
    * fix property bag capitalization
    
    * Add missed capitalization modifications
    
    * Add missed semantic fix
    
    * Add missed semantic fix
    
    * revert property definition capitalization according to reviewer feedback
    
    Co-authored-by: Arka <[email protected]>
    Co-authored-by: vishal-kadam <[email protected]>
    Co-authored-by: Vishal Kadam <[email protected]>
    Co-authored-by: aeweston-msft <[email protected]>
    kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022
    …ft.AzureStackHCI-2021-09-01-preview' (Azure#21296)
    
    * Adds base for updating Microsoft.AzureStackHCI from version stable/2021-09-01 to version 2021-09-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * resolve conflicts
    
    * [Microsoft.AzureStackHCI] 2021-09-01-preview update (Azure#7147)
    
    * GalleryImage, MarketplaceGalleryImage, VirtualMachine, and VirtualHardDisk 2021-09-01-preview changes (Azure#6751)
    
    * initial commit
    
    * syntax error fix
    
    * move galleryimageversionproperties under galleryimageproperties
    
    * add galleryimageversion as child of galleryimageproperties
    
    * update create/get galleryimage json example
    
    * remove version readonly and fix version description
    
    * add imagesource and fix imagepath example
    
    * fix getgalleryimage.json
    
    * pending to inprogress
    
    * mark secret x-ms-secret
    
    * fix osdisk uri to id in vms
    
    * update to local
    
    * create marketplacegalleryimages
    
    * fix file name
    
    * filenmae fix
    
    * file rename
    
    * file rename
    
    * add missing exampl.es
    
    * add enum
    
    * update vm and vhd examples
    
    * add num to galleryimages as well
    
    * fix example: remove imagepath from response and fix sizeInMB
    
    * update vhd example response with other properties
    
    * fix vm create vlow
    
    * fix example imagereference
    
    * fix osdisk camel case
    
    * remove securityprofile from response
    
    * add readonly to sizeInMB
    
    * update disksizeBytes and readonly to sizeInMB
    
    * update missed diskSizeBytes in examples
    
    * fix camelcase
    
    * remove osprofile from response and request when osdisk is specified in vm put
    
    * Add signature, set proper status properties to galleryImages & marketplaceGalleryImages (Azure#6989)
    
    * add signature, set proper status properties
    
    * fix semantics
    
    * fix status for all resources and remove signature
    
    * remove imagePath from marketplacegalleryimage example
    
    * fix status name
    
    * add readonly to status
    
    * add x-ms-client-flatten, and align errorMessage/errorCode description
    
    * update property description
    
    * add powerstate to virtualmachinestatus
    
    * add provisioningstate enum and remove readonly for galleryimageversion.name
    
    * Sync azurestackhci 2021-07 changes to 2021-09 (Azure#7106)
    
    * sync marketplacegalleryimage descriptions
    
    * Add to custom words and fix example
    
    * fix updatemarketplacegalleryimage.json
    
    * add marketplaceGalleryImages to readme
    
    * update all references to v3
    
    * Revert "update all references to v3"
    
    This reverts commit 186589ff6ab6f0d3b5257c2ebe8b078e1f29052a.
    
    * npm run prettier
    
    * User/vishalk/storage container rpsaasdev (Azure#7084)
    
    * swagger chanfes
    
    * added availablesize and containersize in status
    
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * V3 to v2
    
    * fix typo
    
    * Revert "fix typo"
    
    This reverts commit 8ea4035c868811dedcf3d7db17cfb9decb3814f9.
    
    * Revert "V3 to v2"
    
    This reverts commit c04f9f7254e28485bfe2fa6a9fbcf9cd921d518e.
    
    * convert all to v3
    
    * v3 to v2, add ListOperationByCluster example
    
    * linter feedback
    
    * more fix based on linter feedback
    
    * fix breaking change errors
    
    * continue fixing breaking change
    
    * User/vishalk/storage container (Azure#5953)
    
    * updated VHD object
    
    * updated storage container swagger
    
    * added available size property
    
    * updated description of path
    
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * Add canceled to provisioningState enum
    
    Co-authored-by: Arka <[email protected]>
    Co-authored-by: vishal-kadam <[email protected]>
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * cherry-pick merge conflict resolution
    
    * storage container changes (Azure#6614)
    
    * storage container changes
    
    * added availableSizeGB and containerSizeGB properties
    
    * changed data type of containersize and availablesize
    
    * converted gb to mb
    
    * made availableSizeMB and containerSizeMB fields readonly
    
    Co-authored-by: Vishal Kadam <[email protected]>
    
    * Change hybrididentitymetadata vmid to resourceUid (Azure#4921)
    
    * change hybrididentitymetadata vmid to resourceUid
    
    * update examples
    
    * fix missed merging changes
    
    * cherry-pick merge conflict resolution
    
    * remove 2022-09-01 examples
    
    * git difftool align differences with RPSaaSMaster
    
    * spellcheck fix
    
    * breaking change cross version fix
    
    * fix version
    
    * fix custom word typo
    
    * fix default tag to 2022-10
    
    * address description and example feedback
    
    * address swagger modelvalidation errors
    
    * missed linter and model validation error
    
    * prettier fix
    
    * fixing breaking change errors
    
    * backport common.json from 2021-07-01-preview
    
    * prettier on common.json
    
    * replace Idenitty from v2 definitions
    
    * fix property bag capitalization
    
    * Add missed capitalization modifications
    
    * Add missed semantic fix
    
    * Add missed semantic fix
    
    * revert property definition capitalization according to reviewer feedback
    
    Co-authored-by: Arka <[email protected]>
    Co-authored-by: vishal-kadam <[email protected]>
    Co-authored-by: Vishal Kadam <[email protected]>
    Co-authored-by: aeweston-msft <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants