Workspace Manager Assignments#21273
Closed
Closed
Conversation
|
Hi, @rheabansal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Generation Artifacts
|
Generated ApiView
|
rheabansal
added
the
DoNotMerge
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Oct 25, 2022
Closed
|
Hi, @rheabansal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Contributor
Author
|
Hi! This swagger was already approved in the private repo- https://github.com/Azure/azure-rest-api-specs-pr/pull/9116 |
zizw123
added
the
ARMSignedOff
openapi-workflow-bot
Bot
removed
the
WaitForARMFeedback
Signed off base on this |
|
Hi, @rheabansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @rheabansal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
Contributor
Author
|
Small change to update the Jobs model |
rheabansal
added
the
WaitForARMFeedback
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
|
Hi, @rheabansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @rheabansal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
Contributor
Author
|
Hi! If we could get a review on this PR when you get a chance that would be awesome! We have added 2 new properties & updated the examples accordingly. |
rkmanda
reviewed
Feb 16, 2023
rkmanda
reviewed
Feb 16, 2023
| "nextLinkName": "nextLink" | ||
| } | ||
| }, | ||
| "post": { |
Member
Contributor
Author
There was a problem hiding this comment.
Hi! Thanks for the review. Quick question, does this apply to ARM APIs only?
From my understanding a POST operation would happen at the collection level.
https://restfulapi.net/rest-put-vs-post/
Contributor
There was a problem hiding this comment.
POST actions in ARM can only be at resource provider scope or at an individual resources scope. https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/proxy-api-reference.md#resource-action-requests
Contributor
Author
There was a problem hiding this comment.
Thanks for the information. We currently have customers in preview using this POST API. In ARM Office hours yesterday, we spoke about how given it is being used this should be fine for now. Please let me know if this is not still the case :)
Thanks!
Contributor
There was a problem hiding this comment.
The manifest PR that introduced this type should have never been approved since the swagger PRs weren't reviewed. Unfortunately, it was and this API is already public so letting it stay as is to avoid breaking existing customers
rkmanda
reviewed
Feb 16, 2023
| @@ -0,0 +1,734 @@ | |||
| { | |||
| "swagger": "2.0", | |||
Member
There was a problem hiding this comment.
please address all the errors listed in the automated checks
Contributor
|
There are still open comments and lintdiff errors that need to be addressed |
11 tasks
11 tasks
|
Hi, @rheabansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @rheabansal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.