Skip to content

Fixes to 2022-03-08-preview for PostgreSQL flexible server #21234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crystal YU (chunyu3) merged 2 commits into from
Nov 1, 2022
Merged

Fixes to 2022-03-08-preview for PostgreSQL flexible server #21234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e84fac9
Add 202 response to server create and fix Sku definition
alanenriqueo Oct 22, 2022
473b65e
Add 202 response to examples
alanenriqueo Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...esource-manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@
"$ref": "#/definitions/Server"
}
},
"202": {
"description": "Accepted"
},

@TimLovellSmith Tim Lovell-Smith (TimLovellSmith) Oct 24, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create with PUT shouldn't return 202 Accepted. You're recommended to use provisioningState or async operation header instead in the RPC.

@TimLovellSmith Tim Lovell-Smith (TimLovellSmith) Oct 24, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creating-or-updating-resources-asynchronously

"default": {
"description": "Error response describing why the operation failed.",
"schema": {
Expand Down Expand Up @@ -538,7 +541,7 @@
"type": "object",
"properties": {
"sku": {
"$ref": "#/definitions/PostgreSqlSku",
"$ref": "#/definitions/Sku",
"description": "The SKU (pricing tier) of the server."
},
"identity": {
Expand Down Expand Up @@ -634,7 +637,7 @@
"type": "object",
"properties": {
"sku": {
"$ref": "#/definitions/PostgreSqlSku",
"$ref": "#/definitions/Sku",
"description": "The SKU (pricing tier) of the server."
},
"identity": {
Expand Down Expand Up @@ -673,7 +676,7 @@
},
"description": "A list of servers."
},
"PostgreSqlSku": {
"Sku": {
"type": "object",
"properties": {
"name": {
Expand Down