Dw/loadltest#21177
Closed
dw511214992 wants to merge 17 commits into
Closed
Conversation
…into loadtest_stableapis
|
Hi, @dw511214992 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| loadtestservice.json | 2022-11-01(6a2bca6) | 2022-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 5 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-11-01 | package-2022-11-01(6a2bca6) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AppComponentModel'. Consider using the plural form of 'AppComponent' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L15 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AppComponentModel'. Consider using the plural form of 'AppComponent' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L83 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AppComponentModel'. Consider using the plural form of 'AppComponent' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L130 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'AppComponentModel'. Consider using the plural form of 'AppComponent' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L182 |
||
| 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation. Location: Microsoft.LoadTestService/stable/2022-11-01/loadtestservice.json#L1575 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/6a2bca651b1259d3de2fbd0564e03a2f9f74008e/specification/loadtestservice/data-plane/readme.md#tag-package-2022-11-01">loadtestservice/data-plane/readme.md#package-2022-11-01
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
Member
Author
azure-sdk-for-pythonoutput-folder: sdk/loadtestservice/azure-developer-loadtesting
require:
- specification/loadtestservice/data-plane/readme.md |
Member
Author
azure-sdk-for-jsoutput-folder: sdk/loadtestservice/loadtestservice-rest
require:
- specification/loadtestservice/data-plane/readme.md |
Member
Author
azure-sdk-for-javaoutput-folder: sdk/loadtestservice/azure-developer-loadtesting
namespace: com.azure.developer.loadtesting
data-plane: true
require:
- specification/loadtestservice/data-plane/readme.md |
Member
Author
azure-sdk-for-net-track2output-folder: sdk/loadtestservice/Azure.Template.LoadTesting
require:
- specification/loadtestservice/data-plane/readme.md |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 19, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links