Skip to content

Conversation

@ruslany
Copy link
Contributor

@ruslany ruslany commented Sep 19, 2022

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ruslany Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 19, 2022

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️🔄ModelValidation inProgress [Detail]
    ️🔄SemanticValidation inProgress [Detail]
    ️🔄SDK Track2 Validation inProgress [Detail]
    ️🔄PrettierCheck inProgress [Detail]
    ️🔄SpellCheck inProgress [Detail]
    ️🔄CadlValidation inProgress [Detail]
    ️🔄PR Summary inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 19, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-java inProgress [Detail]
    ️🔄 azure-sdk-for-go inProgress [Detail]
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @ruslany
    Copy link
    Contributor Author

    ruslany commented Sep 19, 2022

    @leni-msft - all these changes are to bring the branch up to date with what is already in main. Please approve.

    @leniatgh leniatgh merged commit 20dc2c8 into Azure:Microsoft.App-2022-06-01-preview Sep 20, 2022
    leniatgh pushed a commit that referenced this pull request Sep 22, 2022
    * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add app diag to 2022-05-01 (#18678)
    
    * Add container apps diagnostics
    
    * Fix validation errors
    
    * Move Microsoft.App diag APIs to 2022-05-01
    
    * Fix validation errors
    
    * Fix validation errors
    
    * Fix validation errors 3
    
    * Change operationIds
    
    Co-authored-by: Michimune Kohno <mikono@microsoft.com>
    
    * Fix definition for customhostnameesult (#19014)
    
    * fix
    
    * update
    
    * more fix
    
    * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048)
    
    * Correct Probe enums (#18839)
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix patch example
    
    * Fix the casing of enums in the latest api version
    
    * Change the parameter names to unblock Terraform release (#19005)
    
    * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview
    
    * containerapps: fixing inconsistencies in the 2022-03-01 swagger
    
    * containerapps: updating the examples for 2022-01-01-preview
    
    * containerapps: updating the examples to account for the updated parameter names
    
    * containerapps: fixing linting
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix the policheck error
    
    * Revert "containerapps: fixing linting"
    
    This reverts commit 3c4872f.
    
    * Revert "containerapps: updating the examples for 2022-01-01-preview"
    
    This reverts commit 9b81fbd.
    
    * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"
    
    This reverts commit 553fc55.
    
    * Undo changes to 2022-01-01-preview
    
    * Fix one issue
    
    * fix remaining inconsistency
    
    * fix authConfig and sourceControl names
    
    Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
    Co-authored-by: Mike Vu <mikevu@microsoft.com>
    
    * Change param names
    
    * Fix examples
    
    * Fix CI errors
    
    Co-authored-by: Mike Vu <mikevu@microsoft.com>
    Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
    
    * Fix description in all API versions (#19313)
    
    * Fix description for ManagedEnvironment.Internal property (#19307)
    
    * Fix descriptions in all api versions
    
    * Add traffic info to revisions api (#19054)
    
    * Add traffic info to a revision api
    
    * Add deprecated prop
    
    * Prettier fixes
    
    * 1pdate based on new proposal
    
    * Rename
    
    * Change names
    
    * minor fix
    
    * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360)
    
    * Add httpReadBufferSize to dapr config
    
    * remove nullable
    
    * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add new resources for 2022-06-01-preview (#19494)
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974)
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment
    
    * Fix dapr ai connection string
    
    * remove read
    
    * remove read permission of dapr ai connection string and instrument key for managed environment
    
    * fixes for comments
    
    * update (#20013)
    
    * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133)
    
    * Fix casing for detector properties
    
    * Fix descriptions
    
    * Fix descriptions and detectorProperties in 2022-06-01-preview
    
    * Added `secretsStoreComponent` in 2022-06-01 spec (#20044)
    
    * Added `secretsStoreComponent` in 2022-06-01 spec
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Fixed typos and added example of name/key
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Add custom domain configuration for managed environment (#20149)
    
    Co-authored-by: Mengjun Qin <menqin@microsoft.com>
    
    * Add additional Dapr options (2022-06-01-preview) (#19886)
    
    * Add additional Dapr options
    
    * Update examples for 2022-06-01-preview
    
    * force ci
    
    * force ci
    
    * force ci
    
    * adding ip-restriction feat (#19841)
    
    * adding ip-restriction feat
    
    * remove from stable, add to preview
    
    * fix lintDiff error
    
    * fix modelvalidation error
    
    * fix formatting changes
    
    * rename names, add note to all allow or all deny
    
    * fix spell check error
    
    * update name and examples
    
    * rename `ipAddress` to `ipAddressRange`
    
    * making small change to re-run build pipeline
    
    * trigger GitHub actions
    
    * resolve comments
    
    Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
    
    * Remove Traffic Labels from revisions because they haven't been impelemented (#20261)
    
    * Revert "Add traffic info to revisions api (#19054)"
    
    This reverts commit 056cc51.
    
    * Remove traffic labels from revisions
    
    * Add property for tcp apps (#20193)
    
    * Add property for tcp apps
    
    * Add scale
    
    * Fix
    
    * Fix
    
    * Add Init Containers to common definitions (#19855)
    
    * add init containers to common definitions
    
    * move changes to 06-01 preview
    
    * remove repeated container definition
    
    * fix allof syntax
    
    * fix anonymous container definition
    
    * fix lintdiff errors
    
    * fix container allof syntax
    
    * add more init examples
    
    * split baseContainer definition
    
    * remove description
    
    Co-authored-by: p-bouchon <pbouchon@microsoft.com>
    
    * Update container app provisioningstate (#20411)
    
    * update
    
    * update
    
    * add property: maxInactiveRevisions (#20334)
    
    * add property: maxInactiveRevisions
    
    * update
    
    * update
    
    * Add premium sku related properties for managed environment (#19770)
    
    * Add premium sku related properties for managed environment
    
    * Move sku to base property
    
    * Add workloadProfileType
    
    * Examples for managed environment
    
    * Add container app example
    
    * Fix workloadProfiles
    
    * Add custom word
    
    * Fix WorkloadProfileType references
    
    * prettier fixes
    
    * Fix workload profile
    
    * Fix typo
    
    * remove readonly property for workload profile
    
    * Add object type
    
    * nit: Fix description location
    
    * Fix XmsIdentifierValidation
    
    * Remove spaces from enum values
    
    * Remove unwanted change
    
    * Add aka ms url
    
    * Update examples for workload profile type
    
    * Fix rebase issue
    
    * Fix json
    
    * Update description and move location
    
    * Remove provisioning state for node pool
    
    * sku capacity explanation
    
    * Remove capacity attribute
    
    * Remove capacity attribute from required
    
    * Mark sku property as required
    
    * Add x-ms-identifiers
    
    * Rename mimum and maximum
    
    * Rename skutype to skuName
    
    * Make sku property as optional
    
    * Make workload profile type as string
    
    * fix go SDK automation config
    
    Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
    
    * Fix source control status code in 2022-06-01-preview. (#20429)
    
    * Remove 20220501 because we will not support it in server side (#20427)
    
    * remove
    
    * update
    
    * Added support for user defined routing (#20464)
    
    * Added support for user defined routing
    
    * Added examples
    
    * fixed JSON syntax
    
    * syntax fix
    
    * fixed vnetenvironment syntax
    
    * fixed camel case
    
    * case fix
    
    * enum syntax
    
    * fixed comma cases ManagedEnvironmentOutBoundType
    
    * fixing casing
    
    * Some more APIs (#20448)
    
    * new APIs to 06-01
    
    * test fix
    
    * more fixes
    
    * add last active time for revision (#20658)
    
    * Add custom domain for connected env (#20731)
    
    * add custom domain
    
    * fhcekout
    
    * billingMeters - GET endpoint (#20485)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * add proxy resource properties
    
    * Response formatting
    
    * add default error response
    
    * ARM Review feedback + small naming change for a property
    
    * Change GB to GiB
    
    * Fix 2022-06-01-preview branch merge conflicts (#20773)
    
    * Reset
    
    * more fixes
    
    * More fixes
    
    * another conflict fix
    
    * Fix old preview version
    
    * fix 2022-03-01
    
    * supress lint
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
    Co-authored-by: michimune <michimune@outlook.com>
    Co-authored-by: Michimune Kohno <mikono@microsoft.com>
    Co-authored-by: Mike Vu <mikevu@microsoft.com>
    Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
    Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
    Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
    Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
    Co-authored-by: Mengjun Qin <767524684@qq.com>
    Co-authored-by: Mengjun Qin <menqin@microsoft.com>
    Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
    Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
    Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
    Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
    Co-authored-by: p-bouchon <pbouchon@microsoft.com>
    Co-authored-by: njucz <740360112@qq.com>
    Co-authored-by: JJ <jijohn@microsoft.com>
    Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
    Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
    Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
    Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
    Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
    leniatgh pushed a commit that referenced this pull request Sep 28, 2022
    * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add app diag to 2022-05-01 (#18678)
    
    * Add container apps diagnostics
    
    * Fix validation errors
    
    * Move Microsoft.App diag APIs to 2022-05-01
    
    * Fix validation errors
    
    * Fix validation errors
    
    * Fix validation errors 3
    
    * Change operationIds
    
    Co-authored-by: Michimune Kohno <mikono@microsoft.com>
    
    * Fix definition for customhostnameesult (#19014)
    
    * fix
    
    * update
    
    * more fix
    
    * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048)
    
    * Correct Probe enums (#18839)
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix patch example
    
    * Fix the casing of enums in the latest api version
    
    * Change the parameter names to unblock Terraform release (#19005)
    
    * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview
    
    * containerapps: fixing inconsistencies in the 2022-03-01 swagger
    
    * containerapps: updating the examples for 2022-01-01-preview
    
    * containerapps: updating the examples to account for the updated parameter names
    
    * containerapps: fixing linting
    
    * fix probe enums
    
    * Fix revision mode enum
    
    * Fix the policheck error
    
    * Revert "containerapps: fixing linting"
    
    This reverts commit 3c4872f.
    
    * Revert "containerapps: updating the examples for 2022-01-01-preview"
    
    This reverts commit 9b81fbd.
    
    * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"
    
    This reverts commit 553fc55.
    
    * Undo changes to 2022-01-01-preview
    
    * Fix one issue
    
    * fix remaining inconsistency
    
    * fix authConfig and sourceControl names
    
    Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
    Co-authored-by: Mike Vu <mikevu@microsoft.com>
    
    * Change param names
    
    * Fix examples
    
    * Fix CI errors
    
    Co-authored-by: Mike Vu <mikevu@microsoft.com>
    Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
    
    * Fix description in all API versions (#19313)
    
    * Fix description for ManagedEnvironment.Internal property (#19307)
    
    * Fix descriptions in all api versions
    
    * Add traffic info to revisions api (#19054)
    
    * Add traffic info to a revision api
    
    * Add deprecated prop
    
    * Prettier fixes
    
    * 1pdate based on new proposal
    
    * Rename
    
    * Change names
    
    * minor fix
    
    * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360)
    
    * Add httpReadBufferSize to dapr config
    
    * remove nullable
    
    * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Add new resources for 2022-06-01-preview (#19494)
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * update
    
    * update
    
    * fix
    
    * update
    
    * update
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974)
    
    * Enable Dapr AI Connection string for Microsoft.App connected environment
    
    * Fix dapr ai connection string
    
    * remove read
    
    * remove read permission of dapr ai connection string and instrument key for managed environment
    
    * fixes for comments
    
    * update (#20013)
    
    * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133)
    
    * Fix casing for detector properties
    
    * Fix descriptions
    
    * Fix descriptions and detectorProperties in 2022-06-01-preview
    
    * Added `secretsStoreComponent` in 2022-06-01 spec (#20044)
    
    * Added `secretsStoreComponent` in 2022-06-01 spec
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Fixed typos and added example of name/key
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    
    * Add custom domain configuration for managed environment (#20149)
    
    Co-authored-by: Mengjun Qin <menqin@microsoft.com>
    
    * Add additional Dapr options (2022-06-01-preview) (#19886)
    
    * Add additional Dapr options
    
    * Update examples for 2022-06-01-preview
    
    * force ci
    
    * force ci
    
    * force ci
    
    * adding ip-restriction feat (#19841)
    
    * adding ip-restriction feat
    
    * remove from stable, add to preview
    
    * fix lintDiff error
    
    * fix modelvalidation error
    
    * fix formatting changes
    
    * rename names, add note to all allow or all deny
    
    * fix spell check error
    
    * update name and examples
    
    * rename `ipAddress` to `ipAddressRange`
    
    * making small change to re-run build pipeline
    
    * trigger GitHub actions
    
    * resolve comments
    
    Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
    
    * Remove Traffic Labels from revisions because they haven't been impelemented (#20261)
    
    * Revert "Add traffic info to revisions api (#19054)"
    
    This reverts commit 056cc51.
    
    * Remove traffic labels from revisions
    
    * Add property for tcp apps (#20193)
    
    * Add property for tcp apps
    
    * Add scale
    
    * Fix
    
    * Fix
    
    * Add Init Containers to common definitions (#19855)
    
    * add init containers to common definitions
    
    * move changes to 06-01 preview
    
    * remove repeated container definition
    
    * fix allof syntax
    
    * fix anonymous container definition
    
    * fix lintdiff errors
    
    * fix container allof syntax
    
    * add more init examples
    
    * split baseContainer definition
    
    * remove description
    
    Co-authored-by: p-bouchon <pbouchon@microsoft.com>
    
    * Update container app provisioningstate (#20411)
    
    * update
    
    * update
    
    * add property: maxInactiveRevisions (#20334)
    
    * add property: maxInactiveRevisions
    
    * update
    
    * update
    
    * Add premium sku related properties for managed environment (#19770)
    
    * Add premium sku related properties for managed environment
    
    * Move sku to base property
    
    * Add workloadProfileType
    
    * Examples for managed environment
    
    * Add container app example
    
    * Fix workloadProfiles
    
    * Add custom word
    
    * Fix WorkloadProfileType references
    
    * prettier fixes
    
    * Fix workload profile
    
    * Fix typo
    
    * remove readonly property for workload profile
    
    * Add object type
    
    * nit: Fix description location
    
    * Fix XmsIdentifierValidation
    
    * Remove spaces from enum values
    
    * Remove unwanted change
    
    * Add aka ms url
    
    * Update examples for workload profile type
    
    * Fix rebase issue
    
    * Fix json
    
    * Update description and move location
    
    * Remove provisioning state for node pool
    
    * sku capacity explanation
    
    * Remove capacity attribute
    
    * Remove capacity attribute from required
    
    * Mark sku property as required
    
    * Add x-ms-identifiers
    
    * Rename mimum and maximum
    
    * Rename skutype to skuName
    
    * Make sku property as optional
    
    * Make workload profile type as string
    
    * fix go SDK automation config
    
    Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
    
    * Fix source control status code in 2022-06-01-preview. (#20429)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * Remove 20220501 because we will not support it in server side (#20427)
    
    * remove
    
    * update
    
    * add proxy resource properties
    
    * Response formatting
    
    * Added support for user defined routing (#20464)
    
    * Added support for user defined routing
    
    * Added examples
    
    * fixed JSON syntax
    
    * syntax fix
    
    * fixed vnetenvironment syntax
    
    * fixed camel case
    
    * case fix
    
    * enum syntax
    
    * fixed comma cases ManagedEnvironmentOutBoundType
    
    * fixing casing
    
    * add default error response
    
    * Add available workprofiles -GET endpoint
    
    * Remove duplicate schema name WorkloadProfile
    
    * Change memoryGiB to memoryGB as suggested in code review
    
    * Add x-ms-pageable - nextLink support to not introduce breaking changes in the future
    
    * rename to memory in GiB because our case is Gibibytes base 1024
    
    * change friendlyName to displayName
    
    * Some more APIs (#20448)
    
    * new APIs to 06-01
    
    * test fix
    
    * more fixes
    
    * Add new property to the response object
    
    * add last active time for revision (#20658)
    
    * Add custom domain for connected env (#20731)
    
    * add custom domain
    
    * fhcekout
    
    * billingMeters - GET endpoint (#20485)
    
    * Swagger documentation for /locations/{location}/billingMeters - GET endpoint
    
    * Add example, fix validation errors
    
    * Fix ARM validation errors, code review comments
    
    * Fix response validation
    
    * add proxy resource properties
    
    * Response formatting
    
    * add default error response
    
    * ARM Review feedback + small naming change for a property
    
    * Change GB to GiB
    
    * Change the boolean value for default to enum
    
    * change error response to v3/ErrorResponse
    
    * Fix 2022-06-01-preview branch merge conflicts (#20773)
    
    * Reset
    
    * more fixes
    
    * More fixes
    
    * another conflict fix
    
    * Fix old preview version
    
    * fix 2022-03-01
    
    Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
    Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
    Co-authored-by: michimune <michimune@outlook.com>
    Co-authored-by: Michimune Kohno <mikono@microsoft.com>
    Co-authored-by: Zunli Hu <zuh@microsoft.com>
    Co-authored-by: Mike Vu <mikevu@microsoft.com>
    Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
    Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
    Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
    Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
    Co-authored-by: Mengjun Qin <767524684@qq.com>
    Co-authored-by: Mengjun Qin <menqin@microsoft.com>
    Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
    Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
    Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
    Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
    Co-authored-by: p-bouchon <pbouchon@microsoft.com>
    Co-authored-by: njucz <740360112@qq.com>
    Co-authored-by: JJ <jijohn@microsoft.com>
    Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
    Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
    Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
    Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
    @ruslany ruslany deleted the fixmergeconflicts branch October 7, 2022 21:00
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants