[Monitor] Add Public Preview APIs of Metric Baseline#2049
[Monitor] Add Public Preview APIs of Metric Baseline#2049sergey-shandar merged 4 commits intoAzure:currentfrom asafst:features/asafst/add_metrics_baseline
Conversation
These APIs include: 1. Getting the pre-calculated baseline of a metric 2. Calculating the baseline of a metric given the metric values
sergey-shandar
added
the
WaitForARMFeedback
|
@simongdavies could you have a look? |
| } | ||
| }, | ||
| "paths": { | ||
| "/{resourceUri}/providers/microsoft.insights/baseline/{metricName}": { |
There was a problem hiding this comment.
Description should state/show examples of resourceUri
There was a problem hiding this comment.
Added the description to the ResourceUriParameter parameter part.
| "BaselineResponse": { | ||
| "type": "object", | ||
| "properties": { | ||
| "id": { |
There was a problem hiding this comment.
id, name and type properties should be marked as readonly: true
| "$ref": "#/definitions/BaselineProperties", | ||
| "description": "the properties of the baseline." | ||
| }, | ||
| "timestamps": { |
There was a problem hiding this comment.
timestamps, baseline, metadata should be under properties envelope.
There was a problem hiding this comment.
Moved them to properties
| "Baseline": { | ||
| "type": "object", | ||
| "properties": { | ||
| "sensitivity": { |
There was a problem hiding this comment.
You're right, changed to enum
| }, | ||
| "BaselineProperties": { | ||
| "properties": { | ||
| "timespan": { |
There was a problem hiding this comment.
It should be an ISO 8601 time interval (see: https://en.wikipedia.org/wiki/ISO_8601#Time_intervals). The format is "{date-time}/{date-time}". So string is probably more appropriate here.
I tried to be consistent with the definitions and types in the metrics_API.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
ravbhatnagar
added
ARMSignedOff
|
Looks good. |
|
No modification for AutorestCI/azure-sdk-for-ruby |
5 participants
These APIs include:
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger