Skip to content

AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT #20407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FumingZhang merged 3 commits into from
Aug 29, 2022
Merged

AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT #20407

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71475a0
AKS agent pool properties add AgentPoolWindowsProfile and DisableOutb…
ShiqianTao Aug 26, 2022
4baa21d
Change disableOutboundNAT to disableOutboundNat because of ARM format…
ShiqianTao Aug 26, 2022
88bcd43
Improve description
ShiqianTao Aug 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions ...rvice/preview/2022-08-02-preview/examples/AgentPoolsCreate_WindowsDisableOutboundNAT.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
{
"parameters": {
"api-version": "2022-08-02-preview",
"subscriptionId": "subid1",
"resourceGroupName": "rg1",
"resourceName": "clustername1",
"agentPoolName": "wnp2",
"parameters": {
"properties": {
"orchestratorVersion": "1.23.8",
"count": 3,
"vmSize": "Standard_D4s_v3",
"osType": "Windows",
"osSKU": "Windows2022",
"windowsProfile": {
"disableOutboundNat": true
}
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/subid1/resourcegroups/rg1/providers/Microsoft.ContainerService/managedClusters/clustername1/agentPools/wnp2",
"type": "Microsoft.ContainerService/managedClusters/agentPools",
"name": "wnp2",
"properties": {
"provisioningState": "Succeeded",
"orchestratorVersion": "1.23.8",
"currentOrchestratorVersion": "1.23.8",
"count": 3,
"vmSize": "Standard_D4s_v3",
"maxPods": 110,
"osType": "Windows",
"osSKU": "Windows2022",
"windowsProfile": {
"disableOutboundNat": true
}
}
}
},
"201": {
"body": {
"id": "/subscriptions/subid1/resourcegroups/rg1/providers/Microsoft.ContainerService/managedClusters/clustername1/agentPools/wnp2",
"type": "Microsoft.ContainerService/managedClusters/agentPools",
"name": "wnp2",
"properties": {
"provisioningState": "Creating",
"orchestratorVersion": "1.23.8",
"currentOrchestratorVersion": "1.23.8",
"count": 3,
"vmSize": "Standard_D4s_v3",
"maxPods": 110,
"osType": "Windows",
"osSKU": "Windows2022",
"windowsProfile": {
"disableOutboundNat": true
}
}
}
}
}
}
18 changes: 18 additions & 0 deletions ...source-manager/Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,6 +1112,9 @@
"Create Agent Pool with Windows OSSKU": {
"$ref": "./examples/AgentPoolsCreate_WindowsOSSKU.json"
},
"Create Windows Agent Pool with disabling OutboundNAT": {
"$ref": "./examples/AgentPoolsCreate_WindowsDisableOutboundNAT.json"
},
"Create Agent Pool with GPUMIG": {
"$ref": "./examples/AgentPoolsCreate_GPUMIG.json"
},
Expand Down Expand Up @@ -3483,6 +3486,10 @@
},
"title": "The fully qualified resource ID of the Dedicated Host Group to provision virtual machines from, used only in creation scenario and not allowed to changed once set.",
"description": "This is of the form: /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/hostGroups/{hostGroupName}. For more information see [Azure dedicated hosts](https://docs.microsoft.com/azure/virtual-machines/dedicated-hosts)."
},
"windowsProfile": {
"$ref": "#/definitions/AgentPoolWindowsProfile",
"description": "The Windows agent pool's specific profile."
}
},
"description": "Properties for the container service agent pool profile."
Expand Down Expand Up @@ -5781,6 +5788,17 @@
}
}
},
"AgentPoolWindowsProfile": {
"type": "object",
"description": "The Windows agent pool's specific profile.",
"properties": {
"disableOutboundNat": {
Comment thread
ShiqianTao marked this conversation as resolved.
Outdated
"type": "boolean",
"title": "Whether to disable OutboundNAT in windows nodes",
"description": "The default value is false. Allow disabling OutboundNAT only if the cluster outbound type is NAT Gateway and the Windows agent pool doesn't have node public IP enabled."

@matthchr matthchr Aug 26, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Phrasing.

Change this to: ""Outbound NAT can only be disabled if the cluster outboundType is NAT Gateway and the Windows agent pool does not have node public IP enabled."

}
}
},
"SysctlConfig": {
"description": "Sysctl settings for Linux agent nodes.",
"type": "object",
Expand Down