Maulik/mfe stable changes#20373
Closed
Maulik003 wants to merge 110 commits into
Closed
Conversation
* Updating Microsoft.Security\Pricing API Documentation * Adding items property to replacedBy
…eration ID Prefix (Azure#20106) This means that when grouped these are grouped by Type (Certificate, IotDpsResource) rather than by GET/PUT/PATCH etc which is less useful.
Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <v-zhenbwei@microsoft.com>
…gh shift left (Azure#20122) Co-authored-by: swagger-automation <swagger@microsoft.com>
…properties in data encryption (Azure#19910) * fix name error * fix example * fix example * fix properties error
* Add more scopes * update documentation * fix some wording * wording * fix artifact name * fix comment * fix title * rename files
* Adds base for updating Microsoft.Sql from version preview/2021-11-01-preview to version 2021-11-01 * Updates readme * Updates API version in new specs and examples * add the latest generated stable 2021-11-01 * update readme.md with latest stable api list * update swaggers * update swagger format * address lintdiff pipeline * address lint error * add "x-ms-identifiers": []
* Adds base for updating Microsoft.BotService from version preview/2021-05-01-preview to version 2022-06-15-preview * Updates readme * Updates API version in new specs and examples * add email related and outlook * Update readme * Correct some elements * fix model issue * Fix prettier issues. * add QnAMakerEndpointKeys api * fix the prettierCheck Co-authored-by: hualxie <xieofxie@126.com> Co-authored-by: Chang Liu <liuchang@microsoft.com> Co-authored-by: Hongyang Du <hond@microsoft.com>
* Fix error response schema for the ListCustomHostNameAnalysis API * Wrong place
* Full copy from 2021-09-01 to 2022-05-01 without any changes * Updating API version for Service types, Updating readme files * Feature: add directoryServiceOptions AADKERB * Add AADKERB to list of custom words * Fix default version tag in readme.md * Make encryption keySource optional * Fix lint: add missing x-ms-enum * Fix x-ms-enum at wrong level * Make some activeDirectoryProperties optional * Update readme.python.md Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
* Adds base for updating Microsoft.Peering from version stable/2022-01-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * Updated Peering API version 2022-06-01 * Fixed slight issue with Peering readme * Updated resource path for POST ValidateRegisteredPrefix Co-authored-by: jsaraco <jsaraco@microsoft.com>
…2-09-01-preview (Azure#19889) * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Add swagger doc with version '2022-09-01-preview' for styling service * update sharedKey description * resolve some comments and couple validation errors * Fix more model issues * Fix more model validations * Fix LintDiff * Fix validation errors * Fix lintDiff
…ble/2022-08-01 (Azure#19891) * Adds base for updating Microsoft.Media from version stable/2021-11-01 to version 2022-08-01 * Updates readme * Updates API version in new specs and examples * remove unrelated changes * delete unrelated examples * make changes to 2022-08-01 streamingservice * fix comments Co-authored-by: Stephanie Han <minhan@microsoft.com>
…zure#20157) * change the name of a new enumeration * revert changes in python readme * add directive to mitigate go sdk breaking change Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
…review/2022-04-30-preview (Azure#18743) * Adds base for updating Microsoft.Devices from version preview/2021-07-02-preview to version 2022-04-30-preview * Updates readme * Updates API version in new specs and examples * Add RoutingCosmosDBCollectionProperties to iothub.json. * Update naming. * Fix enum. * Unique x-ms-enum names. * Use same name for same enum def. * Revert "Use same name for same enum def." This reverts commit 6279e70. * Use same name for enum. * Revert "Use same name for enum." This reverts commit 366c4b3. * Adds suppression to readme * Revert "Revert "Use same name for enum."" This reverts commit 15b8dc9. * Update reason on UniqueXmsEnumName suppression. * Ensure camel casing on partitionKeyName and partitionKeyTemplate. * Add 'deviceid' to custom-words.txt. * Add x-ms-secret. * Remove secret tag for storage endpoint connection string. * Adding the change for rootCertificateV2 * typo * fixing validation error * Update error response schema * fixing tag * adding Azure-AsyncOperation as header * fix: adding Azure-AsyncOperation as header * Fix semantic error * header fix * adding x-ms-identifiers * fix * fix * prettier fix * Azure-Async header position testing * re-trigger stuck queue validation jobs * revert change * testing Azure AsyncOperation header * Adding Azure-AsyncOperation to other possible place to mitigate the error * make small change to retrigger the check queue * Adding Async Operation header to the examples. * fix format * Typo fix * revert the change of error details schema * Revert unwanted changes Co-authored-by: Jared Wilson <jaredwilson@microsoft.com> Co-authored-by: Chris Huang <huangc@microsoft.com>
Updating the CODEOWNERS for Cosmos related PRs on request of Cosmos team.
* Adds base for updating Microsoft.SecurityInsights from version preview/2022-07-01-preview to version 2022-08-01-preview * Updates readme * Updates API version in new specs and examples * Added file imports (Azure#19678) * added file imports * . * . * version * fix delete response (Azure#20154) * fix delete response * example fix Co-authored-by: Moran Raz Mizrahi <morazmiz@microsoft.com> Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com> Co-authored-by: Moran Raz Mizrahi <morazmiz@microsoft.com>
Customize secretmanagementtestsvc pr assignment.
… configuration (Azure#20187) Co-authored-by: swagger-automation <swagger@microsoft.com>
* Adds base for updating Microsoft.LabServices from version preview/2021-11-15-preview to version 2022-08-01 * Updates readme * Updates API version in new specs and examples * refactor: update the v2022-08-01 specifications * Fix prettier issues * Add missing clouderror.json file * Add missing xmsidentifier clouderror property * Add x-ms-identifiers to Skus.json file * Resolve code style issues in clouderror.json * Add clouderror to custom-words.txt * Use ErrorResponse instead of CloudError * Fix duration format in examples * Fix duration format in Users examples * Fix duration format in LabPlans examples
* patch now 3 * patch now 4 * patch now 5 * test encoding * test encoding * doc abs req * text sum * conv * example * BOM * revert * add timing * add missing parent * custom api * more descriptions * add more required fields * add custom task and result * add more description to summary controls * fix base class bug, add lab features, ext phrase c * add CustomAbstractiveSummarizationLROResults * add examples * auth example * remove dup * require storage * remove invalid example, rename item id * fix example * add more description * fix invalid char in example, unify enum value * remove customization * fix example * revert ext sum, denorm conv * fix typo * 10 * spec * revert * remove lab features, rename timing, narrative * fix examples * merge upstream * Revert "merge upstream" This reverts commit 07fc9c6. * fetch upstream * common ver * get 07-01 back to readme * revert changes to extractive summarization * prettier * add word Co-authored-by: Yuantao Wang <yuantw@microsoft.com>
This was referenced Aug 31, 2022
Closed
Draft
Closed
Closed
Member
|
Seems like this PR is created in correctly can you please abandon and recreate ? |
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
Bot
removed
the
WaitForARMFeedback
openapi-pipeline-app
Bot
added
the
WaitForARMFeedback
This was referenced Aug 31, 2022
Closed
This was referenced Aug 31, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.