Closed
Conversation
|
Hi, @Sandido Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| communityGallery.json | 2022-03-03(a6fe515) | 2022-01-03(main) |
| gallery.json | 2022-03-03(a6fe515) | 2022-01-03(main) |
| gallery.json | 2022-03-03(a6fe515) | 2020-09-30(main) |
| galleryRPCommon.json | 2022-03-03(a6fe515) | 2022-01-03(main) |
| sharedGallery.json | 2022-03-03(a6fe515) | 2022-01-03(main) |
| sharedGallery.json | 2022-03-03(a6fe515) | 2020-09-30(main) |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a client parameter that was found in the old version. Was 'LocationNameParamter' removed or renamed? New: azure-rest-api-specs/blob/a6fe5157462511b9ccfa01638057e903f4c872a2/revision#L1024:2 Old: GalleryRP/preview/2020-09-30/sharedGallery.json#L762:3 |
|
| The new version has a different type 'object' than the previous one ''. New: galleryRP/stable/2022-03-03/gallery.json#L2491:9 Old: GalleryRP/preview/2020-09-30/gallery.json#L2358:9 |
|
| The new version has a different type 'object' than the previous one ''. New: galleryRP/stable/2022-03-03/gallery.json#L2507:5 Old: GalleryRP/preview/2020-09-30/gallery.json#L2371:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 3 Errors, 0 Warnings failed [Detail]
The following errors/warnings are introduced by current PR:
| Rule | Message |
|---|---|
|
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-03-03", "details":"swagger-document-override/md-override-loader - FAILED" |
|
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-03-03", "details":"Error: Could not read 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/compute/resource-manager/Microsoft.Compute/GalleryRP/stable/2022-03-03/galleryRPCommon.json'." |
|
"location":"specification/compute/resource-manager/readme.md", "tag":"package-2022-03-03", "details":"swagger-document/loader - FAILED" |
️❌Avocado: 65 Errors, 1 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/a6fe5157462511b9ccfa01638057e903f4c872a2/specification/compute/resource-manager/readme.md#tag-package-2022-03-03">compute/resource-manager/readme.md#package-2022-03-03
- "https://github.com/Azure/azure-rest-api-specs/blob/a6fe5157462511b9ccfa01638057e903f4c872a2/specification/compute/resource-manager/readme.md#tag-package-2022-03-03-only">compute/resource-manager/readme.md#package-2022-03-03-only
️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: Microsoft.Compute/common-types/v1/common.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @Sandido your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Hi @Sandido, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The contents of this release were reviewed in this previous PR: #19644
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.