[ServiceFabricMesh] Fixed case sensitive enum that caused schema gen to fail by jorgecotillo · Pull Request #20168 · Azure/azure-rest-api-specs

jorgecotillo · 2022-08-10T15:02:07Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify - Schema generation failed due to invalid casing on enum.
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-08-10T15:02:11Z

Hi, @jorgecotillo Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-08-10T15:02:12Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.9.6)]	new version	base version
servicefabricmesh.json	2018-09-01-preview(a34fc84)	2018-09-01-preview(main)

Rule	Message
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'inlinedValue' from the old version. Old: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L79:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'inlinedValue' from the old version. New: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:5 Old: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:5
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'inlinedValue' from the old version. New: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2070:9 Old: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2070:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'inlinedValue' from the old version. New: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2070:9 Old: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2070:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2018-09-01-preview	package-2018-09-01-preview(a34fc84)	package-2018-09-01-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R3021 - PathResourceTypeNameCamelCase	Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceFabricMesh/secrets/{secretResourceName}/values/{secretValueResourceName}/list_value' Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L497
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2614
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2761
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3044
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3048
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3052
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3324
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3349
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3421
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3559
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3679
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L3945
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ServiceFabricMesh/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L37
`❌` R4037 - MissingTypeObject	The schema 'AvailableOperationDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1781
`❌` R4037 - MissingTypeObject	The schema 'ErrorModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1802
`❌` R4037 - MissingTypeObject	The schema 'ErrorErrorModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1814
`❌` R4037 - MissingTypeObject	The schema 'ErrorDetailsModel' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1839
`❌` R4037 - MissingTypeObject	The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1855
`❌` R4037 - MissingTypeObject	The schema 'OperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1872
`❌` R4037 - MissingTypeObject	The schema 'ProvisionedResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1893
`❌` R4037 - MissingTypeObject	The schema 'ManagedProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1911
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1942
`❌` R4037 - MissingTypeObject	The schema 'TrackedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1972
`❌` R4037 - MissingTypeObject	The schema 'SecretResourceDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2079
`❌` R4037 - MissingTypeObject	The schema 'SecretValueResourceDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2144
`❌` R4037 - MissingTypeObject	The schema 'VolumeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2179
`❌` R4037 - MissingTypeObject	The schema 'VolumeProviderParametersAzureFile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2226
`❌` R4037 - MissingTypeObject	The schema 'ApplicationScopedVolume' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2269
`❌` R4037 - MissingTypeObject	The schema 'ApplicationScopedVolumeCreationParametersServiceFabricVolumeDisk' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2304
`❌` R4037 - MissingTypeObject	The schema 'VolumeResourceDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2359

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 8 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L38:14
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: inlinedValue Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:19 ExampleUrl: 2018-09-01-preview/examples/secrets/create_update.json#L9:34
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: inlinedValue Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:19 ExampleUrl: 2018-09-01-preview/examples/secrets/create_update.json#L29:19
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: inlinedValue Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:19 ExampleUrl: 2018-09-01-preview/examples/secrets/create_update.json#L45:19
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: inlinedValue Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:19 ExampleUrl: 2018-09-01-preview/examples/secrets/get.json#L20:19
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: inlinedValue Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:19 ExampleUrl: 2018-09-01-preview/examples/secrets/list_byResourceGroup.json#L21:23
`❌` ENUM_CASE_MISMATCH	Enum does not match case for: inlinedValue Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2005:19 ExampleUrl: 2018-09-01-preview/examples/secrets/list_bySubscriptionId.json#L20:23
`❌` READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST	ReadOnly property "name" cannot be sent in the request Url: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L1953:17 ExampleUrl: examples/secrets/values/create.json#L10:39

️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` INVALID_XMS_DISCRIMINATOR_VALUE	The value of x-ms-dicriminator-value is not in the discriminator enum list: inlinedValue JsonUrl: Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#L2051:45

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/a34fc8484992862a58daa42bd0698ebc97393213/specification/servicefabricmesh/resource-manager/readme.md#tag-package-2018-09-01-preview">servicefabricmesh/resource-manager/readme.md#package-2018-09-01-preview

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ Modeler/MissingType	"readme":"servicefabricmesh/resource-manager/readme.md", "tag":"package-2018-09-01-preview", "details":"The schema 'AzureInternalMonitoringPipelineSinkDescription-fluentdConfigUrl' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/servicefabricmesh/resource-manager/Microsoft.ServiceFabricMesh/preview/2018-09-01-preview/servicefabricmesh.json#/components/schemas/AzureInternalMonitoringPipelineSinkDescription-fluentdConfigUrl"

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmesh/resource-manager/readme.md", "tag":"package-2018-09-01-preview", "details":"Schema 'AddRemoveReplicaScalingMechanism' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmesh/resource-manager/readme.md", "tag":"package-2018-09-01-preview", "details":"Schema 'AutoScalingResourceMetric' has an allOf list with an empty object schema as a parent, removing it."
⚠️ PreCheck/EmptyParentSchemaWarning	"readme":"servicefabricmesh/resource-manager/readme.md", "tag":"package-2018-09-01-preview", "details":"Schema 'AverageLoadScalingTrigger' has an allOf list with an empty object schema as a parent, removing it."
⚠️ UnkownSecurityScheme	"readme":"servicefabricmesh/resource-manager/readme.md", "tag":"package-2018-09-01-preview", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-08-10T15:02:13Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/servicefabricmesh/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️❌ azure-sdk-for-python failed [Detail]

❌Failed [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
cmdout	[automation_generate.sh] [Autorest]  > You can install the newer version with with npm install -g autorest@latest
cmdout	[automation_generate.sh] [Autorest]
cmdout	[automation_generate.sh] [Autorest] SourceMapConsumer.initialize is a no-op when running in node.js
cmdout	[automation_generate.sh] [Autorest] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@autorestcore@3.7.2/nodemodules/@autorest/core/dist' (3.7.2)
cmdout	[automation_generate.sh] [Autorest] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future.
cmdout	[automation_generate.sh] [Autorest] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future.
cmdout	[automation_generate.sh] [Autorest] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future.
cmdout	[automation_generate.sh] [Autorest]   File "/home/cloudtest/.autorest/@autorestpython@5.16.0/node_modules/@autorest/python/autorest/codegen/__init__.py", line 439, in _build_code_modeloptions
cmdout	[automation_generate.sh] [Autorest]     validate_code_modeloptions(options)
cmdout	[automation_generate.sh] [Autorest]   File "/home/cloudtest/.autorest/@autorestpython@5.16.0/node_modules/@autorest/python/autorest/codegen/__init__.py", line 83, in _validate_code_modeloptions
cmdout	[automation_generate.sh] [Autorest]     raise ValueError("--basic-setup-py must be used with --package-version")
cmdout	[automation_generate.sh] [Autorest] ValueError: --basic-setup-py must be used with --package-version
cmdout	[automation_generate.sh] [Autorest] fatal   | Process() cancelled due to failure
cmdout	[automation_generate.sh] [Autorest] error   |   Error: Plugin codegen reported failure.
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-servicefabricmesh [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armservicefabricmesh [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-servicefabricmesh [View full logs] [Preview SDK Changes]
- azure-arm-servicefabricmesh-3.0.0-beta.4.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️servicefabricmesh [View full logs] [Preview Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 88e73587292ae006bef7f6c4c230eb92a9d938da. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.ServiceFabricMesh [View full logs] [Preview SDK Changes]
- Az.ServiceFabricMesh.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-08-10T15:02:13Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-resourcemanager-servicefabricmesh	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-servicefabricmesh	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

jorgecotillo · 2022-08-10T15:03:03Z

@o0rubinx0o this PR: #19634 introduced an invalid casing on "enum" that caused ARM Schema generation to fail. This PR fixes it.

openapi-workflow-bot · 2022-08-10T15:05:02Z

Hi @jorgecotillo, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-08-10T15:05:31Z

Hi @jorgecotillo, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

jordan13game · 2022-08-16T02:32:18Z

Hi, @jorgecotillo you need fix CI failures about inlinedValue

ghost · 2022-09-04T16:04:13Z

Hi, @jorgecotillo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-09-25T16:04:44Z

Hi, @jorgecotillo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-10-16T16:05:06Z

Hi, @jorgecotillo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-10-31T05:04:10Z

Hi, @jorgecotillo. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

fixed case sensitive enum that caused schema gen to fail

a34fc84

openapi-assignment-bot bot assigned msyyc Aug 10, 2022

jorgecotillo assigned o0rubinx0o and unassigned msyyc Aug 10, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Aug 10, 2022

openapi-pipeline-app bot added resource-manager BreakingChangeReviewRequired labels Aug 10, 2022

jorgecotillo assigned jordan13game Aug 10, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 15, 2022

ghost added no-recent-activity and removed no-recent-activity labels Sep 4, 2022

ghost added the no-recent-activity label Sep 25, 2022

AzureRestAPISpecReview removed the BreakingChangeReviewRequired label Sep 28, 2022

ghost removed the no-recent-activity label Sep 28, 2022

ghost added the no-recent-activity label Oct 16, 2022

ghost closed this Oct 31, 2022

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ServiceFabricMesh] Fixed case sensitive enum that caused schema gen to fail#20168

[ServiceFabricMesh] Fixed case sensitive enum that caused schema gen to fail#20168
jorgecotillo wants to merge 1 commit intomainfrom
jcotillo/fix_servicefabmesh_enum

jorgecotillo commented Aug 10, 2022

Uh oh!

openapi-workflow-bot bot commented Aug 10, 2022

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2022 •

edited

Loading

Uh oh!

jorgecotillo commented Aug 10, 2022

Uh oh!

openapi-workflow-bot bot commented Aug 10, 2022

Uh oh!

openapi-workflow-bot bot commented Aug 10, 2022

Uh oh!

jordan13game commented Aug 16, 2022

Uh oh!

ghost commented Sep 4, 2022

Uh oh!

ghost commented Sep 25, 2022

Uh oh!

ghost commented Oct 16, 2022

Uh oh!

ghost commented Oct 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jorgecotillo commented Aug 10, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Aug 10, 2022

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

jorgecotillo commented Aug 10, 2022

Uh oh!

openapi-workflow-bot bot commented Aug 10, 2022

Uh oh!

openapi-workflow-bot bot commented Aug 10, 2022

Uh oh!

jordan13game commented Aug 16, 2022

Uh oh!

ghost commented Sep 4, 2022

Uh oh!

ghost commented Sep 25, 2022

Uh oh!

ghost commented Oct 16, 2022

Uh oh!

ghost commented Oct 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-pipeline-app bot commented Aug 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Aug 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Aug 10, 2022 •

edited

Loading