ManagedDatabases 2022-05-01-preview update: ManagedDatabaseStatus#20114
ManagedDatabases 2022-05-01-preview update: ManagedDatabaseStatus#20114xiaoxuqi-ms merged 5 commits intoAzure:dev-sql-Microsoft.Sql-2022-05-01-previewfrom djordje-jeremic:dev/djjeremi/ManagedDatabases-2022-05-01-preview
Conversation
|
Hi, @djordje-jeremic Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| ManagedDatabases.json | 2022-05-01-preview(5cae3af) | 2021-11-01(main) |
| ManagedDatabases.json | 2022-05-01-preview(5cae3af) | 2022-02-01-preview(main) |
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-05 | package-preview-2022-05(5cae3af) | package-preview-2022-05(dev-sql-Microsoft.Sql-2022-05-01-preview) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| The response of operation:'ManagedDatabases_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-05-01-preview/ManagedDatabases.json#L62 |
|
| The response of operation:'ManagedDatabases_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-05-01-preview/ManagedDatabases.json#L102 |
|
| The response of operation:'ManagedDatabases_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Sql/preview/2022-05-01-preview/ManagedDatabases.json#L226 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/5cae3afe91efc99c6219d3807a6608492b77a683/specification/sql/resource-manager/readme.md#tag-package-preview-2022-05">sql/resource-manager/readme.md#package-preview-2022-05
| Rule | Message |
|---|---|
DuplicateOperation |
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentBaselines' > 'CreateOrUpdate' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - put /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName\n - put /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName" |
DuplicateOperation |
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentRuleBaselines' > 'Delete' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId" |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Duplicate object schemas with 'SecurityAlertPolicyName' name detected." |
|
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2022-05", "details":"Error: 3 errors occured -- cannot continue." |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
Hi, @djordje-jeremic your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Generated ApiView
|
|
It might not be obvious from the diff, but the only intended change is in lines 623-625, the enum being extended by adding two new values 'DbMoving' and 'DbCopying. Matching ARM PR: https://msdata.visualstudio.com/Database%20Systems/_git/DsMainDev/pullrequest/859807 |
|
@jamestao, @ericshape Friendly ping for this and the matching REST API PR https://msdata.visualstudio.com/Database%20Systems/_git/DsMainDev/pullrequest/859807 |
| @@ -176,6 +173,9 @@ | |||
| }, | |||
| "Creates a new managed database from restoring a long term retention backup": { | |||
| "$ref": "./examples/ManagedDatabaseCreateRestoreLtrBackup.json" | |||
| }, | |||
There was a problem hiding this comment.
it is fine to reorder the example reference with Line 165
Thanks @ericshape, would you mind taking a look at the corresponding ARM PR as well? (https://msdata.visualstudio.com/Database%20Systems/_git/DsMainDev/pullrequest/859807) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @djordje-jeremic, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
NewApiVersionRequired reason: |
|
Hi @djordje-jeremic, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This reverts commit e3d4879.
|
@ericshape, @jamestao I attempted to add additional Swaggers with the same enum change for API versions < 20220501 but the number of validation errors for a few of them was enormous, so I reverted it for the time being. There was no change in already approved Swagger for 20220501. I'm unsure if we should (must?) update previous Swaggers, due to the number of valid statuses being extended by 2 ('DbMoving' and 'DbCopying') in all previous API revisions after addressing your feedbacks in the ARM PR (do enum changes in 'VCommon' version of ArmManagedDatabaseStatus.cs rather than introducing a new ArmManagedDatabaseStatus.cs in '20220501'). |
|
@jamestao, @ericshape , @raosuhas , @xiaoxuqi-ms Ping for final signoff and merge! |
|
@jamestao, @ericshape , @raosuhas , @xiaoxuqi-ms Ping for merge, if there's no outstanding blockers. |
|
@xiaoxuqi-ms can you help to review and merge this PR to the dev branch? Thanks! SDK failed pipelines are expected. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
August 2022
August 2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.