Skip to content

Adding VMAgentVersioning property #20097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grizzlytheodore merged 4 commits into from
Aug 31, 2022
Merged

Adding VMAgentVersioning property #20097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83d2317
other files
kamusta-msft Aug 3, 2022
0cd26cc
adding protectedSettingsFromKeyVault fix
kamusta-msft Aug 3, 2022
aa27f05
PR comments
kamusta-msft Aug 17, 2022
5c07448
missing files
kamusta-msft Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...mpute/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/computeRPCommon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,6 +1264,10 @@
"winRM": {
"$ref": "#/definitions/WinRMConfiguration",
"description": "Specifies the Windows Remote Management listeners. This enables remote Windows PowerShell."
},
"enableVMAgentPlatformUpdates": {
"type": "boolean",
"description": "Indicates whether VMAgent Platform Updates is enabled for the Windows virtual machine. Default value is false."
}
},
"description": "Specifies Windows operating system settings on the virtual machine."
Expand Down Expand Up @@ -1313,6 +1317,10 @@
"patchSettings": {
"$ref": "#/definitions/LinuxPatchSettings",
"description": "[Preview Feature] Specifies settings related to VM Guest Patching on Linux."
},
"enableVMAgentPlatformUpdates": {
"type": "boolean",
"description": "Indicates whether VMAgent Platform Updates is enabled for the Linux virtual machine. Default value is false."
}
},
"description": "Specifies the Linux operating system settings on the virtual machine. <br><br>For a list of supported Linux distributions, see [Linux on Azure-Endorsed Distributions](https://docs.microsoft.com/azure/virtual-machines/linux/endorsed-distros)."
Expand Down
14 changes: 12 additions & 2 deletions ...le/2022-08-01/examples/virtualMachineExamples/VirtualMachines_ListAll_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,12 @@
]
},
"suppressFailures": true,
"protectedSettingsFromKeyVault": {}
"protectedSettingsFromKeyVault": {
"sourceVault": {
"id": "/subscriptions/a53f7094-a16c-47af-abe4-b05c05d0d79a/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/kvName"
},
"secretUrl": "https://kvName.vault.azure.net/secrets/secretName/79b88b3a6f5440ffb2e73e44a0db712e"
}
},
"id": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
"name": "aaaaaaaaaaaaa",
Expand Down Expand Up @@ -1065,7 +1070,12 @@
]
},
"suppressFailures": true,
"protectedSettingsFromKeyVault": {}
"protectedSettingsFromKeyVault": {
"sourceVault": {
"id": "/subscriptions/a53f7094-a16c-47af-abe4-b05c05d0d79a/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/kvName"
},
"secretUrl": "https://kvName.vault.azure.net/secrets/secretName/79b88b3a6f5440ffb2e73e44a0db712e"
}
},
"id": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
"name": "aaaaaaaaaaaaa",
Expand Down
14 changes: 12 additions & 2 deletions ...table/2022-08-01/examples/virtualMachineExamples/VirtualMachines_List_MaximumSet_Gen.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,12 @@
]
},
"suppressFailures": true,
"protectedSettingsFromKeyVault": {}
"protectedSettingsFromKeyVault": {
"sourceVault": {
"id": "/subscriptions/a53f7094-a16c-47af-abe4-b05c05d0d79a/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/kvName"
},
"secretUrl": "https://kvName.vault.azure.net/secrets/secretName/79b88b3a6f5440ffb2e73e44a0db712e"
}
},
"id": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
"name": "aaaaaaaaaaaaa",
Expand Down Expand Up @@ -1065,7 +1070,12 @@
]
},
"suppressFailures": true,
"protectedSettingsFromKeyVault": {}
"protectedSettingsFromKeyVault": {
"sourceVault": {
"id": "/subscriptions/a53f7094-a16c-47af-abe4-b05c05d0d79a/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/kvName"
},
"secretUrl": "https://kvName.vault.azure.net/secrets/secretName/79b88b3a6f5440ffb2e73e44a0db712e"
}
},
"id": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
"name": "aaaaaaaaaaaaa",
Expand Down
4 changes: 2 additions & 2 deletions ...ompute/resource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/virtualMachine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1953,7 +1953,7 @@
"description": "Indicates whether failures stemming from the extension will be suppressed (Operational failures such as not connecting to the VM will not be suppressed regardless of this value). The default is false."
},
"protectedSettingsFromKeyVault": {
"type": "object",
"$ref": "./computeRPCommon.json#/definitions/KeyVaultSecretReference",
Copy link
Copy Markdown
Contributor

@grizzlytheodore grizzlytheodore Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this a mistake in the previous version? this will be considered breaking change.
will you comment on why this change is being made / justification for breaking change

Copy link
Copy Markdown
Member Author

@kamusta-msft kamusta-msft Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it was a mistake in the previous version. That's being addressed here: #20101. It should also get fixed here to avoid confusion

"description": "The extensions protected settings that are passed by reference, and consumed from key vault"
}
},
Expand Down Expand Up @@ -1998,7 +1998,7 @@
"description": "Indicates whether failures stemming from the extension will be suppressed (Operational failures such as not connecting to the VM will not be suppressed regardless of this value). The default is false."
},
"protectedSettingsFromKeyVault": {
"type": "object",
"$ref": "./computeRPCommon.json#/definitions/KeyVaultSecretReference",
"description": "The extensions protected settings that are passed by reference, and consumed from key vault"
}
},
Expand Down
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.Compute/ComputeRP/stable/2022-08-01/virtualMachineScaleSet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4498,7 +4498,7 @@
"description": "Indicates whether failures stemming from the extension will be suppressed (Operational failures such as not connecting to the VM will not be suppressed regardless of this value). The default is false."
},
"protectedSettingsFromKeyVault": {
"type": "object",
"$ref": "./computeRPCommon.json#/definitions/KeyVaultSecretReference",
"description": "The extensions protected settings that are passed by reference, and consumed from key vault"
}
},
Expand Down