modify readme.typescript,md in workloads by kazrael2119 · Pull Request #19754 · Azure/azure-rest-api-specs

kazrael2119 · 2022-07-13T01:31:31Z

openapi-workflow-bot · 2022-07-13T01:31:33Z

Hi, @kazrael2119 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-07-13T01:31:35Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

compared tags (via openapi-validator v1.13.0)	new version	base version
default	default(5117037)	default(main)

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-07-13T01:31:35Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go - armworkloads - 0.2.1
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-workloads - 1.0.0b1
❌azure-sdk-for-js - @azure/arm-workloads - 1.0.0-beta.2

+	Interface MonitorsCreateOptionalParams no longer has parameter resumeFrom
+	Interface MonitorsCreateOptionalParams no longer has parameter updateIntervalInMs
+	Interface MonitorsDeleteOptionalParams no longer has parameter resumeFrom
+	Interface MonitorsDeleteOptionalParams no longer has parameter updateIntervalInMs
+	Removed operation Monitors.beginCreate
+	Removed operation Monitors.beginCreateAndWait
+	Removed operation Monitors.beginDelete
+	Removed operation Monitors.beginDeleteAndWait

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 9b33d81. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-workloads [View full logs] [Release SDK Changes]
- azure_mgmt_workloads-1.0.0b1-py3-none-any.whl
- azure-mgmt-workloads-1.0.0b1.zip
```
info	[Changelog]
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9b33d81. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-workloads [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 9b33d81. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armworkloads [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 9b33d81. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-workloads [View full logs] [Release SDK Changes]

azure-arm-workloads-1.0.0-beta.3.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Type Alias DB2ProviderInstanceProperties
info	[Changelog]   - Added Type Alias DeploymentConfiguration
info	[Changelog]   - Added Type Alias DeploymentWithOSConfiguration
info	[Changelog]   - Added Type Alias DiscoveryConfiguration
info	[Changelog]   - Added Type Alias HanaDbProviderInstanceProperties
info	[Changelog]   - Added Type Alias LinuxConfiguration
info	[Changelog]   - Added Type Alias Monitor
info	[Changelog]   - Added Type Alias MonitorPropertiesErrors
info	[Changelog]   - Added Type Alias MsSqlServerProviderInstanceProperties
info	[Changelog]   - Added Type Alias OperationsContent
info	[Changelog]   - Added Type Alias OperationsDefinitionDisplay
info	[Changelog]   - Added Type Alias PatchResourceRequestBodyIdentity
info	[Changelog]   - Added Type Alias PhpWorkloadResource
info	[Changelog]   - Added Type Alias PhpWorkloadResourceIdentity
info	[Changelog]   - Added Type Alias PrometheusHaClusterProviderInstanceProperties
info	[Changelog]   - Added Type Alias PrometheusOSProviderInstanceProperties
info	[Changelog]   - Added Type Alias ProviderInstance
info	[Changelog]   - Added Type Alias ProviderInstancePropertiesErrors
info	[Changelog]   - Added Type Alias ProxyResource
info	[Changelog]   - Added Type Alias SAPApplicationServerInstance
info	[Changelog]   - Added Type Alias SAPCentralServerInstance
info	[Changelog]   - Added Type Alias SAPDatabaseInstance
info	[Changelog]   - Added Type Alias SAPInstallWithoutOSConfigSoftwareConfiguration
info	[Changelog]   - Added Type Alias SapNetWeaverProviderInstanceProperties
info	[Changelog]   - Added Type Alias SAPVirtualInstance
info	[Changelog]   - Added Type Alias SearchProfile
info	[Changelog]   - Added Type Alias ServiceInitiatedSoftwareConfiguration
info	[Changelog]   - Added Type Alias SingleServerConfiguration
info	[Changelog]   - Added Type Alias SingleServerRecommendationResult
info	[Changelog]   - Added Type Alias ThreeTierConfiguration
info	[Changelog]   - Added Type Alias ThreeTierRecommendationResult
info	[Changelog]   - Added Type Alias TrackedResource
info	[Changelog]   - Added Type Alias VmssNodesProfile
info	[Changelog]   - Added Type Alias WindowsConfiguration
info	[Changelog]   - Added Type Alias WordpressInstanceResource
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 9b33d81. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/workloads/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 9b33d81. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️workloads [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

MaryGao · 2022-07-14T06:42:01Z

specification/workloads/resource-manager/readme.typescript.md

+    transform: $["x-ms-long-running-operation-options"] = undefined
+
+  - where-operation: PhpWorkloads_Delete
+    transform: $["x-ms-long-running-operation-options"] = undefined


Could we remove all delete methods?

openapi-workflow-bot · 2022-07-14T09:16:11Z

Hi @kazrael2119, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

MaryGao

LGTM

modify readme.typescript,md in workloads

0574ba9

kazrael2119 requested a review from MaryGao July 13, 2022 01:31

kazrael2119 requested a review from qiaozha as a code owner July 13, 2022 01:31

openapi-assignment-bot bot assigned akning-ms Jul 13, 2022

kazrael2119 removed the request for review from qiaozha July 13, 2022 01:31

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Jul 13, 2022

update properties

0b6cbd3

openapi-pipeline-app bot removed the CI-BreakingChange-JavaScript label Jul 13, 2022

kazrael2119 added 2 commits July 14, 2022 10:08

update file

af3497c

update file

4045748

MaryGao reviewed Jul 14, 2022

View reviewed changes

update files

57607cb

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jul 14, 2022

akning-ms assigned qiaozha and unassigned akning-ms Jul 15, 2022

MaryGao requested a review from qiaozha July 19, 2022 03:56

MaryGao and others added 3 commits July 19, 2022 17:01

Update readme.typescript.md

bc2f152

Update readme.typescript.md

d0d0cf9

Merge branch 'main' into modify-worloads-typescript.readme

8439b06

openapi-pipeline-app bot removed the BreakingChangeReviewRequired label Jul 19, 2022

Remove spaces

5117037

MaryGao approved these changes Jul 19, 2022

View reviewed changes

qiaozha approved these changes Jul 20, 2022

View reviewed changes

qiaozha merged commit 9b33d81 into Azure:main Jul 20, 2022

kazrael2119 deleted the modify-worloads-typescript.readme branch August 2, 2022 02:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modify readme.typescript,md in workloads#19754

modify readme.typescript,md in workloads#19754
qiaozha merged 9 commits intoAzure:mainfrom
kazrael2119:modify-worloads-typescript.readme

kazrael2119 commented Jul 13, 2022

Uh oh!

openapi-workflow-bot bot commented Jul 13, 2022

Uh oh!

openapi-pipeline-app bot commented Jul 13, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Jul 13, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

MaryGao Jul 14, 2022

Uh oh!

openapi-workflow-bot bot commented Jul 14, 2022

Uh oh!

MaryGao left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kazrael2119 commented Jul 13, 2022

Uh oh!

openapi-workflow-bot bot commented Jul 13, 2022

Uh oh!

openapi-pipeline-app bot commented Jul 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jul 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

MaryGao Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

openapi-workflow-bot bot commented Jul 14, 2022

Uh oh!

MaryGao left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openapi-pipeline-app bot commented Jul 13, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jul 13, 2022 •

edited

Loading