Conversation
…enterprise policy resources
|
Hi, @dkappes-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.6)] | new version | base version |
|---|---|---|
| 2020-10-30-preview | 2020-10-30(783d1ff) | 2020-10-30(main) |
| Rule | Message |
|---|---|
1045 - AddedOptionalProperty |
The new version has a new optional property 'systemId' that was not found in the old version. New: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L399:7 Old: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L399:7 |
1045 - AddedOptionalProperty |
The new version has a new optional property 'systemId' that was not found in the old version. New: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L460:7 Old: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L460:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2020-10-30-preview | package-2020-10-30-preview(783d1ff) | package-2020-10-30-preview(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
R4037 - MissingTypeObject |
The schema 'VirtualNetworkPropertiesList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L585 |
R4039 - ParametersOrder |
The parameters:accountName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L31 |
R4039 - ParametersOrder |
The parameters:accountName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L97 |
R4039 - ParametersOrder |
The parameters:accountName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L147 |
R4039 - ParametersOrder |
The parameters:accountName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L198 |
R4039 - ParametersOrder |
The parameters:enterprisePolicyName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L31 |
R4039 - ParametersOrder |
The parameters:enterprisePolicyName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L97 |
R4039 - ParametersOrder |
The parameters:enterprisePolicyName,resourceGroupName should be kept in the same order as they present in the path. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L198 |
| The API version:2020-10-30-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/account.json#L4 |
|
| The API version:2020-10-30-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.PowerPlatform/preview/2020-10-30-preview/enterprisePolicy.json#L4 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: |"readme":"powerplatform/resource-manager/readme.md",
"tag":"package-2020-10-30-preview",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"|
|:speech_balloon: |"readme":"powerplatform/resource-manager/readme.md",
"tag":"package-2020-10-30-preview",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"|
|:speech_balloon: |"readme":"powerplatform/resource-manager/readme.md",
"tag":"package-2020-10-30-preview",
"details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"|
|:speech_balloon: |"readme":"powerplatform/resource-manager/readme.md",
"tag":"package-2020-10-30-preview",
"details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"|
|:speech_balloon: |"readme":"powerplatform/resource-manager/readme.md",
"tag":"package-2020-10-30-preview",
"details":"Autorest completed in 10.34s. 0 files generated."|
The following errors/warnings exist before current PR submission:
|:speech_balloon: |"readme":"powerplatform/resource-manager/readme.md",
"tag":"package-2020-10-30-preview",
"details":"AutoRest core version selected from configuration: ^3.2.0."|
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
|
@honghr PR is ready for your review |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.