Skip to content

Add Owners to GraphRbac#1961

Merged
amarzavery merged 3 commits intoAzure:currentfrom
lmazuel:owner_graphrbac
Nov 3, 2017
Merged

Add Owners to GraphRbac#1961
amarzavery merged 3 commits intoAzure:currentfrom
lmazuel:owner_graphrbac

Conversation

@lmazuel
Copy link
Copy Markdown
Member

@lmazuel lmazuel commented Nov 2, 2017

Fix Azure/azure-sdk-for-python#1359

  • Add Applications_ListOwners
  • Add Application_AddOwner
  • Add ServicePrincipal_ListOwners

Already tested and generated in:
Azure/azure-sdk-for-python#1599

@lmazuel lmazuel requested a review from amarzavery November 2, 2017 21:08
@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Nov 3, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/graphrbac/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 19
After the PR: Warning(s): 0 Error(s): 19

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

amarzavery
amarzavery suggested changes Nov 3, 2017
View reviewed changes
Comment thread specification/graphrbac/data-plane/1.6/graphrbac.json
"type": "string",
"description": "The object type."
},
"deletionTimestamp": {
Copy link
Copy Markdown
Contributor

@amarzavery amarzavery Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"readOnly": true

Comment thread specification/graphrbac/data-plane/1.6/graphrbac.json
},
"objectType": {
"type": "string",
"description": "The object type.",
Copy link
Copy Markdown
Contributor

@amarzavery amarzavery Nov 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object type. Possible values could be "User", "Application", "Group", "ServicePrincipal".

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Nov 3, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/graphrbac/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 19
After the PR: Warning(s): 0 Error(s): 19

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@amarzavery amarzavery merged commit d3b9ed8 into Azure:current Nov 3, 2017
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 3, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Nov 3, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 3, 2017

Build Status Azure/azure-sdk-for-python#1605

@AutorestCI AutorestCI mentioned this pull request Nov 3, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 3, 2017

Build Status Azure/azure-sdk-for-ruby#1109

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 3, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 3, 2017

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Nov 3, 2017

No modification for AutorestCI/azure-sdk-for-ruby

@lmazuel lmazuel deleted the owner_graphrbac branch November 8, 2017 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amarzavery amarzavery amarzavery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amarzavery amarzavery

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lmazuel @azuresdkciprbot @AutorestCI @amarzavery