Skip to content

Conversation

@tshoham
Copy link
Member

@tshoham tshoham commented Jun 12, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tshoham Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    1 similar comment
    @openapi-workflow-bot
    Copy link

    Hi, @tshoham Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 12, 2022

    Swagger Validation Report

    ️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    New: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7
    Old: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7
    1041 - AddedPropertyInResponse The new version has a new property 'mediaServices' in response that was not found in the old version.
    New: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7
    Old: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L965
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1135
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1175
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L971
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1141
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1181
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L438
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L438
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L608
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L608
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connected
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1037
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eventGridProviderRegistered
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1041
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: streamingEndpointStarted
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1055
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1076
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1213
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connected
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1043
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eventGridProviderRegistered
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1047
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: streamingEndpointStarted
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1061
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1082
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1219
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List accounts
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L497
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get account
    Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L596
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List accounts
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L497
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get account
    Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L596
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️🔄CredScan inProgress [Detail]
    ️🔄PoliCheck inProgress [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 12, 2022

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from db38bff. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
      warn	No file changes detected after generation
      warn	No package detected after generation
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from db38bff. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-vi [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-go warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from db38bff. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      cmderr	[generator automation] [WARNING] line in batch '' does not starts with 'tags', ignore
      cmderr	[generator automation] [WARNING] line in batch '' does not starts with 'tags', ignore
    • ️✔️preview/vi/mgmt/2021-11-10-preview/vi [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️preview/vi/mgmt/2021-10-27-preview/vi [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️preview/vi/mgmt/2021-10-18-preview/vi [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from db38bff. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from db38bff. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @tshoham, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    1 similar comment
    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @tshoham, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @tshoham
    Copy link
    Member Author

    tshoham commented Jun 12, 2022

    Similar PR was merged into Main.
    s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here.

    @tshoham tshoham merged commit db38bff into master Jun 12, 2022
    tjprescott pushed a commit that referenced this pull request Oct 7, 2022
    * Copy solutions files from 2015-06-01-preview
    
    * update API version
    
    * update readme
    
    * Add required to ExternalSecuritySolution
    
    * add new swagger files
    
    * fix errors1
    
    * fix2
    
    * fix 3
    
    * fix 4
    
    * fix4
    
    * fix4
    
    * fix conflict
    
    * fix conflict2
    
    * fix conflict4
    
    * fix conflict 6
    
    * fix conflict 7
    
    * ttt
    
    * rrr
    
    * aaa
    
    * bbb
    
    * fix 10
    
    * Prettier check
    
    * update readme
    
    * fix reference error
    
    * fix comment
    
    * fix conflict
    
    * fic conflict2
    
    * fix conflict3
    
    * fix conflict4
    
    * remove files
    
    * delete externalSecuritySolutions
    
    * add assessments.json
    
    * fix readme.md
    
    * Fix validation errors 1
    
    * Fix validation errors 2
    
    * merge
    
    * Fix validation errors 3
    
    * Fix validation errors 4
    
    * Fix validation errors 5
    
    * Fix validation errors 5
    
    * Fix validation errors 5
    
    * Fix validation errors 6
    
    * Fix validation errors 4
    
    * Fix validation errors 7
    
    * Fix validation errors 8
    
    * Fix validation errors 9
    
    * Fix validation errors 10
    
    * fix validation errors 11
    
    * fix validation errors 11
    
    * ix validation errors 12
    
    * ix validation errors 13
    
    * fix validation errors 14
    
    * Fix validation errors 15
    
    * Fix validation errors 16
    
    * run prettier
    
    * adding Services APIs
    
    * more changes
    
    * updated examples
    
    * Defining the APIs for the new NSP resource
    
    * IoT Central Public API 1.1-preview Oct Release (#16514)
    
    * Add new 2.0-preview.1 version for IoT Central
    
    * fix typo on enum value
    
    * rollback 1.0 changes, applied 2.0-preview.1
    
    * fix typo
    
    * remove non-used examples
    
    * fix style
    
    * update version from 2.0-preview.1 to 1.1-preview
    
    * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload
    
    * add nextLink to collection of orgs
    
    * fix typo
    
    * fix wrong position of paging
    
    * fix the paging
    
    * add . to description
    
    * update default to use enum for api-version
    
    * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching
    
    * update examples
    
    * fix lint error, model validation
    
    * fix missing type in examples, remove url format
    
    * fix ID case
    
    * fix id case
    
    * fix ID case
    
    * add iotc query language reference
    
    * fix typo
    
    * test
    
    * SecuritySolution test
    
    * 2
    
    * org
    
    * 1
    
    * [DataFactory]Add support for running staging on multiple sources in parallel (#18825)
    
    * Add support for running staging on multiple sources in parallel
    
    * update
    
    * Add default accountid (#19417)
    
    Similar PR was merged into Main.
    s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here.
    
    * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Removed api docs except dataset
    
    * Dataset 2022-09-01-preview changes
    
    * Readme changes
    
    * Merge Commit
    
    * Minor changes
    
    * Change in readme.md
    
    * Merging from main
    
    * Merging from main
    
    * Udids in List Response
    
    * small changes
    
    * small change
    
    * Wrong update
    
    * outputOntology
    
    * outputOntology
    
    * Append Example
    
    Co-authored-by: Arik Riklin <[email protected]>
    Co-authored-by: ariklin <[email protected]>
    Co-authored-by: Hari Prasad Perabattula <[email protected]>
    Co-authored-by: Meha Kaushik <[email protected]>
    Co-authored-by: Meha Kaushik <[email protected]>
    Co-authored-by: Amit Singh <[email protected]>
    Co-authored-by: Hari Prasad Perabattula <[email protected]>
    Co-authored-by: REDMOND\amisi <[email protected]>
    Co-authored-by: Johnson Yang <[email protected]>
    Co-authored-by: kesharma <[email protected]>
    Co-authored-by: Tal Shoham <[email protected]>
    Co-authored-by: tejitpabari <[email protected]>
    anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022
    * Copy solutions files from 2015-06-01-preview
    
    * update API version
    
    * update readme
    
    * Add required to ExternalSecuritySolution
    
    * add new swagger files
    
    * fix errors1
    
    * fix2
    
    * fix 3
    
    * fix 4
    
    * fix4
    
    * fix4
    
    * fix conflict
    
    * fix conflict2
    
    * fix conflict4
    
    * fix conflict 6
    
    * fix conflict 7
    
    * ttt
    
    * rrr
    
    * aaa
    
    * bbb
    
    * fix 10
    
    * Prettier check
    
    * update readme
    
    * fix reference error
    
    * fix comment
    
    * fix conflict
    
    * fic conflict2
    
    * fix conflict3
    
    * fix conflict4
    
    * remove files
    
    * delete externalSecuritySolutions
    
    * add assessments.json
    
    * fix readme.md
    
    * Fix validation errors 1
    
    * Fix validation errors 2
    
    * merge
    
    * Fix validation errors 3
    
    * Fix validation errors 4
    
    * Fix validation errors 5
    
    * Fix validation errors 5
    
    * Fix validation errors 5
    
    * Fix validation errors 6
    
    * Fix validation errors 4
    
    * Fix validation errors 7
    
    * Fix validation errors 8
    
    * Fix validation errors 9
    
    * Fix validation errors 10
    
    * fix validation errors 11
    
    * fix validation errors 11
    
    * ix validation errors 12
    
    * ix validation errors 13
    
    * fix validation errors 14
    
    * Fix validation errors 15
    
    * Fix validation errors 16
    
    * run prettier
    
    * adding Services APIs
    
    * more changes
    
    * updated examples
    
    * Defining the APIs for the new NSP resource
    
    * IoT Central Public API 1.1-preview Oct Release (Azure#16514)
    
    * Add new 2.0-preview.1 version for IoT Central
    
    * fix typo on enum value
    
    * rollback 1.0 changes, applied 2.0-preview.1
    
    * fix typo
    
    * remove non-used examples
    
    * fix style
    
    * update version from 2.0-preview.1 to 1.1-preview
    
    * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload
    
    * add nextLink to collection of orgs
    
    * fix typo
    
    * fix wrong position of paging
    
    * fix the paging
    
    * add . to description
    
    * update default to use enum for api-version
    
    * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching
    
    * update examples
    
    * fix lint error, model validation
    
    * fix missing type in examples, remove url format
    
    * fix ID case
    
    * fix id case
    
    * fix ID case
    
    * add iotc query language reference
    
    * fix typo
    
    * test
    
    * SecuritySolution test
    
    * 2
    
    * org
    
    * 1
    
    * [DataFactory]Add support for running staging on multiple sources in parallel (Azure#18825)
    
    * Add support for running staging on multiple sources in parallel
    
    * update
    
    * Add default accountid (Azure#19417)
    
    Similar PR was merged into Main.
    s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here.
    
    * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Removed api docs except dataset
    
    * Dataset 2022-09-01-preview changes
    
    * Readme changes
    
    * Merge Commit
    
    * Minor changes
    
    * Change in readme.md
    
    * Merging from main
    
    * Merging from main
    
    * Udids in List Response
    
    * small changes
    
    * small change
    
    * Wrong update
    
    * outputOntology
    
    * outputOntology
    
    * Append Example
    
    Co-authored-by: Arik Riklin <[email protected]>
    Co-authored-by: ariklin <[email protected]>
    Co-authored-by: Hari Prasad Perabattula <[email protected]>
    Co-authored-by: Meha Kaushik <[email protected]>
    Co-authored-by: Meha Kaushik <[email protected]>
    Co-authored-by: Amit Singh <[email protected]>
    Co-authored-by: Hari Prasad Perabattula <[email protected]>
    Co-authored-by: REDMOND\amisi <[email protected]>
    Co-authored-by: Johnson Yang <[email protected]>
    Co-authored-by: kesharma <[email protected]>
    Co-authored-by: Tal Shoham <[email protected]>
    Co-authored-by: tejitpabari <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants