-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add default accountid #19417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default accountid #19417
Conversation
|
Hi, @tshoham Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
1 similar comment
|
Hi, @tshoham Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'properties' renamed or removed? New: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7 Old: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7 |
1041 - AddedPropertyInResponse |
The new version has a new property 'mediaServices' in response that was not found in the old version. New: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7 Old: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1009:7 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
| Rule | Message |
|---|---|
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L965 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1135 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1175 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L971 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1141 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1181 |
| The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L438 |
|
| The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L438 |
|
| OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L608 |
|
| OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L608 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connected Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1037 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eventGridProviderRegistered Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1041 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: streamingEndpointStarted Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1055 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1076 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1213 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connected Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1043 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eventGridProviderRegistered Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1047 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: streamingEndpointStarted Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1061 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1082 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1219 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List accounts Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L497 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get account Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L596 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List accounts Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L497 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get account Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L596 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️🔄CredScan inProgress [Detail]
️🔄PoliCheck inProgress [Detail]
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @tshoham, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
NewApiVersionRequired reason: |
1 similar comment
|
NewApiVersionRequired reason: |
|
Hi @tshoham, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Similar PR was merged into Main. |
* Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * adding Services APIs * more changes * updated examples * Defining the APIs for the new NSP resource * IoT Central Public API 1.1-preview Oct Release (#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * test * SecuritySolution test * 2 * org * 1 * [DataFactory]Add support for running staging on multiple sources in parallel (#18825) * Add support for running staging on multiple sources in parallel * update * Add default accountid (#19417) Similar PR was merged into Main. s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here. * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Removed api docs except dataset * Dataset 2022-09-01-preview changes * Readme changes * Merge Commit * Minor changes * Change in readme.md * Merging from main * Merging from main * Udids in List Response * small changes * small change * Wrong update * outputOntology * outputOntology * Append Example Co-authored-by: Arik Riklin <[email protected]> Co-authored-by: ariklin <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Meha Kaushik <[email protected]> Co-authored-by: Meha Kaushik <[email protected]> Co-authored-by: Amit Singh <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: REDMOND\amisi <[email protected]> Co-authored-by: Johnson Yang <[email protected]> Co-authored-by: kesharma <[email protected]> Co-authored-by: Tal Shoham <[email protected]> Co-authored-by: tejitpabari <[email protected]>
* Copy solutions files from 2015-06-01-preview * update API version * update readme * Add required to ExternalSecuritySolution * add new swagger files * fix errors1 * fix2 * fix 3 * fix 4 * fix4 * fix4 * fix conflict * fix conflict2 * fix conflict4 * fix conflict 6 * fix conflict 7 * ttt * rrr * aaa * bbb * fix 10 * Prettier check * update readme * fix reference error * fix comment * fix conflict * fic conflict2 * fix conflict3 * fix conflict4 * remove files * delete externalSecuritySolutions * add assessments.json * fix readme.md * Fix validation errors 1 * Fix validation errors 2 * merge * Fix validation errors 3 * Fix validation errors 4 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 5 * Fix validation errors 6 * Fix validation errors 4 * Fix validation errors 7 * Fix validation errors 8 * Fix validation errors 9 * Fix validation errors 10 * fix validation errors 11 * fix validation errors 11 * ix validation errors 12 * ix validation errors 13 * fix validation errors 14 * Fix validation errors 15 * Fix validation errors 16 * run prettier * adding Services APIs * more changes * updated examples * Defining the APIs for the new NSP resource * IoT Central Public API 1.1-preview Oct Release (Azure#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * test * SecuritySolution test * 2 * org * 1 * [DataFactory]Add support for running staging on multiple sources in parallel (Azure#18825) * Add support for running staging on multiple sources in parallel * update * Add default accountid (Azure#19417) Similar PR was merged into Main. s360 ticket still leading to this branch - so we are pushing the pull request with the same fixes here. * Adds base for updating Creator from version preview/2.0 to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Removed api docs except dataset * Dataset 2022-09-01-preview changes * Readme changes * Merge Commit * Minor changes * Change in readme.md * Merging from main * Merging from main * Udids in List Response * small changes * small change * Wrong update * outputOntology * outputOntology * Append Example Co-authored-by: Arik Riklin <[email protected]> Co-authored-by: ariklin <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: Meha Kaushik <[email protected]> Co-authored-by: Meha Kaushik <[email protected]> Co-authored-by: Amit Singh <[email protected]> Co-authored-by: Hari Prasad Perabattula <[email protected]> Co-authored-by: REDMOND\amisi <[email protected]> Co-authored-by: Johnson Yang <[email protected]> Co-authored-by: kesharma <[email protected]> Co-authored-by: Tal Shoham <[email protected]> Co-authored-by: tejitpabari <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.