{OperationalInsight} Ingestion value was removed from the DataSourceT…#19365
Merged
{OperationalInsight} Ingestion value was removed from the DataSourceT…#19365
Conversation
…ype enum The API version 2020-03-01-preview supported DataSourceType enum with 'Ingestion' as one of the valid values for log analytics linked storage account. However, this value was removed in 2020-08-01 leading to 'Invalid value' error when storage accounts are linked to a workspace where the data source type is specified as Ingestion.
|
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
1 similar comment
|
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L75 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L146 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L177 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L112 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L226 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
R4037 - MissingTypeObject |
The schema 'LinkedStorageAccountsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L244 |
| The response of operation:'LinkedStorageAccounts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L38 |
|
| The response of operation:'LinkedStorageAccounts_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.OperationalInsights/stable/2020-08-01/LinkedStorageAccounts.json#L118 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/operationalinsights/resource-manager/readme.md tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2022-02 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
- operationalinsights/resource-manager/readme.md#package-2021-12-01-preview
- operationalinsights/resource-manager/readme.md#package-2020-08
- operationalinsights/resource-manager/readme.md#package-2020-10
- operationalinsights/resource-manager/readme.md#package-2021-06
- operationalinsights/resource-manager/readme.md#package-2022-02
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Jun 8, 2022
Contributor
Author
|
@yoramsinger Could you please review this PR once you get a chance ? |
Contributor
|
Looks fine. |
yoramsinger
approved these changes
Jun 13, 2022
Contributor
Author
|
@yoramsinger @yossi-y @OlegAnaniev-MSFT Thanks for approving this. Could you please merge this once you get a chance ? Thanks in advance. |
Contributor
|
@akning-ms can you help us merge this fix, the actual API supports this additional enum, but for some reason it was not added in this version. |
This was referenced Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ype enum
The API version 2020-03-01-preview supported DataSourceType enum with 'Ingestion' as one of the valid values for log analytics linked storage account.
However, this value was removed in 2020-08-01 leading to 'Invalid value' error when storage accounts are linked to a workspace where the data source type is specified as Ingestion.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
fixes Azure/azure-sdk-for-go#18322