Skip to content

Change config of SDK automation for Go#19364

Merged
akning-ms merged 2 commits intoAzure:mainfrom
tadelesh:go_automation
Jun 14, 2022
Merged

Change config of SDK automation for Go#19364
akning-ms merged 2 commits intoAzure:mainfrom
tadelesh:go_automation

Conversation

@tadelesh
Copy link
Member

@tadelesh tadelesh commented Jun 8, 2022 •
edited
Loading

Regarding we have GAed track2 mgmt. plane SDK for Go and will not release any track1 packages, it is no use for running track1 SDK automation for Go. This PR will remove the config of track1 SDK automation for Go and merge two version of SDK automation for Go into one for every RP's readme config.

@openapi-workflow-bot
Copy link

openapi-workflow-bot bot commented Jun 8, 2022

Hi, @tadelesh Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    1 similar comment
    @openapi-workflow-bot
    Copy link

    openapi-workflow-bot bot commented Jun 8, 2022

    Hi, @tadelesh Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json",
    "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specificationRepositoryConfiguration.json",
    "details":"Command failed: node /mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.30/common/temp/node_modules/.pnpm/@Azure+oad@0.9.5/node_modules/autorest/dist/app.js --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp\nFATAL: swagger-document/loader - FAILED\nFATAL: Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n Error: File 'file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specificationRepositoryConfiguration.json' is not a valid OpenAPI 2.0 definition (expected 'swagger: 2.0')\n"
    ️❌LintDiff: 2 Errors, 0 Warnings failed [Detail] The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ AutoRest exception "location":"specification/videoanalyzer/resource-manager/readme.md",
    "tag":"default",
    "details":"swagger-document/compose - FAILED"
    ❌ AutoRest exception "location":"specification/videoanalyzer/resource-manager/readme.md",
    "tag":"default",
    "details":"Error: '$.definitions.Sku.description' has incompatible values (---The resource model definition representing SKU,
    ---The SKU details.)."
    ️⚠️Avocado: 19 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/alertsmanagement/resource-manager/readme.md
    tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2021-08
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/applicationinsights/resource-manager/readme.md
    tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2022-04-01
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/automation/resource-manager/readme.md
    tag: specification/automation/resource-manager/readme.md#tag-package-2021-06-22
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/billing/resource-manager/readme.md
    tag: specification/billing/resource-manager/readme.md#tag-package-2020-05
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-02
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/containerregistry/resource-manager/readme.md
    tag: specification/containerregistry/resource-manager/readme.md#tag-package-2022-02-preview
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/frontdoor/resource-manager/readme.md
    tag: specification/frontdoor/resource-manager/readme.md#tag-package-2020-11
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mariadb/resource-manager/readme.md
    tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mediaservices/resource-manager/readme.md
    tag: specification/mediaservices/resource-manager/readme.md#tag-package-2021-11
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-2022-06
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mysql/resource-manager/readme.md
    tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/operationalinsights/resource-manager/readme.md
    tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2022-02
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/policyinsights/resource-manager/readme.md
    tag: specification/policyinsights/resource-manager/readme.md#tag-package-2022-03
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/reservations/resource-manager/readme.md
    tag: specification/reservations/resource-manager/readme.md#tag-package-2022-03
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/security/resource-manager/readme.md
    tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/subscription/resource-manager/readme.md
    tag: specification/subscription/resource-manager/readme.md#tag-package-2021-10
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ unacceptable kind of an object to dump [object Error] "role":"Model Validation",
    "url":"https://github.com/Azure/azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json"
    ️❌SemanticValidation: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: swagger
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: info
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ❌ OBJECT_MISSING_REQUIRED_PROPERTY Missing required property: paths
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: $schema
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: pipelineName
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: sdkRepositoryMappings
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: overrides
    JsonUrl: azure-rest-api-specs/blob/27ae31f58c7ff87995825f6941e2e3906fa78b12/specificationRepositoryConfiguration.json
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌PoliCheck: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️❌Lint(RPaaS): 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ R4023 - Rpaas_CreateOperationAsyncResponseValidation [RPaaS] An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.WindowsESU/preview/2019-09-16-preview/windowsesu.json#L198
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 8, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️❌ azure-sdk-for-java failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-go failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-python failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    openapi-workflow-bot bot commented Jun 8, 2022

    Hi @tadelesh, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    1 similar comment
    @openapi-workflow-bot
    Copy link

    openapi-workflow-bot bot commented Jun 8, 2022

    Hi @tadelesh, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Jun 8, 2022
    Closed
    Closed
    Closed
    This was referenced Jun 8, 2022
    Closed
    Closed
    Closed
    @tadelesh
    Copy link
    Member Author

    tadelesh commented Jun 8, 2022

    /azp run

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jun 8, 2022

    Azure Pipelines successfully started running 1 pipeline(s).

    @tadelesh tadelesh requested a review from chunyu3 June 8, 2022 14:28
    @tadelesh tadelesh linked an issue Jun 9, 2022 that may be closed by this pull request
    Remove Go previous version SDK automation #19344
    Closed
    This was referenced Jun 14, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @lirenhe lirenhe lirenhe approved these changes

    @chunyu3 chunyu3 Awaiting requested review from chunyu3

    @naveedaz naveedaz Awaiting requested review from naveedaz naveedaz is a code owner

    @allencal allencal Awaiting requested review from allencal

    @wonner wonner Awaiting requested review from wonner

    @atpham256 atpham256 Awaiting requested review from atpham256 atpham256 is a code owner

    @ankushbindlish2 ankushbindlish2 Awaiting requested review from ankushbindlish2 ankushbindlish2 is a code owner

    @JasonYang-MSFT JasonYang-MSFT Awaiting requested review from JasonYang-MSFT

    @jamestao jamestao Awaiting requested review from jamestao jamestao is a code owner

    @ericshape ericshape Awaiting requested review from ericshape ericshape is a code owner

    @samedder samedder Awaiting requested review from samedder

    @v-Ajnava v-Ajnava Awaiting requested review from v-Ajnava

    @dsouzaarun dsouzaarun Awaiting requested review from dsouzaarun dsouzaarun is a code owner

    @damodaravadhani damodaravadhani Awaiting requested review from damodaravadhani damodaravadhani is a code owner

    @tjacobhi tjacobhi Awaiting requested review from tjacobhi

    @TimLovellSmith TimLovellSmith Awaiting requested review from TimLovellSmith TimLovellSmith is a code owner

    @pilor pilor Awaiting requested review from pilor

    @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

    @giakas giakas Awaiting requested review from giakas giakas is a code owner

    @heaths heaths Awaiting requested review from heaths

    @jlichwa jlichwa Awaiting requested review from jlichwa

    @rkmanda rkmanda Awaiting requested review from rkmanda

    @Kishp01 Kishp01 Awaiting requested review from Kishp01 Kishp01 is a code owner

    @ahamad-MS ahamad-MS Awaiting requested review from ahamad-MS

    @NetRock NetRock Awaiting requested review from NetRock

    @Frey-Wang Frey-Wang Awaiting requested review from Frey-Wang Frey-Wang is a code owner

    @zhangyd2015 zhangyd2015 Awaiting requested review from zhangyd2015

    @davidzhaoyue davidzhaoyue Awaiting requested review from davidzhaoyue

    @MehaKaushik MehaKaushik Awaiting requested review from MehaKaushik

    @wmengmsft wmengmsft Awaiting requested review from wmengmsft

    @palma21 palma21 Awaiting requested review from palma21 palma21 is a code owner

    @matthchr matthchr Awaiting requested review from matthchr matthchr is a code owner

    @kjeur kjeur Awaiting requested review from kjeur

    @Sandido Sandido Awaiting requested review from Sandido

    @dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms

    @haagha haagha Awaiting requested review from haagha haagha is a code owner

    @madewithsmiles madewithsmiles Awaiting requested review from madewithsmiles

    @MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs

    @grizzlytheodore grizzlytheodore Awaiting requested review from grizzlytheodore

    @hyonholee hyonholee Awaiting requested review from hyonholee

    @yangyuan yangyuan Awaiting requested review from yangyuan

    @jorinmejia jorinmejia Awaiting requested review from jorinmejia

    @yunheMsft yunheMsft Awaiting requested review from yunheMsft yunheMsft is a code owner

    @t-bzhan t-bzhan Awaiting requested review from t-bzhan

    @wilcobmsft wilcobmsft Awaiting requested review from wilcobmsft wilcobmsft is a code owner

    @asarkar84 asarkar84 Awaiting requested review from asarkar84

    @paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

    @dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

    @stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

    @solankisamir solankisamir Awaiting requested review from solankisamir solankisamir is a code owner

    @ofirmanor ofirmanor Awaiting requested review from ofirmanor

    @orieldar orieldar Awaiting requested review from orieldar

    +1 more reviewer

    @dw511214992 dw511214992 dw511214992 approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @lirenhe lirenhe

    @akning-ms akning-ms

    Labels

    CI-FixRequiredOnFailure

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    Remove Go previous version SDK automation

    4 participants

    @tadelesh @lirenhe @dw511214992 @akning-ms