ADDED DEFAULT VALUE TO accountId in #19348

t-misrael · 2022-06-07T11:37:47Z

AccountPropertiesForPutRequest in
Account

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

AccountPropertiesForPutRequest in Account

openapi-workflow-bot · 2022-06-07T11:37:50Z

Hi, @t-misrael Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-06-07T11:37:50Z

Hi, @t-misrael Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-06-07T11:37:51Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2021-10-18-preview/vi.json compared with base:preview/2021-10-18-preview/vi.json
- current:preview/2021-10-27-preview/vi.json compared with base:preview/2021-10-27-preview/vi.json
- current:preview/2021-11-10-preview/vi.json compared with base:preview/2021-11-10-preview/vi.json
- current:preview/2022-04-13-preview/vi.json compared with base:preview/2022-04-13-preview/vi.json

Rule	Message
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L671:9 Old: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L671:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L784:9 Old: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L784:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L784:9 Old: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L784:9
`❌` 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: Microsoft.VideoIndexer/preview/2022-04-13-preview/vi.json#L784:9 Old: Microsoft.VideoIndexer/preview/2022-04-13-preview/vi.json#L784:9

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L919
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L959
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L965
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1135
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1175
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L971
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1152
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1192
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2022-04-13-preview/vi.json#L1164
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.VideoIndexer/preview/2022-04-13-preview/vi.json#L1204
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L438
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L438
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L438
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Accounts_Delete' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.VideoIndexer/preview/2022-04-13-preview/vi.json#L438
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId Location: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L495
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L608
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L608
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'generateaccesstoken' in:'Generate_AccessToken'. Consider updating the operationId Location: Microsoft.VideoIndexer/preview/2022-04-13-preview/vi.json#L608
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L860
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.VideoIndexer/preview/2021-10-18-preview/vi.json#L997
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connected Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1037
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eventGridProviderRegistered Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1041
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: streamingEndpointStarted Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1055
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1076
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.VideoIndexer/preview/2021-10-27-preview/vi.json#L1213
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: connected Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1054
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: eventGridProviderRegistered Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1058
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: streamingEndpointStarted Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1072
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1093
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.VideoIndexer/preview/2021-11-10-preview/vi.json#L1230

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-06-07T11:37:52Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armvideoindexer - 0.1.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-videoindexer - first release

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 42bc321. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-videoindexer [View full logs] [Release SDK Changes]
- azure-mgmt-videoindexer-1.0.0b1.zip
- azure_mgmt_videoindexer-1.0.0b1-py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 42bc321. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-vi [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 42bc321. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armvideoindexer [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 42bc321. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️vi [View full logs] [Release SDK Changes]

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 42bc321. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️vi [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 42bc321. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.Vi [View full logs] [Release SDK Changes]
- Az.Vi.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-06-07T11:40:36Z

Hi @t-misrael, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

openapi-workflow-bot · 2022-06-07T11:40:36Z

Hi @t-misrael, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

Create to sync Azure/azure-rest-api-specs#19348 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/vi?expand=1)

ADDED DEFAULT VALUE TO accountId in

c54d876

AccountPropertiesForPutRequest in Account

openapi-assignment-bot bot assigned jianyexi Jun 7, 2022

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jun 7, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 7, 2022

jianyexi assigned raych1 and unassigned raych1 Jun 8, 2022

bermanraz approved these changes Jun 8, 2022

View reviewed changes

jianyexi approved these changes Jun 8, 2022

View reviewed changes

jianyexi merged commit 42bc321 into main Jun 8, 2022

This was referenced Jun 8, 2022

[ReleasePR Az.Vi] Feature/barakkinarti/2022 07 20 preview Azure/azure-powershell#18068

Closed

[ReleasePR vi] VI stable/2024-01-01 - AMSless accounts Azure/azure-sdk-for-js#21781

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ADDED DEFAULT VALUE TO accountId in #19348

ADDED DEFAULT VALUE TO accountId in #19348

Uh oh!

t-misrael commented Jun 7, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

openapi-pipeline-app bot commented Jun 7, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Jun 7, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ADDED DEFAULT VALUE TO accountId in #19348

ADDED DEFAULT VALUE TO accountId in #19348

Uh oh!

Conversation

t-misrael commented Jun 7, 2022

Choose a PR Template

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

openapi-pipeline-app bot commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jun 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openapi-pipeline-app bot commented Jun 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 7, 2022 •

edited

Loading