ACSS & PHP public preview - version 1 and AMS V2 docs changes #19232

gargankit-microsoft · 2022-05-26T08:45:03Z

Summary

Please follow the link to find more details on the swagger existing in azure-rest-api-specs-pr : private repo swagger. That has already been reviewed by respective teams and is in private preview.
.NET SDK is failing for some time now for multiple PRs, hence our check is failing for that as well. this is unrelated to change and is caused due to script permissions, which is not in our control.
We are already in touch with owner of .NET SDK (@arthurma) to get it generated offline.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

… Updated Documentation for AMS V2

openapi-workflow-bot · 2022-05-26T08:45:06Z

Hi, @gargankit-microsoft Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-05-26T08:45:07Z

Swagger Validation Report

️❌BreakingChange: 21 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.5)
- current:Microsoft.Workloads/preview/2021-12-01-preview compared with base:Microsoft.Workloads/preview/2021-12-01-preview

Rule	Message
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L37:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L76:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L118:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L323:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L368:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L37:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L93:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L149:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L199:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L249:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L474:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L516:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L555:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L784:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L829:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1058:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1103:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1332:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1377:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1429:5
`❌` 1038 - AddedPath	The new version is adding a path that was not found in the old version. New: Microsoft.Workloads/preview/2021-12-01-preview/skus.json#L37:5

️⚠️LintDiff: 28 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- workloads/resource-manager/readme.md tag:package-2021-12-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- workloads/resource-manager/readme.md tag:package-2021-12-01-preview

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'SAPSupportedSku' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
⚠️ R1003 - ListInOperationName	Since operation 'SAPDiskConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
⚠️ R1003 - ListInOperationName	Since operation 'SAPAvailabilityZoneDetails' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1726
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getsizingrecommendations' in:'SAPSizingRecommendations'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L43
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getsapsupportedsku' in:'SAPSupportedSku'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getdiskconfigurations' in:'SAPDiskConfigurations'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getavailabilityzonedetails' in:'SAPAvailabilityZoneDetails'. Consider updating the operationId Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'applicationInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2963
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'centralInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3175
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'databaseInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3238
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disablePasswordAuthentication Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1864
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAppServerCertified Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2086
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDatabaseCertified Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2090
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hardStop Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2563
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSecondaryIpEnabled Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3257
⚠️ R4021 - DescriptionAndTitleMissing	'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L1342
⚠️ R4021 - DescriptionAndTitleMissing	'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2707
⚠️ R4021 - DescriptionAndTitleMissing	'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2717
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L111
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L153
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L212
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L261
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L316
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L361
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L403
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L462
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Workloads Location: Microsoft.Workloads/preview/2021-12-01-preview/phpWorkloads.json#L502

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'providerInstances' with immediate parent 'Monitor', must have a list by immediate parent operation. Location: Microsoft.Workloads/preview/2021-12-01-preview/monitors.json#L843
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Workloads/preview/2021-12-01-preview/monitors.json#L585

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌PoliCheck: 0 Errors, 0 Warnings failed [Detail]

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

workloads/resource-manager/readme.md#package-2021-12-01-preview

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-26T08:45:08Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armworkloads - 0.2.0
️✔️azure-sdk-for-go - preview/workloads/mgmt/2021-12-01-preview/workloads - v65.0.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-workloads - first release

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 078b906. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.11.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.11.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.11.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-workloads [View full logs] [Release SDK Changes]
- azure_mgmt_workloads-1.0.0b1-py3-none-any.whl
- azure-mgmt-workloads-1.0.0b1.zip
```
info	[Changelog]   - Initial Release
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 078b906. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-workloads [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 078b906. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/workloads/mgmt/2021-12-01-preview/workloads [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 078b906. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armworkloads [View full logs] [Release SDK Changes]

Only show 120 items here, please refer to log for details.

info	[Changelog] - New struct `PhpWorkloadsClientUpdateResponse`
info	[Changelog] - New struct `RestrictionInfo`
info	[Changelog] - New struct `SAPApplicationServerInstance`
info	[Changelog] - New struct `SAPApplicationServerInstanceList`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientBeginCreateOptions`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientBeginDeleteOptions`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientBeginUpdateOptions`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientCreateResponse`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientDeleteResponse`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientGetOptions`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientGetResponse`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientListOptions`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientListResponse`
info	[Changelog] - New struct `SAPApplicationServerInstancesClientUpdateResponse`
info	[Changelog] - New struct `SAPApplicationServerProperties`
info	[Changelog] - New struct `SAPAvailabilityZoneDetailsRequest`
info	[Changelog] - New struct `SAPAvailabilityZoneDetailsResult`
info	[Changelog] - New struct `SAPAvailabilityZonePair`
info	[Changelog] - New struct `SAPCentralInstanceList`
info	[Changelog] - New struct `SAPCentralInstancesClientBeginCreateOptions`
info	[Changelog] - New struct `SAPCentralInstancesClientBeginDeleteOptions`
info	[Changelog] - New struct `SAPCentralInstancesClientBeginUpdateOptions`
info	[Changelog] - New struct `SAPCentralInstancesClientCreateResponse`
info	[Changelog] - New struct `SAPCentralInstancesClientDeleteResponse`
info	[Changelog] - New struct `SAPCentralInstancesClientGetOptions`
info	[Changelog] - New struct `SAPCentralInstancesClientGetResponse`
info	[Changelog] - New struct `SAPCentralInstancesClientListOptions`
info	[Changelog] - New struct `SAPCentralInstancesClientListResponse`
info	[Changelog] - New struct `SAPCentralInstancesClientUpdateResponse`
info	[Changelog] - New struct `SAPCentralServerInstance`
info	[Changelog] - New struct `SAPCentralServerProperties`
info	[Changelog] - New struct `SAPConfiguration`
info	[Changelog] - New struct `SAPDatabaseInstance`
info	[Changelog] - New struct `SAPDatabaseInstanceList`
info	[Changelog] - New struct `SAPDatabaseInstancesClientBeginCreateOptions`
info	[Changelog] - New struct `SAPDatabaseInstancesClientBeginDeleteOptions`
info	[Changelog] - New struct `SAPDatabaseInstancesClientBeginUpdateOptions`
info	[Changelog] - New struct `SAPDatabaseInstancesClientCreateResponse`
info	[Changelog] - New struct `SAPDatabaseInstancesClientDeleteResponse`
info	[Changelog] - New struct `SAPDatabaseInstancesClientGetOptions`
info	[Changelog] - New struct `SAPDatabaseInstancesClientGetResponse`
info	[Changelog] - New struct `SAPDatabaseInstancesClientListOptions`
info	[Changelog] - New struct `SAPDatabaseInstancesClientListResponse`
info	[Changelog] - New struct `SAPDatabaseInstancesClientUpdateResponse`
info	[Changelog] - New struct `SAPDatabaseProperties`
info	[Changelog] - New struct `SAPDiskConfiguration`
info	[Changelog] - New struct `SAPDiskConfigurationsRequest`
info	[Changelog] - New struct `SAPDiskConfigurationsResult`
info	[Changelog] - New struct `SAPInstallWithoutOSConfigSoftwareConfiguration`
info	[Changelog] - New struct `SAPSizingRecommendationRequest`
info	[Changelog] - New struct `SAPSizingRecommendationResult`
info	[Changelog] - New struct `SAPSupportedResourceSKUsResult`
info	[Changelog] - New struct `SAPSupportedSKU`
info	[Changelog] - New struct `SAPSupportedSKUsRequest`
info	[Changelog] - New struct `SAPVirtualInstance`
info	[Changelog] - New struct `SAPVirtualInstanceError`
info	[Changelog] - New struct `SAPVirtualInstanceList`
info	[Changelog] - New struct `SAPVirtualInstanceProperties`
info	[Changelog] - New struct `SAPVirtualInstancesClientBeginCreateOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientBeginDeleteOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientBeginStartOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientBeginStopOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientCreateResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientDeleteResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientGetOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientGetResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientListByResourceGroupOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientListByResourceGroupResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientListBySubscriptionOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientListBySubscriptionResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientStartResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientStopResponse`
info	[Changelog] - New struct `SAPVirtualInstancesClientUpdateOptions`
info	[Changelog] - New struct `SAPVirtualInstancesClientUpdateResponse`
info	[Changelog] - New struct `SKU`
info	[Changelog] - New struct `SKUCapability`
info	[Changelog] - New struct `SKUCapacity`
info	[Changelog] - New struct `SKUCost`
info	[Changelog] - New struct `SKUDefinition`
info	[Changelog] - New struct `SKULocationAndZones`
info	[Changelog] - New struct `SKURestriction`
info	[Changelog] - New struct `SKUZoneDetail`
info	[Changelog] - New struct `SKUsClientListOptions`
info	[Changelog] - New struct `SKUsClientListResponse`
info	[Changelog] - New struct `SKUsListResult`
info	[Changelog] - New struct `SSHConfiguration`
info	[Changelog] - New struct `SSHKeyPair`
info	[Changelog] - New struct `SSHPublicKey`
info	[Changelog] - New struct `SearchProfile`
info	[Changelog] - New struct `ServiceInitiatedSoftwareConfiguration`
info	[Changelog] - New struct `SingleServerConfiguration`
info	[Changelog] - New struct `SingleServerRecommendationResult`
info	[Changelog] - New struct `SiteProfile`
info	[Changelog] - New struct `SoftwareConfiguration`
info	[Changelog] - New struct `StopRequest`
info	[Changelog] - New struct `ThreeTierConfiguration`
info	[Changelog] - New struct `ThreeTierRecommendationResult`
info	[Changelog] - New struct `UpdateSAPApplicationInstanceRequest`
info	[Changelog] - New struct `UpdateSAPCentralInstanceRequest`
info	[Changelog] - New struct `UpdateSAPDatabaseInstanceRequest`
info	[Changelog] - New struct `UpdateSAPVirtualInstanceRequest`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New struct `UserAssignedServiceIdentity`
info	[Changelog] - New struct `UserProfile`
info	[Changelog] - New struct `VirtualMachineConfiguration`
info	[Changelog] - New struct `VmssNodesProfile`
info	[Changelog] - New struct `WindowsConfiguration`
info	[Changelog] - New struct `WordpressInstanceResource`
info	[Changelog] - New struct `WordpressInstanceResourceList`
info	[Changelog] - New struct `WordpressInstanceResourceProperties`
info	[Changelog] - New struct `WordpressInstancesClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `WordpressInstancesClientCreateOrUpdateResponse`
info	[Changelog] - New struct `WordpressInstancesClientDeleteOptions`
info	[Changelog] - New struct `WordpressInstancesClientDeleteResponse`
info	[Changelog] - New struct `WordpressInstancesClientGetOptions`
info	[Changelog] - New struct `WordpressInstancesClientGetResponse`
info	[Changelog] - New struct `WordpressInstancesClientListOptions`
info	[Changelog] - New struct `WordpressInstancesClientListResponse`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 583 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 078b906. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-workloads [View full logs] [Release SDK Changes]
- azure-arm-workloads-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 078b906. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/workloads/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 078b906. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️workloads [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-05-26T08:47:50Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-05-26T08:47:52Z

Hi, @gargankit-microsoft your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

gargankit-microsoft · 2022-05-26T10:26:22Z

policy check is failing due to

The term whitelist was used in file 'custom-words.txt' and may not be appropriate to ship in all contexts. When industry naming conventions or consistency make replacement of the term impractical, leave the term unchanged. When used to describe a list of people or things that have received approval or are considered to be in good favor, replace with "allow list". More specific terms such as "approved list" or "safe recipients list" can be used where appropriate.

Seems unrelated to our changes, as the flagged term is already there. The flag count of three seems to be related to three existing words in file

whitelisted
Whitelisting
Whitelistings

gargankit-microsoft · 2022-05-30T05:46:43Z

PR with ARM signoffs in private repo
SapVirtualInstance: https://github.com/Azure/azure-rest-api-specs-pr/pull/4955
PhpWorkloads: https://github.com/Azure/azure-rest-api-specs-pr/pull/4816

chunyu3 · 2022-05-30T05:50:42Z

PR with ARM signoffs in private repo SapVirtualInstance: Azure/azure-rest-api-specs-pr#4955 PhpWorkloads: Azure/azure-rest-api-specs-pr#4816

The new api-version and new service have been reviewed and approved by ARM already. Mark it 'ArmSignOff'

…2 docs changes (#2393) Create to sync Azure/azure-rest-api-specs#19232 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/workloads?expand=1)

Initial changes for ACSS, PHP workloads under Microsoft.Workloads and…

7154a76

… Updated Documentation for AMS V2

gargankit-microsoft changed the title ~~Initial changes for ACSS, PHP workloads under Microsoft.Workloads and…~~ ACSS & PHP public preview - version 1 May 26, 2022

openapi-pipeline-app bot added the NewApiVersionRequired label May 26, 2022

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 26, 2022

This was referenced May 26, 2022

[AutoPR armworkloads] ACSS & PHP public preview - version 1 azure-sdk/azure-sdk-for-go#1163

Closed

[AutoPR workloads] ACSS & PHP public preview - version 1 azure-sdk/azure-resource-manager-schemas#391

Closed

updated custom words

b9cbc96

gargankit-microsoft mentioned this pull request May 26, 2022

ACSS, PHP & AMSv2 public preview - version 1 #19179

Closed

25 tasks

gargankit-microsoft marked this pull request as ready for review May 26, 2022 09:28

openapi-assignment-bot bot assigned chunyu3 May 26, 2022

gargankit-microsoft requested review from ajaygit158, suhanishri and venu-sivanadham May 26, 2022 09:28

gargankit-microsoft changed the title ~~ACSS & PHP public preview - version 1~~ ACSS & PHP public preview - version 1 and AMS V2 docs changes May 26, 2022

suhanishri approved these changes May 27, 2022

View reviewed changes

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 29, 2022

chunyu3 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 30, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 30, 2022

chunyu3 merged commit 078b906 into main May 30, 2022

azure-sdk mentioned this pull request May 30, 2022

[ReleasePR @azure/arm-workloads] [Microsoft.Workloads/monitors] Add a new API version 2023-10-01-preview Azure/azure-sdk-for-js#21876

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACSS & PHP public preview - version 1 and AMS V2 docs changes #19232

ACSS & PHP public preview - version 1 and AMS V2 docs changes #19232

Uh oh!

gargankit-microsoft commented May 26, 2022 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented May 26, 2022

Uh oh!

openapi-pipeline-app bot commented May 26, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 26, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented May 26, 2022

Uh oh!

openapi-workflow-bot bot commented May 26, 2022

Uh oh!

gargankit-microsoft commented May 26, 2022

Uh oh!

gargankit-microsoft commented May 30, 2022

Uh oh!

chunyu3 commented May 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ACSS & PHP public preview - version 1 and AMS V2 docs changes #19232

ACSS & PHP public preview - version 1 and AMS V2 docs changes #19232

Uh oh!

Conversation

gargankit-microsoft commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented May 26, 2022

Uh oh!

openapi-pipeline-app bot commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented May 26, 2022

Uh oh!

openapi-workflow-bot bot commented May 26, 2022

Uh oh!

gargankit-microsoft commented May 26, 2022

Uh oh!

gargankit-microsoft commented May 30, 2022

Uh oh!

chunyu3 commented May 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gargankit-microsoft commented May 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 26, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 26, 2022 •

edited

Loading