[TrafficManager] Real User Metrics (RUM) fixes #1920

allencal · 2017-10-25T22:28:58Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…raffic Manager. [Traffic Manager] Adding new RealtimeUserMetrics preview feature to Traffic Manager.

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

Changes for real user metrics

# Conflicts: # specification/trafficmanager/resource-manager/Microsoft.Network/2017-05-01/trafficmanager.json

This reverts commit b703b5e.

…specs into current

azuresdkciprbot · 2017-10-25T22:55:41Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/trafficmanager/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

lmazuel · 2017-10-26T16:17:03Z

...icmanager/resource-manager/Microsoft.Network/2017-09-01-preview/trafficmanageranalytics.json

+      "properties": {
+        "id": {
+          "type" : "string",
+          "description": "Fully qualified resource Id for the resource. Ex - /providers/Microsoft.Network/trafficManagerUserMetricsKeys/default"


It seems you removed "default" evrywhere else, is the description still accurate?

You're right, I think I should change this here. The "/default" is still returned in this description, though it shouldn't be; the call with "/default" on the end fails. I'll remove it here, and also in the API operation.

lmazuel · 2017-10-26T16:17:26Z

...icmanager/resource-manager/Microsoft.Network/2017-09-01-preview/trafficmanageranalytics.json

              "$ref": "#/definitions/TrafficManagerUserMetricsKeyModel" 
            }
          },
-          "204": {


Does this mean that 204 is impossible, or you want now a 204 to raise an exception?

The "Get" operation never returns a 204. If the subscription has no RUM key, it returns a 200 and the body returns a blank key ("key": "")

…om resource ID and operation ID [TrafficManager] Real User Metrics (RUM) fixes II - remove default from resource ID and operation ID

azuresdkciprbot · 2017-10-27T23:19:32Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/trafficmanager/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 1
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

lmazuel

LGTM. Tell me if you sign-off or if you have more to add.

allencal · 2017-11-01T23:34:26Z

I do not have more to add. I'm not authorized to merge this pull request. What happens next?

lmazuel · 2017-11-02T17:53:50Z

@allencal Next is I merge :)
If your question is "next-next" like SDK/CLI, please send me an email (my github alias is my MS alias)

AutorestCI · 2017-11-02T17:57:35Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-11-02T17:58:40Z

Azure/azure-sdk-for-python#1597

allencal added 16 commits August 28, 2017 17:55

[Traffic Manager] Adding new RealtimeUserMetrics preview feature to T…

db5f3c2

…raffic Manager. [Traffic Manager] Adding new RealtimeUserMetrics preview feature to Traffic Manager.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

aafe5a6

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

c71f516

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

c371a75

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

396e934

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

145673b

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

124f131

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

[Traffic Manager] Adding new Realtime User Metrics (RUM) preview feat…

302f17e

…ure. [Traffic Manager] Adding new Realtime User Metrics (RUM) preview feature.

RUM fixes

b703b5e

Changes for real user metrics

Merge remote-tracking branch 'upstream/current' into current

ec2107e

# Conflicts: # specification/trafficmanager/resource-manager/Microsoft.Network/2017-05-01/trafficmanager.json

Revert "RUM fixes"

a73736e

This reverts commit b703b5e.

RUM fixes

053271f

RUM fixes

61675da

Remove unreferenced metrics key properties / model from 2017-05-01

a99cc15

Merge branch 'current' of https://github.com/allencal/azure-rest-api-…

27609c1

…specs into current

Remove files

e431c84

azuresdkci assigned lmazuel Oct 25, 2017

lmazuel self-requested a review October 26, 2017 16:07

lmazuel reviewed Oct 26, 2017

View reviewed changes

lmazuel changed the title ~~Real User Metrics (RUM) fixes~~ [TrafficManager] Real User Metrics (RUM) fixes Oct 26, 2017

[TrafficManager] Real User Metrics (RUM) fixes II - remove default fr…

0e39d9c

…om resource ID and operation ID [TrafficManager] Real User Metrics (RUM) fixes II - remove default from resource ID and operation ID

lmazuel approved these changes Oct 30, 2017

View reviewed changes

lmazuel merged commit 342d0f9 into Azure:current Nov 2, 2017

AutorestCI mentioned this pull request Nov 2, 2017

[TrafficManager] Update Azure/azure-sdk-for-python#1597

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TrafficManager] Real User Metrics (RUM) fixes #1920

[TrafficManager] Real User Metrics (RUM) fixes #1920

Uh oh!

allencal commented Oct 25, 2017 •

edited by azuresdkci

Loading

Uh oh!

azuresdkciprbot commented Oct 25, 2017

Uh oh!

lmazuel Oct 26, 2017

Uh oh!

allencal Oct 27, 2017

Uh oh!

lmazuel Oct 26, 2017

Uh oh!

allencal Oct 27, 2017

Uh oh!

azuresdkciprbot commented Oct 27, 2017

Uh oh!

lmazuel left a comment

Uh oh!

allencal commented Nov 1, 2017

Uh oh!

lmazuel commented Nov 2, 2017

Uh oh!

AutorestCI commented Nov 2, 2017

Uh oh!

AutorestCI commented Nov 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[TrafficManager] Real User Metrics (RUM) fixes #1920

[TrafficManager] Real User Metrics (RUM) fixes #1920

Uh oh!

Conversation

allencal commented Oct 25, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Oct 25, 2017

Uh oh!

lmazuel Oct 26, 2017

Choose a reason for hiding this comment

Uh oh!

allencal Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

lmazuel Oct 26, 2017

Choose a reason for hiding this comment

Uh oh!

allencal Oct 27, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Oct 27, 2017

Uh oh!

lmazuel left a comment

Choose a reason for hiding this comment

Uh oh!

allencal commented Nov 1, 2017

Uh oh!

lmazuel commented Nov 2, 2017

Uh oh!

AutorestCI commented Nov 2, 2017

Uh oh!

AutorestCI commented Nov 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allencal commented Oct 25, 2017 •

edited by azuresdkci

Loading