Skip to content

[Hub Generated] Review request for Microsoft.Network to add version stable/2022-05-01#19091

Merged
weidongxu-microsoft merged 30 commits intoAzure:mainfrom
jielichen:dev-frontdoor-Microsoft.Network-2022-05-01-WAFPatch
Jun 16, 2022
Merged

[Hub Generated] Review request for Microsoft.Network to add version stable/2022-05-01#19091
weidongxu-microsoft merged 30 commits intoAzure:mainfrom
jielichen:dev-frontdoor-Microsoft.Network-2022-05-01-WAFPatch

Conversation

@jielichen
Copy link
Copy Markdown
Contributor

@jielichen jielichen commented May 16, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @jielichen Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented May 16, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3021 - PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Network/FrontDoorWebApplicationFirewallManagedRuleSets'
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L271
    R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L252
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L465
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L514
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L542
    R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L548
    R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L40
    R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L53
    R4037 - MissingTypeObject The schema 'AzureAsyncOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L75
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L96
    R4037 - MissingTypeObject The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L96
    R4037 - MissingTypeObject The schema 'SubResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L128
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L138
    R4037 - MissingTypeObject The schema 'TagsObject' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/network.json#L138
    R4037 - MissingTypeObject The schema 'WebApplicationFirewallPolicy' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L312
    R4037 - MissingTypeObject The schema 'WebApplicationFirewallPolicyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L335
    R4037 - MissingTypeObject The schema 'WebApplicationFirewallPolicyList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L417
    R4037 - MissingTypeObject The schema 'PolicySettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L434
    R4037 - MissingTypeObject The schema 'CustomRuleList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L488
    R4037 - MissingTypeObject The schema 'CustomRule' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L500
    R4037 - MissingTypeObject The schema 'MatchCondition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L582
    R4037 - MissingTypeObject The schema 'ManagedRuleSetList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L655
    R4037 - MissingTypeObject The schema 'ManagedRuleGroupOverride' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L704
    R4037 - MissingTypeObject The schema 'ManagedRuleOverride' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L730
    R4037 - MissingTypeObject The schema 'ManagedRuleSetDefinitionList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L757
    R4037 - MissingTypeObject The schema 'ManagedRuleSetDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L774
    R4037 - MissingTypeObject The schema 'ManagedRuleSetDefinitionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L789
    R4037 - MissingTypeObject The schema 'ManagedRuleGroupDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L822
    R4037 - MissingTypeObject The schema 'ManagedRuleDefinition' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L845
    R4037 - MissingTypeObject The schema 'ManagedRuleExclusion' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L870
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/frontdoor/resource-manager/readme.md
    tag: specification/frontdoor/resource-manager/readme.md#tag-package-2022-05
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⚠️Cross-Version Breaking Changes: 4 Warnings warning [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/FrontDoorWebApplicationFirewallPolicies' removed or restructured?
    Old: Microsoft.Network/preview/2019-03-01-preview/webapplicationfirewall.json#L37:5
    ⚠️ 1036 - ConstraintChanged The new version has a different 'maximum' value than the previous one.
    New: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L542:9
    Old: Microsoft.Network/preview/2019-03-01-preview/webapplicationfirewall.json#L441:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L542:9
    Old: Microsoft.Network/preview/2019-03-01-preview/webapplicationfirewall.json#L441:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'minimum' value than the previous one.
    New: Microsoft.Network/stable/2022-05-01/webapplicationfirewall.json#L548:9
    Old: Microsoft.Network/preview/2019-03-01-preview/webapplicationfirewall.json#L445:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app bot commented May 16, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - frontdoor/mgmt/2020-11-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2020-05-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2020-04-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2020-01-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2019-11-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2019-10-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2019-05-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - frontdoor/mgmt/2019-04-01/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go - preview/frontdoor/mgmt/2018-08-01-preview/frontdoor - v65.0.0
    ️✔️azure-sdk-for-go-track2 - armfrontdoor - 1.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-frontdoor - 1.0.1
    azure-sdk-for-js - @azure/arm-frontdoor - 6.0.0
    +	Interface ErrorResponse no longer has parameter code
    +	Interface ErrorResponse no longer has parameter message
    ️✔️azure-sdk-for-go - armfrontdoor - 1.0.1
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from d14b2ed. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/frontdoor/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d14b2ed. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-frontdoor [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation PoliciesOperations.begin_update
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d14b2ed. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armfrontdoor [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d14b2ed. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-frontdoor [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation Policies.beginUpdate
      info	[Changelog]   - Added operation Policies.beginUpdateAndWait
      info	[Changelog]   - Added Interface PoliciesUpdateOptionalParams
      info	[Changelog]   - Added Type Alias PoliciesUpdateResponse
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d14b2ed. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️frontdoor [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi @jielichen, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi, @jielichen your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @jielichen
    Copy link
    Copy Markdown
    Contributor Author

    /azp run unifiedPipeline

    @weidongxu-microsoft weidongxu-microsoft added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 25, 2022
    @jielichen jielichen requested review from 04diiguyi and removed request for 04diiguyi May 26, 2022 02:28
    },
    "responses": {
    "200": {
    "body": {
    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    test

    Copy link
    Copy Markdown

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    test2

    @jielichen
    Copy link
    Copy Markdown
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link
    Copy Markdown

    No pipelines are associated with this pull request.

    @jielichen
    Copy link
    Copy Markdown
    Contributor Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link
    Copy Markdown

    No pipelines are associated with this pull request.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants