Skip to content

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview #18838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 5 commits into from
May 25, 2022
Merged

[Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview #18838

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e21c280
Add Everyday enum to autoPatching.dayOfWeek
rchlkm Apr 27, 2022
bb1b9f7
rename duplicate x-ms-enum
rchlkm May 23, 2022
b8b0006
rename PatchingDayOfWeek
rchlkm May 23, 2022
a6a884d
rename days of week variants
rchlkm May 24, 2022
4913674
rename AutoBackupDaysOfWeek
rchlkm May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...achine/resource-manager/Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,7 +1697,8 @@
"Thursday",
"Friday",
"Saturday",
"Sunday"
"Sunday",
"Everyday"

@rchlkm rchlkm Apr 27, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @raych1, This PR is adding "Everyday" enum value to autoPatchingSettings.dayOfWeek. This value was already an accepted value by SQL VM Resource Provider before we released 2021-11-01 version, however, the enum value as missed during the swagger generation process.

How can we avoid this breaking change flag?

@raych1 raych1 Apr 28, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to get breaking change review board approval.

],
"type": "string",
"x-ms-enum": {
Expand Down