microsoft.storagecache 2022-05-01#18827
Conversation
|
Hi, @paujohn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Hi, @paujohn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Swagger Generation Artifacts
|
|
Hi @paujohn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Swagger Generation Artifacts
|
|
Hi @tadelesh We are ready for review. Listed below are the explanations of why the above errors persist and why they can safely be ignored: API readiness checkFailed since the service deployment has not started rolling out yet. Our team will start service deployment on May 16th and it will take 2 weeks to complete. We are just getting approval so that the new api-version can be merged once we are completely ready. SDK azure-sdk-for-netA question about the same error message was asked on Azure API and Tools Support in the General channel and Ray Chen said that we ignore these failures Swagger ModelValidationFailed since the required property primingManifestUrl is not present in GET or PUT responses. This is an issue with the validation checker since primingManifestUrl is labeled as both required and x-ms-secret. According to "primingManifestUrl": { Swagger SDK Breaking Change TrackingThe Swagger SDK Breaking Change Tracking failure is only for API version 2020-03-01, which I have not edited in this PR. |
this is incorrect. You cannot do a POST on a resource like this. POSTs are actions that can be done on resources. Please remodel this api and submit. Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2022-05-01/storagecache.json:1330 in 0d6131d. [](commit_id = 0d6131d, deletion_comment = False) |
|
@tadelesh Please merge this pull request. We have rolled out the latest api release 2022-05-01 (both the RP and Manifest) have been rolled out to all regions. |
|
@raosuhas If there is no more question, could you please unblock the PR. |
|
adding an approval to unblock based on zizhous review |

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.