Skip to content

Comments

microsoft.storagecache 2022-05-01#18827

Merged
tadelesh merged 14 commits intoAzure:mainfrom
paujohn:dev-storagecache-Microsoft.StorageCache-2022-05-01
Jun 8, 2022
Merged

microsoft.storagecache 2022-05-01#18827
tadelesh merged 14 commits intoAzure:mainfrom
paujohn:dev-storagecache-Microsoft.StorageCache-2022-05-01

Conversation

@paujohn
Copy link
Contributor

@paujohn paujohn commented Apr 26, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. May 2022
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. May 2022
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@paujohn paujohn added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Apr 26, 2022
@openapi-workflow-bot
Copy link

Hi, @paujohn Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 26, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @paujohn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 26, 2022

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 26, 2022

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️🔄 azure-sdk-for-java inProgress [Detail]
    ️🔄 azure-sdk-for-go inProgress [Detail]
    ️⌛ azure-sdk-for-go-track2 pending [Detail]
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️🔄 azure-powershell inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @paujohn, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 26, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armstoragecache - 1.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-storagecache - 1.2.0
    ️✔️azure-sdk-for-go - storagecache/mgmt/2022-01-01/storagecache - v65.0.0
    ️✔️azure-sdk-for-go - storagecache/mgmt/2021-09-01/storagecache - v65.0.0
    ️✔️azure-sdk-for-go - storagecache/mgmt/2021-05-01/storagecache - v65.0.0
    ️✔️azure-sdk-for-go - storagecache/mgmt/2021-03-01/storagecache - v65.0.0
    ️✔️azure-sdk-for-go - storagecache/mgmt/2020-10-01/storagecache - v65.0.0
    azure-sdk-for-go - storagecache/mgmt/2020-03-01/storagecache - v65.0.0
    +	Function `CachesClient.DeleteResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
    +	Function `CachesClient.FlushResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
    +	Function `CachesClient.StartResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
    +	Function `CachesClient.StopResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
    +	Function `CachesClient.UpgradeFirmwareResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
    +	Function `StorageTargetsClient.DeleteResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
    +	Struct `SetObject` has been removed
    +	Type of `CachesDeleteFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
    +	Type of `CachesFlushFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
    +	Type of `CachesStartFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
    +	Type of `CachesStopFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
    +	Type of `CachesUpgradeFirmwareFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
    +	Type of `StorageTargetsDeleteFuture.Result` has been changed from `func(StorageTargetsClient) (SetObject, error)` to `func(StorageTargetsClient) (autorest.Response, error)`
    ️✔️azure-sdk-for-go - storagecache/mgmt/2019-11-01/storagecache - v65.0.0
    ️✔️azure-sdk-for-go - preview/storagecache/mgmt/2019-08-01-preview/storagecache - v65.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation CachesOperations.begin_pause_priming_job
      info	[Changelog]   - Added operation CachesOperations.begin_resume_priming_job
      info	[Changelog]   - Added operation CachesOperations.begin_space_allocation
      info	[Changelog]   - Added operation CachesOperations.begin_start_priming_job
      info	[Changelog]   - Added operation CachesOperations.begin_stop_priming_job
      info	[Changelog]   - Model ApiOperationPropertiesServiceSpecification has a new parameter log_specifications
      info	[Changelog]   - Model Cache has a new parameter priming_jobs
      info	[Changelog]   - Model Cache has a new parameter space_allocation
      info	[Changelog]   - Model Cache has a new parameter upgrade_settings
      info	[Changelog]   - Model StorageTarget has a new parameter allocation_percentage
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-storagecache [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️storagecache/mgmt/2022-01-01/storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️storagecache/mgmt/2021-09-01/storagecache [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️storagecache/mgmt/2021-05-01/storagecache [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️storagecache/mgmt/2021-03-01/storagecache [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️storagecache/mgmt/2020-10-01/storagecache [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️storagecache/mgmt/2020-03-01/storagecache [View full logs
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - Type of `CachesFlushFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesDeleteFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesStartFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Type of `CachesStopFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
      info	[Changelog] - Struct `SetObject` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `AscOperationProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*AscOperation.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `AscOperation.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `AscOperationProperties`
      info	[Changelog] - New anonymous field `*AscOperationProperties` in struct `AscOperation`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 6 additive change(s).
    • ️✔️storagecache/mgmt/2019-11-01/storagecache [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/storagecache/mgmt/2019-08-01-preview/storagecache [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armstoragecache [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `HealthStateTypeWaitingForKey`
      info	[Changelog] - New const `PrimingJobStateQueued`
      info	[Changelog] - New const `HealthStateTypeStartFailed`
      info	[Changelog] - New const `PrimingJobStateComplete`
      info	[Changelog] - New const `PrimingJobStatePaused`
      info	[Changelog] - New const `HealthStateTypeUpgradeFailed`
      info	[Changelog] - New const `PrimingJobStateRunning`
      info	[Changelog] - New function `PossiblePrimingJobStateValues() []PrimingJobState`
      info	[Changelog] - New function `*CachesClient.BeginStartPrimingJob(context.Context, string, string, *CachesClientBeginStartPrimingJobOptions) (*runtime.Poller[CachesClientStartPrimingJobResponse], error)`
      info	[Changelog] - New function `*CachesClient.BeginResumePrimingJob(context.Context, string, string, *CachesClientBeginResumePrimingJobOptions) (*runtime.Poller[CachesClientResumePrimingJobResponse], error)`
      info	[Changelog] - New function `*CachesClient.BeginStopPrimingJob(context.Context, string, string, *CachesClientBeginStopPrimingJobOptions) (*runtime.Poller[CachesClientStopPrimingJobResponse], error)`
      info	[Changelog] - New function `*CachesClient.BeginSpaceAllocation(context.Context, string, string, *CachesClientBeginSpaceAllocationOptions) (*runtime.Poller[CachesClientSpaceAllocationResponse], error)`
      info	[Changelog] - New function `*CachesClient.BeginPausePrimingJob(context.Context, string, string, *CachesClientBeginPausePrimingJobOptions) (*runtime.Poller[CachesClientPausePrimingJobResponse], error)`
      info	[Changelog] - New struct `CacheUpgradeSettings`
      info	[Changelog] - New struct `CachesClientBeginPausePrimingJobOptions`
      info	[Changelog] - New struct `CachesClientBeginResumePrimingJobOptions`
      info	[Changelog] - New struct `CachesClientBeginSpaceAllocationOptions`
      info	[Changelog] - New struct `CachesClientBeginStartPrimingJobOptions`
      info	[Changelog] - New struct `CachesClientBeginStopPrimingJobOptions`
      info	[Changelog] - New struct `CachesClientPausePrimingJobResponse`
      info	[Changelog] - New struct `CachesClientResumePrimingJobResponse`
      info	[Changelog] - New struct `CachesClientSpaceAllocationResponse`
      info	[Changelog] - New struct `CachesClientStartPrimingJobResponse`
      info	[Changelog] - New struct `CachesClientStopPrimingJobResponse`
      info	[Changelog] - New struct `LogSpecification`
      info	[Changelog] - New struct `PrimingJob`
      info	[Changelog] - New struct `PrimingJobIDParameter`
      info	[Changelog] - New struct `StorageTargetSpaceAllocation`
      info	[Changelog] - New field `SpaceAllocation` in struct `CacheProperties`
      info	[Changelog] - New field `PrimingJobs` in struct `CacheProperties`
      info	[Changelog] - New field `UpgradeSettings` in struct `CacheProperties`
      info	[Changelog] - New field `LogSpecifications` in struct `APIOperationPropertiesServiceSpecification`
      info	[Changelog] - New field `AllocationPercentage` in struct `StorageTargetProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 46 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] WARN deprecated read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/storage-blob@10.5.0: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-storagecache [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation Caches.beginPausePrimingJob
      info	[Changelog]   - Added operation Caches.beginPausePrimingJobAndWait
      info	[Changelog]   - Added operation Caches.beginResumePrimingJob
      info	[Changelog]   - Added operation Caches.beginResumePrimingJobAndWait
      info	[Changelog]   - Added operation Caches.beginSpaceAllocation
      info	[Changelog]   - Added operation Caches.beginSpaceAllocationAndWait
      info	[Changelog]   - Added operation Caches.beginStartPrimingJob
      info	[Changelog]   - Added operation Caches.beginStartPrimingJobAndWait
      info	[Changelog]   - Added operation Caches.beginStopPrimingJob
      info	[Changelog]   - Added operation Caches.beginStopPrimingJobAndWait
      info	[Changelog]   - Added Interface CachesPausePrimingJobHeaders
      info	[Changelog]   - Added Interface CachesPausePrimingJobOptionalParams
      info	[Changelog]   - Added Interface CachesResumePrimingJobHeaders
      info	[Changelog]   - Added Interface CachesResumePrimingJobOptionalParams
      info	[Changelog]   - Added Interface CachesSpaceAllocationHeaders
      info	[Changelog]   - Added Interface CachesSpaceAllocationOptionalParams
      info	[Changelog]   - Added Interface CachesStartPrimingJobHeaders
      info	[Changelog]   - Added Interface CachesStartPrimingJobOptionalParams
      info	[Changelog]   - Added Interface CachesStopPrimingJobHeaders
      info	[Changelog]   - Added Interface CachesStopPrimingJobOptionalParams
      info	[Changelog]   - Added Interface CacheUpgradeSettings
      info	[Changelog]   - Added Interface LogSpecification
      info	[Changelog]   - Added Interface PrimingJob
      info	[Changelog]   - Added Interface PrimingJobIdParameter
      info	[Changelog]   - Added Interface StorageTargetSpaceAllocation
      info	[Changelog]   - Added Type Alias CachesPausePrimingJobResponse
      info	[Changelog]   - Added Type Alias CachesResumePrimingJobResponse
      info	[Changelog]   - Added Type Alias CachesSpaceAllocationResponse
      info	[Changelog]   - Added Type Alias CachesStartPrimingJobResponse
      info	[Changelog]   - Added Type Alias CachesStopPrimingJobResponse
      info	[Changelog]   - Added Type Alias PrimingJobState
      info	[Changelog]   - Interface ApiOperationPropertiesServiceSpecification has a new optional parameter logSpecifications
      info	[Changelog]   - Interface Cache_2 has a new optional parameter primingJobs
      info	[Changelog]   - Interface Cache_2 has a new optional parameter spaceAllocation
      info	[Changelog]   - Interface Cache_2 has a new optional parameter upgradeSettings
      info	[Changelog]   - Type Alias StorageTarget has a new parameter allocationPercentage
      info	[Changelog]   - Added Enum KnownPrimingJobState
      info	[Changelog]   - Enum KnownHealthStateType has a new value StartFailed
      info	[Changelog]   - Enum KnownHealthStateType has a new value UpgradeFailed
      info	[Changelog]   - Enum KnownHealthStateType has a new value WaitingForKey
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d3ae1c0. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️storagecache [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from d3ae1c0. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.storagecache [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @paujohn
    Copy link
    Contributor Author

    paujohn commented Apr 27, 2022

    Hi @tadelesh

    We are ready for review.

    Listed below are the explanations of why the above errors persist and why they can safely be ignored:

    API readiness check

    Failed since the service deployment has not started rolling out yet. Our team will start service deployment on May 16th and it will take 2 weeks to complete. We are just getting approval so that the new api-version can be merged once we are completely ready.

    SDK azure-sdk-for-net

    A question about the same error message was asked on Azure API and Tools Support in the General channel and Ray Chen said that we ignore these failures
    image

    Swagger ModelValidation

    Failed since the required property primingManifestUrl is not present in GET or PUT responses. This is an issue with the validation checker since primingManifestUrl is labeled as both required and x-ms-secret. According to
    the x-ms-secret autorest specs, "When a property is modeled as both "required" and "x-ms-secret": true, which means that this property must not exist in the response but has to be present in request." which is what we do in the examples.

    "primingManifestUrl": {
     "description": "The URL for the priming manifest file to download. This file must be readable from the HPC Cache. When the file is in Azure blob storage the URL should include a Shared Access Signature (SAS) granting read permissions on the blob.",
     "$ref": "#/definitions/URLString",
     "x-ms-mutability": [
      "create"
     ],
    "x-ms-secret": true
    },
    "required": [
     "primingJobName",
    "primingManifestUrl"
    ],

    Swagger SDK Breaking Change Tracking

    The Swagger SDK Breaking Change Tracking failure is only for API version 2020-03-01, which I have not edited in this PR.

    @raosuhas
    Copy link
    Member

        },
    

    include return header definitions. For a POST it must include location header


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2022-05-01/storagecache.json:1317 in 0d6131d. [](commit_id = 0d6131d, deletion_comment = False)

    @raosuhas
    Copy link
    Member

      "post": {
    

    this is incorrect. You cannot do a POST on a resource like this. POSTs are actions that can be done on resources. Please remodel this api and submit.


    Refers to: specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2022-05-01/storagecache.json:1330 in 0d6131d. [](commit_id = 0d6131d, deletion_comment = False)

    @tadelesh tadelesh added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 9, 2022
    @paujohn paujohn removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jun 2, 2022
    @paujohn
    Copy link
    Contributor Author

    paujohn commented Jun 2, 2022

    @tadelesh Please merge this pull request.

    We have rolled out the latest api release 2022-05-01 (both the RP and Manifest) have been rolled out to all regions.

    @tadelesh
    Copy link
    Member

    tadelesh commented Jun 3, 2022

    @raosuhas If there is no more question, could you please unblock the PR.

    @paujohn
    Copy link
    Contributor Author

    paujohn commented Jun 6, 2022

    @raosuhas If there is no more question, could you please unblock the PR.

    @raosuhas , @zizw123 has already reviewed and approved the PR. Could you please remove the 'change requested' block that is keeping this PR from getting merged?

    @raosuhas raosuhas requested review from raosuhas and removed request for raosuhas June 6, 2022 19:21
    @raosuhas raosuhas removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 6, 2022
    @paujohn
    Copy link
    Contributor Author

    paujohn commented Jun 6, 2022

    @tadelesh Could you merge the PR, now that @raosuhas has unblocked it.

    @raosuhas
    Copy link
    Member

    raosuhas commented Jun 6, 2022

    @raosuhas If there is no more question, could you please unblock the PR.

    @tadelesh How do I unblock it ? I have updated all the labels

    @tadelesh
    Copy link
    Member

    tadelesh commented Jun 7, 2022

    @raosuhas If there is no more question, could you please unblock the PR.

    @tadelesh How do I unblock it ? I have updated all the labels

    @paujohn Still blocked. @raosuhas You need to approve this PR.

    Copy link
    Member

    @raosuhas raosuhas left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @raosuhas
    Copy link
    Member

    raosuhas commented Jun 7, 2022

    :shipit:

    adding an approval to unblock based on zizhous review

    @paujohn
    Copy link
    Contributor Author

    paujohn commented Jun 7, 2022

    @tadelesh Can you please merge this PR, now that it has been approved by @raosuhas

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-ModelValidation Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-FixRequiredOnFailure

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants