Skip to content

Update Microsoft.Resources tag for SDK Generation #18683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 4 commits into from
Apr 15, 2022
Merged

Update Microsoft.Resources tag for SDK Generation #18683

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47f85c4
Update readme.md
dhu5432 Apr 14, 2022
55b696b
Update readme.md
dhu5432 Apr 14, 2022
ef3e80f
Update readme.md
dhu5432 Apr 14, 2022
f6fe390
Update readme.md
dhu5432 Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions specification/resources/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ These are the global settings for the Resource API.

``` yaml
openapi-type: arm
tag: package-resources-2021-04
tag: package-changes-2022-03-01-preview
Copy link
Member

@cataggar cataggar May 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the default tag need to be changed? I don't think it is needs to be changed for SDK generation. I don't think they should be set to a preview. Can't it be left as package-resources-<stable-api>? It was introduced in #18475.

```

``` yaml $(package-privatelinks)
Expand Down Expand Up @@ -70,14 +70,14 @@ tag: package-templatespecs-2021-05
```

``` yaml $(package-changes)
tag: package-changes-2022-03
tag: package-changes-2022-03-01-preview
```

### Tag: package-changes-2022-03
### Tag: package-changes-2022-03-01-preview

These settings apply only when `--tag=package-changes-2022-03-01-preview` is specified on the command line.

``` yaml $(tag) == 'package-changes-2022-03'
``` yaml $(tag) == 'package-changes-2022-03-01-preview'
input-file:
- Microsoft.Resources/preview/2022-03-01-preview/changes.json
```
Expand Down