Skip to content

[KeyVault] - Suppress known validation false-positives #18370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 1 commit into from
Mar 30, 2022
Merged

[KeyVault] - Suppress known validation false-positives #18370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions specification/keyvault/data-plane/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,4 +429,11 @@ directive:
from: securitydomain.json
where: $.definitions.TransferKey.properties.key_format
reason: Consistency with other properties
- suppress: DOUBLE_FORWARD_SLASHES_IN_URL
from: rbac.json
Comment thread
heaths marked this conversation as resolved.
Copy link
Copy Markdown
Member

@heaths heaths Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, since both of these problems happen in other files, does suppression work if you get rid of from: rbac.json? Is it required?

reason: / is a valid scope in this scenario.
- suppress: OBJECT_MISSING_REQUIRED_PROPERTY
from: rbac.json
where: $..parameters[?(@.name=='scope')]
reason: Suppress an invalid error caused by a bug in the linter.
```