[NetAppFiles ]Anf 18545 rotterdam phase2 2021 12 01 preview#18274
Closed
audunn wants to merge 11 commits into
Closed
[NetAppFiles ]Anf 18545 rotterdam phase2 2021 12 01 preview#18274audunn wants to merge 11 commits into
audunn wants to merge 11 commits into
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
Swagger Generation Artifacts
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 17, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@raych1 can we get this PR moving the changes here are in a preview api version and where reviewed in the private repo. https://github.com/Azure/azure-rest-api-specs-pr/pull/5709 |
Member
Author
|
ping |
openapi-workflow-bot
Bot
added
ARMReview
WaitForARMFeedback
|
Hi, @audunn your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
raych1
removed
WaitForARMFeedback
Member
|
@audunn , next time please use the publish PR link to publish the PR reviewed in private repo so that the review here can be fast. I saw this PR has 6 more file changes than the PR in private repo. What's that change? Please also resolve the conflicts. |
Member
Author
|
@raych1 did not know of this button thank you will use next time should make thinks simpler. Thank you. |
This was referenced May 30, 2022
Member
This URI format specifies a collection of instances of the type regionInfo, so the response should be an array. If regionInfo doesn't actually behave like a resource type, you should consider using POST instead. If it does behave like a resource type, it should be modeled as named instances of the regionInfo resource type with the full complement of CRUD operations (GET/PUT/collection GET/DELETE/PATCH). Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2021-12-01-preview/netapp.json:295 in 9be46d5. [](commit_id = 9be46d5, deletion_comment = False) |
Member
From looking at the definitions for these payloads, it seems like sibling set does behave more like an ARM resource type (has a name/id, has query and update operations). Did you consider modeling as a resource type with standard ARM CRUD operations? Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2021-12-01-preview/netapp.json:332 in 9be46d5. [](commit_id = 9be46d5, deletion_comment = False) |
Member
Consider using enum instead of boolean, e.g. zoneAvailability: { available, unavailable } or similar. Generally enums are preferred over boolean for several reasons (ref: https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html?q=boolean#common-issues-found-in-review). Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2021-12-01-preview/netapp.json:7009 in 9be46d5. [](commit_id = 9be46d5, deletion_comment = False) |
Member
|
@audunn - Looks like this PR got into my queue before WaitForARMReview was removed. I left some comments related to ARM review before noticing the label was gone. Please consider those comments in any subsequent PRs or updates. |
Member
|
@audunn , can you resolve conflicts and resolve the CI check errors( In addition, can you get breaking change review approval for the change of changing default value? see cross version breaking change errors. |
|
Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi, @audunn. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @audunn. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR where reviewed on the private repo and synced with latest main here. This adds a new preview api version.
https://github.com/Azure/azure-rest-api-specs-pr/pull/5709
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.