Update confluent.json for LintDiff fixes#18261
Merged
ArcturusZhang merged 1 commit intodev-confluent-Microsoft.Confluent-2021-12-01from Mar 16, 2022
Merged
Update confluent.json for LintDiff fixes#18261ArcturusZhang merged 1 commit intodev-confluent-Microsoft.Confluent-2021-12-01from
ArcturusZhang merged 1 commit intodev-confluent-Microsoft.Confluent-2021-12-01from
Conversation
|
Hi, @krishnasriSomepalli Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
R2018 - XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L942 |
| OperationId should contain the verb: 'orgvalidate' in:'Validations_ValidateOrganization'. Consider updating the operationId Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L473 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: accepted Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L559 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Confluent/stable/2021-12-01/confluent.json#L649 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 33 Errors, 17 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2021-12-01/confluent.json compared with base:stable/2020-03-01/confluent.json
- current:stable/2021-12-01/confluent.json compared with base:preview/2021-09-01-preview/confluent.json
Only 30 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with latest preview version:
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Mar 15, 2022
qiaozha
approved these changes
Mar 15, 2022
Member
|
@ArcturusZhang Could you take a look at the Go SDK breaking change ? |
changlong-liu
pushed a commit
that referenced
this pull request
Mar 28, 2022
… stable/2021-12-01 (#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (#17071) * Update confluent.json (#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (#18261)
visingl
pushed a commit
that referenced
this pull request
Mar 30, 2022
… stable/2021-12-01 (#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (#17071) * Update confluent.json (#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (#18261)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
… stable/2021-12-01 (Azure#17070) * Adds base for updating Microsoft.Confluent from version preview/2021-09-01-preview to version 2021-12-01 * Updates readme * Updates API version in new specs and examples * Fixing spellcheck and updating readme files (Azure#17071) * Update confluent.json (Azure#18254) Fixing linting errors * Update confluent.json for LintDiff fixes (Azure#18261)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent: #17070