Add swagger changes for zone redundancy property to databases, elastic pools and editions#1813
Conversation
fearthecowboy
left a comment
There was a problem hiding this comment.
@emgu-ms -- if you are an MS employee, make sure your account is tied to your domain account so that it's cleared by the CLA check.
if not, you can sign the cla (follow the instructions in the post...)
|
Looks good. Just want to make sure this is on in at least 1 production region and has .NET SDK test written and working on your machine before this gets merged. |
| "description": "Whether or not zone redundancy is supported for the edition.", | ||
| "type": "boolean", | ||
| "type": "string", | ||
| "format": "boolean" |
There was a problem hiding this comment.
I think you need a comma at the end here
jaredmoo
left a comment
There was a problem hiding this comment.
Looks good, please confirm that .NET SDK is working and then let's merge.
|
Oh ho, linter errors. It looks like boolean format doesn't exist. I think you'll have to just remove those format's and treat it as plain string. |
|
Is the value a swagger uses . |
|
The value is either |
|
Ah. ok.
Ouch. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hey @emgu-ms, are we getting close to being ready to merge this? |
|
Yup! We're good! Thanks all :) |
|
No modification for AutorestCI/azure-sdk-for-node |
|
No modification for AutorestCI/azure-sdk-for-node |
|
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger