-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Adding NSP child resources, profile and access rule, to swagger #18066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f6fe18b
Merge pull request #3 from Azure/master
harics24 67c4abd
Merge branch 'Azure:master' into master
harics24 87a694d
Defining the APIs for the new NSP resource
f5dcf02
Merge branch 'Azure:master' into master
harics24 204f5f9
Merge branch 'Azure:master' into master
harics24 248d5e9
Merge branch 'Azure:master' into master
harics24 a18974f
Merge branch 'master' into master
harics24 db05f84
Merge pull request #6 from Azure/master
harics24 c9e0054
Adding NSP child resources - profile and access rule
81af22c
Fixing the model errors, prettier-fix and typos
c4ae63d
Fixing the typo in the spec file for NSP
29d9815
Adding definitions for resource association
76d57b2
Prettier fix on the spec and example files
591c709
Fix typos, and removing the apiVersion on the top level
830e273
Handling the review comments
a1d91af
Correcting the subId in the path
455d379
Merge branch 'Azure:main' into nsp-child-resources
harics24 5b63dc5
Adding the NSP preview version for go in the read me
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
...ce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "title": "Delete NSP access rule", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1", | ||
| "accessRuleName": "accessRule1" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
31 changes: 31 additions & 0 deletions
31
...ource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "title": "Get NSP Access Rule", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1", | ||
| "accessRuleName": "accessRule1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "accessRule1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1/accessRules/accessRule1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles/accessRules", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "direction": "Outbound", | ||
| "addressPrefixes": [], | ||
| "fullyQualifiedDomainNames": [ | ||
| "paasrp1.contoso.org", | ||
| "paasrp2.contoso.org" | ||
| ], | ||
| "subscriptions": [], | ||
| "networkSecurityPerimeters": [] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
51 changes: 51 additions & 0 deletions
51
...urce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRuleList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| { | ||
| "title": "List NSP Access Rules", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "accessRule1", | ||
| "id": "/subscriptions/rg1/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1/accessRules/accessRule1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles/accessRules", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "direction": "Inbound", | ||
| "addressPrefixes": [ | ||
| "10.11.0.0/16", | ||
| "10.10.1.0/24" | ||
| ], | ||
| "fullyQualifiedDomainNames": [], | ||
| "subscriptions": [], | ||
| "networkSecurityPerimeters": [] | ||
| } | ||
| }, | ||
| { | ||
| "name": "accessRule2", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1/accessRules/accessRule2", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles/accessRules", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "direction": "Outbound", | ||
| "addressPrefixes": [], | ||
| "fullyQualifiedDomainNames": [ | ||
| "paasrp1.contoso.org", | ||
| "paasrp2.contoso.org" | ||
| ], | ||
| "subscriptions": [], | ||
| "networkSecurityPerimeters": [] | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1/accessRules?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
58 changes: 58 additions & 0 deletions
58
...ource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAccessRulePut.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| { | ||
| "title": "Create/Update NSP access rule", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1", | ||
| "accessRuleName": "accessRule1", | ||
| "parameters": { | ||
| "properties": { | ||
| "direction": "Inbound", | ||
| "addressPrefixes": [ | ||
| "10.11.0.0/16", | ||
| "10.10.1.0/24" | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "accessRule1", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1/accessRules/accessRule1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles/accessRules", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "direction": "Inbound", | ||
| "addressPrefixes": [ | ||
| "10.11.0.0/16", | ||
| "10.10.1.0/24" | ||
| ], | ||
| "fullyQualifiedDomainNames": [], | ||
| "subscriptions": [], | ||
| "networkSecurityPerimeters": [] | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "name": "accessRule1", | ||
| "id": "/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1/accessRules/accessRule1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles/accessRules", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "direction": "Inbound", | ||
| "addressPrefixes": [ | ||
| "10.11.0.0/16", | ||
| "10.10.1.0/24" | ||
| ], | ||
| "fullyQualifiedDomainNames": [], | ||
| "subscriptions": [], | ||
| "networkSecurityPerimeters": [] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
14 changes: 14 additions & 0 deletions
14
...e-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "title": "Delete NSP resource association", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "associationName": "association1" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
29 changes: 29 additions & 0 deletions
29
...urce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| { | ||
| "title": "Get NSP resource association", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "associationName": "association1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "association1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/resourceAssociations/association1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/resourceAssociations", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
harics24 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "privateLinkResource": { | ||
| "id": "/subscriptions/{paasSubscriptionId}/resourceGroups/{paasResourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}" | ||
| }, | ||
| "profile": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/{profileName}" | ||
| }, | ||
| "accessMode": "EnforceMode" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
48 changes: 48 additions & 0 deletions
48
...rce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| { | ||
| "title": "List NSP resource associations", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "association1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/resourceAssociations/association1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/resourceAssociations", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateLinkResource": { | ||
| "id": "/subscriptions/{paasSubscriptionId}/resourceGroups/{paasResourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}" | ||
| }, | ||
| "profile": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/{profileName}" | ||
| }, | ||
| "accessMode": "EnforceMode" | ||
| } | ||
| }, | ||
| { | ||
| "name": "association2", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/resourceAssociations/association2", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/resourceAssociations", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateLinkResource": { | ||
| "id": "/subscriptions/{paasSubscriptionId}/resourceGroups/{paasResourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}" | ||
| }, | ||
| "profile": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/{profileName}" | ||
| }, | ||
| "accessMode": "DryRunMode" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/resourceAssociations?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
57 changes: 57 additions & 0 deletions
57
...urce-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspAssociationPut.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
| "title": "Create/Update NSP association", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "associationName": "association1", | ||
| "parameters": { | ||
| "properties": { | ||
| "privateLinkResource": { | ||
| "id": "/subscriptions/{paasSubscriptionId}/resourceGroups/{paasResourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}" | ||
| }, | ||
| "profile": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/{profileName}" | ||
harics24 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }, | ||
| "accessMode": "EnforceMode" | ||
| } | ||
| } | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "association1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/resourceAssociations/association1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/resourceAssociations", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateLinkResource": { | ||
| "id": "/subscriptions/{paasSubscriptionId}/resourceGroups/{paasResourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}" | ||
| }, | ||
| "profile": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/{profileName}" | ||
| }, | ||
| "accessMode": "EnforceMode" | ||
| } | ||
| } | ||
| }, | ||
| "201": { | ||
| "body": { | ||
| "name": "association1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/resourceAssociations/association1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/resourceAssociations", | ||
| "properties": { | ||
| "provisioningState": "Succeeded", | ||
| "privateLinkResource": { | ||
| "id": "/subscriptions/{paasSubscriptionId}/resourceGroups/{paasResourceGroupName}/providers/{providerName}/{resourceType}/{resourceName}" | ||
| }, | ||
| "profile": { | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/{profileName}" | ||
| }, | ||
| "accessMode": "EnforceMode" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
14 changes: 14 additions & 0 deletions
14
...ource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileDelete.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "title": "Delete NSP profile", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1" | ||
| }, | ||
| "responses": { | ||
| "200": {}, | ||
| "204": {} | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
...resource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileGet.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "title": "Get NSP Profile", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1", | ||
| "profileName": "profile1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "name": "nsp1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles", | ||
| "location": "resource location", | ||
harics24 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "properties": { | ||
| "accessRulesVersion": "0" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
36 changes: 36 additions & 0 deletions
36
...esource-manager/Microsoft.Network/preview/2021-02-01-preview/examples/NspProfileList.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "title": "List NSP Profiles", | ||
| "parameters": { | ||
| "api-version": "2021-02-01-preview", | ||
| "subscriptionId": "subId", | ||
| "resourceGroupName": "rg1", | ||
| "networkSecurityPerimeterName": "nsp1" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "name": "profile1", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile1", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles", | ||
| "location": "resource location", | ||
| "properties": { | ||
| "accessRulesVersion": "0" | ||
| } | ||
| }, | ||
| { | ||
| "name": "profile2", | ||
| "id": "/subscriptions/subId/resourceGroups/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles/profile2", | ||
| "type": "Microsoft.Network/networkSecurityPerimeters/profiles", | ||
| "location": "resource location", | ||
| "properties": { | ||
| "accessRulesVersion": "0" | ||
| } | ||
| } | ||
| ], | ||
| "nextLink": "{baseurl}/subscriptions/subId/resourceGroup/rg1/providers/Microsoft.Network/networkSecurityPerimeters/nsp1/profiles?api-version=2021-02-01-preview&$skipToken=10" | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.