Skip to content

Add missing PrivateLink Operations #18030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 11 commits into from
Mar 18, 2022
Merged

Add missing PrivateLink Operations #18030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d159232
fix privateLink client name
tjegbejimba Feb 10, 2022
7f9bd71
Merge branch 'Azure:main' into main
tjegbejimba Feb 16, 2022
94fbeca
Add missing PL operations
tjegbejimba Feb 28, 2022
6a5dccc
Merge branch 'main' of https://github.com/tjegbejimba/azure-rest-api-…
tjegbejimba Feb 28, 2022
ce34580
fix prettier and validation errors
tjegbejimba Feb 28, 2022
ec5249a
wrap PrivateLinkAssociation in properties field
tjegbejimba Mar 10, 2022
e45b40b
match pla put and get response
tjegbejimba Mar 10, 2022
d834b0c
fix getpla example
tjegbejimba Mar 10, 2022
4c7cd8c
add 201 response to PUT requests
tjegbejimba Mar 10, 2022
6fc66b4
add 201 response to PUT examples
tjegbejimba Mar 10, 2022
dddb6b1
Update specification/resources/resource-manager/Microsoft.Authorizati…
tjegbejimba Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions ...manager/Microsoft.Authorization/stable/2020-05-01/examples/GetPrivateLinkAssociation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,21 @@
{
"parameters": {
"plaId": "00000000-0000-0000-0000-000000000000",
"groupId": "my-management-group",
"api-version": "2020-05-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"properties": {
"privateLink": "00000000-0000-0000-0000-000000000000",
"publicNetworkAccess": "Enabled",
"tenantID": "06b3ccb8-1384-4bcc-aec7-852f6d57161b",
"scope": "/providers/Microsoft.Management/managementGroups/my-management-group"
},
"id": "00000000-0000-0000-0000-000000000000",
"type": "Microsoft.Authorization/privateLinkAssociations",
"name": "my-pla"
}
]
"properties": {
"privateLink": "00000000-0000-0000-0000-000000000000",
"publicNetworkAccess": "Enabled",
"tenantID": "06b3ccb8-1384-4bcc-aec7-852f6d57161b",
"scope": "/providers/Microsoft.Management/managementGroups/my-management-group"
},
"id": "00000000-0000-0000-0000-000000000000",
"type": "Microsoft.Authorization/privateLinkAssociations",
"name": "my-pla"
}
}
}
Expand Down
25 changes: 25 additions & 0 deletions ...anager/Microsoft.Authorization/stable/2020-05-01/examples/ListPrivateLinkAssociation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"parameters": {
"groupId": "my-management-group",
"api-version": "2020-05-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"properties": {
"privateLink": "00000000-0000-0000-0000-000000000000",
"publicNetworkAccess": "Enabled",
"tenantID": "06b3ccb8-1384-4bcc-aec7-852f6d57161b",
"scope": "/providers/Microsoft.Management/managementGroups/my-management-group"
},
"id": "00000000-0000-0000-0000-000000000000",
"type": "Microsoft.Authorization/privateLinkAssociations",
"name": "my-pla"
}
]
}
}
}
}
33 changes: 33 additions & 0 deletions ...horization/stable/2020-05-01/examples/ListResourceGroupResourceManagementPrivateLink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
{
"parameters": {
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"resourceGroupName": "my-resource-group",
"api-version": "2020-05-01"
},
"responses": {
"200": {
"body": {
"value": [
{
"properties": {
"privateEndpointConnections": []
},
"id": "00000000-0000-0000-0000-000000000000",
"name": "my-pla",
"type": "Microsoft.Authorization/privateLinkAssociations",
"location": "eastus"
},
{
"properties": {
"privateEndpointConnections": []
},
"id": "00000000-0000-0000-0000-000000000001",
"name": "my-pla2",
"type": "Microsoft.Authorization/privateLinkAssociations",
"location": "eastus"
}
]
}
}
}
}
0 ...es/ListResourceManagementPrivateLink.json → ...riptionResourceManagementPrivateLink.json
View file
Open in desktop
File renamed without changes.
19 changes: 17 additions & 2 deletions ...manager/Microsoft.Authorization/stable/2020-05-01/examples/PutPrivateLinkAssociation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@
"groupId": "my-management-group",
"api-version": "2020-05-01",
"parameters": {
"privateLink": "00000000-0000-0000-0000-000000000000",
"publicNetworkAccess": "Enabled"
"properties": {
"privateLink": "00000000-0000-0000-0000-000000000000",
"publicNetworkAccess": "Enabled"
}
}
},
"responses": {
Expand All @@ -21,6 +23,19 @@
"type": "Microsoft.Authorization/privateLinkAssociations",
"name": "my-pla"
}
},
"201": {
"body": {
"properties": {
"privateLink": "00000000-0000-0000-0000-000000000000",
"publicNetworkAccess": "Enabled",
"tenantID": "06b3ccb8-1384-4bcc-aec7-852f6d57161b",
"scope": "/providers/Microsoft.Management/managementGroups/my-management-group"
},
"id": "00000000-0000-0000-0000-000000000000",
"type": "Microsoft.Authorization/privateLinkAssociations",
"name": "my-pla"
}
}
}
}
11 changes: 11 additions & 0 deletions .../Microsoft.Authorization/stable/2020-05-01/examples/PutResourceManagementPrivateLink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,17 @@
"type": "Microsoft.Authorization/privateLinkAssociations",
"location": "eastus"
}
},
"201": {
"body": {
"properties": {
"privateEndpointConnections": []
},
"id": "00000000-0000-0000-0000-000000000000",
"name": "my-pla",
"type": "Microsoft.Authorization/privateLinkAssociations",
"location": "eastus"
}
}
}
}
119 changes: 111 additions & 8 deletions ...on/resources/resource-manager/Microsoft.Authorization/stable/2020-05-01/privateLinks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/PrivateLinkAssociationProperties"
"$ref": "#/definitions/PrivateLinkAssociationObject"
},
"description": "Parameters supplied to create the private link association."
}
Expand All @@ -68,6 +68,12 @@
"$ref": "#/definitions/PrivateLinkAssociation"
}
},
"201": {
"description": "Created - Returns information about the new private link association.",
"schema": {
"$ref": "#/definitions/PrivateLinkAssociation"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
Expand All @@ -81,6 +87,43 @@
}
}
},
"get": {
"tags": [
"PrivateLinkAssociation"
],
"operationId": "PrivateLinkAssociation_Get",
"description": "Get a single private link association",
"parameters": [
{
"$ref": "#/parameters/ApiVersionParameter"
},
{
"$ref": "#/parameters/GroupIdParameter"
},
{
"$ref": "#/parameters/PrivateLinkAssociationIdParameter"
}
],
"responses": {
"200": {
"description": "Ok. The request has succeeded",
"schema": {
"$ref": "#/definitions/PrivateLinkAssociation"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"Get a single private link association.": {
"$ref": "./examples/GetPrivateLinkAssociation.json"
}
}
},
"delete": {
"tags": [
"PrivateLinkAssociation"
Expand Down Expand Up @@ -124,7 +167,7 @@
"tags": [
"PrivateLinkAssociation"
],
"operationId": "PrivateLinkAssociation_Get",
"operationId": "PrivateLinkAssociation_List",
"description": "Get a private link association for a management group scope",
"parameters": [
{
Expand All @@ -150,7 +193,7 @@
},
"x-ms-examples": {
"Get a private link association for a MG scope.": {
"$ref": "./examples/GetPrivateLinkAssociation.json"
"$ref": "./examples/ListPrivateLinkAssociation.json"
}
}
}
Expand All @@ -171,7 +214,7 @@
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group the template will be deployed to. The name is case insensitive.",
"description": "The name of the resource group. The name is case insensitive.",
"minLength": 1,
"maxLength": 90
},
Expand All @@ -193,7 +236,13 @@
],
"responses": {
"200": {
"description": "OK. The request has succeeded.",
"description": "OK. Returns information about the Resource Management Private Link.",
"schema": {
"$ref": "#/definitions/ResourceManagementPrivateLink"
}
},
"201": {
"description": "Created. Returns information about the Resource Management Private Link.",
"schema": {
"$ref": "#/definitions/ResourceManagementPrivateLink"
}
Expand Down Expand Up @@ -226,7 +275,7 @@
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group the template will be deployed to. The name is case insensitive.",
"description": "The name of the resource group. The name is case insensitive.",
"minLength": 1,
"maxLength": 90
},
Expand Down Expand Up @@ -272,7 +321,7 @@
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group the template will be deployed to. The name is case insensitive.",
"description": "The name of the resource group. The name is case insensitive.",
"minLength": 1,
"maxLength": 90
},
Expand Down Expand Up @@ -335,13 +384,67 @@
},
"x-ms-examples": {
"Delete a Resource Management Private Link.": {
"$ref": "./examples/ListResourceManagementPrivateLink.json"
"$ref": "./examples/ListSubscriptionResourceManagementPrivateLink.json"
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Authorization/resourceManagementPrivateLinks": {
"get": {
"tags": [
"ResourceManagementPrivateLink"
],
"operationId": "ResourceManagementPrivateLink_ListByResourceGroup",
"description": "Get all the resource management private links in a resource group.",
"parameters": [
{
"$ref": "#/parameters/SubscriptionIdParameter"
},
{
"name": "resourceGroupName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the resource group. The name is case insensitive.",
"minLength": 1,
"maxLength": 90
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "Ok - Returns an array of private links.",
"schema": {
"$ref": "#/definitions/ResourceManagementPrivateLinkListResult"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
"x-ms-examples": {
"Delete a Resource Management Private Link.": {
"$ref": "./examples/ListResourceGroupResourceManagementPrivateLink.json"
}
}
}
}
},
"definitions": {
"PrivateLinkAssociationObject": {
"type": "object",
"properties": {
"properties": {
"$ref": "#/definitions/PrivateLinkAssociationProperties",
"description": "The properties of the PrivateLinkAssociation."
}
}
},
"PrivateLinkAssociationProperties": {
"type": "object",
"properties": {
Expand Down