Add xms-ids for RedHatOpenShift by LinglingTong · Pull Request #18012 · Azure/azure-rest-api-specs

LinglingTong · 2022-02-25T21:21:17Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify

About this Change

APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-25T21:21:20Z

Hi, @LinglingTong Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-workflow-bot · 2022-02-25T21:21:21Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-25T21:21:21Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2020-04-30/redhatopenshift.json compared with base:stable/2020-04-30/redhatopenshift.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- redhatopenshift/resource-manager/readme.md tag:package-2020-04-30
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- redhatopenshift/resource-manager/readme.md tag:package-2020-04-30

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L697
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L729
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L738
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L271
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L757
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L765
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.RedHatOpenShift/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L19
`❌` R4037 - MissingTypeObject	The schema 'APIServerProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L403
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L420
`❌` R4037 - MissingTypeObject	The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L429
`❌` R4037 - MissingTypeObject	The schema 'ClusterProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L456
`❌` R4037 - MissingTypeObject	The schema 'ConsoleProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L477
`❌` R4037 - MissingTypeObject	The schema 'Display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L486
`❌` R4037 - MissingTypeObject	The schema 'IngressProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L507
`❌` R4037 - MissingTypeObject	The schema 'MasterProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L524
`❌` R4037 - MissingTypeObject	The schema 'NetworkProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L537
`❌` R4037 - MissingTypeObject	The schema 'OpenShiftCluster' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L550
`❌` R4037 - MissingTypeObject	The schema 'OpenShiftClusterCredentials' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L565
`❌` R4037 - MissingTypeObject	The schema 'OpenShiftClusterList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L578
`❌` R4037 - MissingTypeObject	The schema 'OpenShiftClusterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L594
`❌` R4037 - MissingTypeObject	The schema 'OpenShiftClusterUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L647
`❌` R4037 - MissingTypeObject	The schema 'Operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L661
`❌` R4037 - MissingTypeObject	The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L678
`❌` R4037 - MissingTypeObject	The schema 'ServicePrincipalProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L709
`❌` R4037 - MissingTypeObject	The schema 'WorkerProfile' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L746
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Creates or updates a OpenShift cluster with the specified subscription, resource group and resource name. Location: Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json#L347

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

redhatopenshift/resource-manager/readme.md#package-2020-04-30

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-25T21:21:22Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armredhatopenshift - 0.3.0

+	Function `CloudErrorBody.MarshalJSON` has been removed
+	Struct `CloudErrorBody` has been removed
+	Struct `CloudError` has been removed

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-redhatopenshift - 1.0.0
️✔️azure-sdk-for-go - redhatopenshift/mgmt/2020-04-30/redhatopenshift - v61.6.0
️✔️azure-sdk-for-go - preview/mgmt/2021-09-01-preview/redhatopenshift - v61.6.0

️❌ azure-sdk-for-python failed [Detail]

❌Failed [Logs]Release - Generate from b0a0fcc. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh]   ERROR: Command errored out with exit status 1:
cmderr	[automation_init.sh]    command: /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-dfiw0stt/markupsafe_a7a52b565ebb46b4ae5af3ee2c743896/setup.py'"'"'; __file__='"'"'/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-dfiw0stt/markupsafe_a7a52b565ebb46b4ae5af3ee2c743896/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-pip-egg-info-pib_izhk
cmderr	[automation_init.sh]        cwd: /home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-dfiw0stt/markupsafe_a7a52b565ebb46b4ae5af3ee2c743896/
cmderr	[automation_init.sh]   Complete output (30 lines):
cmderr	[automation_init.sh]   Traceback (most recent call last):
cmderr	[automation_init.sh]     File "<string>", line 1, in <module>
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-dfiw0stt/markupsafe_a7a52b565ebb46b4ae5af3ee2c743896/setup.py", line 65, in <module>
cmderr	[automation_init.sh]       run_setup(True)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-dfiw0stt/markupsafe_a7a52b565ebb46b4ae5af3ee2c743896/setup.py", line 44, in run_setup
cmderr	[automation_init.sh]       ext_modules=ext_modules if with_binary else [],
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/__init__.py", line 129, in setup
cmderr	[automation_init.sh]       return distutils.core.setup(**attrs)
cmderr	[automation_init.sh]     File "/usr/lib/python3.6/distutils/core.py", line 121, in setup
cmderr	[automation_init.sh]       dist.parse_config_files()
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/dist.py", line 494, in parse_config_files
cmderr	[automation_init.sh]       ignore_option_errors=ignore_option_errors)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 106, in parse_configuration
cmderr	[automation_init.sh]       meta.parse()
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 382, in parse
cmderr	[automation_init.sh]       section_parser_method(section_options)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 355, in parse_section
cmderr	[automation_init.sh]       self[name] = value
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 173, in __setitem__
cmderr	[automation_init.sh]       value = parser(value)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 430, in _parse_version
cmderr	[automation_init.sh]       version = self._parse_attr(value)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 305, in _parse_attr
cmderr	[automation_init.sh]       module = import_module(module_name)
cmderr	[automation_init.sh]     File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
cmderr	[automation_init.sh]       return _bootstrap._gcd_import(name[level:], package, level)
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 994, in _gcd_import
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 971, in _find_and_load
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
cmderr	[automation_init.sh]   ModuleNotFoundError: No module named 'markupsafe'
cmderr	[automation_init.sh]   ----------------------------------------
cmderr	[automation_init.sh] WARNING: Discarding https://files.pythonhosted.org/packages/62/0f/52c009332fdadd484e898dc8f2acca0663c1031b3517070fd34ad9c1b64e/MarkupSafe-2.1.0.tar.gz#sha256=80beaf63ddfbc64a0452b841d8036ca0611e049650e20afcb882f5d3c266d65f (from https://pypi.org/simple/markupsafe/) (requires-python:>=3.7). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.3 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.8.0 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/redhatopenshift/resource-manager/Microsoft.RedHatOpenShift/stable/2020-04-30/redhatopenshift.json:444:8 ($.definitions.CloudErrorBody.properties.details)
cmdout	[automation_generate.sh] [Autorest] FATAL: swagger-document/individual/schema-validator - FAILED
cmdout	[automation_generate.sh] [Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
cmdout	[automation_generate.sh] [Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
cmdout	[automation_generate.sh] [Autorest] Failure during batch task - {"tag":"package-2020-04-30"} -- false.
cmdout	[automation_generate.sh] [Autorest]/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from b0a0fcc. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.4` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-redhatopenshift [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation OpenShiftClustersOperations.list_admin_credentials
info	[Changelog]   - Model MasterProfile has a new parameter disk_encryption_set_id
info	[Changelog]   - Model MasterProfile has a new parameter encryption_at_host
info	[Changelog]   - Model NetworkProfile has a new parameter software_defined_network
info	[Changelog]   - Model OpenShiftCluster has a new parameter system_data
info	[Changelog]   - Model OpenShiftClusterUpdate has a new parameter system_data
info	[Changelog]   - Model WorkerProfile has a new parameter disk_encryption_set_id
info	[Changelog]   - Model WorkerProfile has a new parameter encryption_at_host

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b0a0fcc. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️redhatopenshift/mgmt/2020-04-30/redhatopenshift [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/mgmt/2021-09-01-preview/redhatopenshift [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from b0a0fcc. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armredhatopenshift [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `CloudErrorBody.MarshalJSON` has been removed
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog] - Struct `CloudErrorBody` has been removed
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 0 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from b0a0fcc. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️redhatopenshift [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

LinglingTong · 2022-02-25T21:23:31Z

@sakthi-vetrivel I see you contributed to RedHatOpenShift earlier. If you are on the RedHatOpenShift team, could you help me with a code review? Thanks!

ghost · 2022-03-13T16:01:59Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-03-13T16:33:17Z

@leni-msft there are only a few lines change in this PR and all the xms-ids are intuitive. I wonder if you could help with reviewing the code and merging the changes.

add xms-ids for RedHatOpenShift

6955b3d

openapi-assignment-bot bot assigned leniatgh Feb 25, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Feb 25, 2022

openapi-sdkautomation bot mentioned this pull request Feb 25, 2022

[AutoPR track2_azure-mgmt-redhatopenshift] Add xms-ids for RedHatOpenShift AzureSDKAutomation/azure-sdk-for-python#9350

Closed

ghost added the no-recent-activity label Mar 13, 2022

ghost removed the no-recent-activity label Mar 13, 2022

leniatgh approved these changes Mar 14, 2022

View reviewed changes

leniatgh merged commit b0a0fcc into Azure:main Mar 14, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022

add xms-ids for RedHatOpenShift (Azure#18012)

32a1570

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add xms-ids for RedHatOpenShift#18012

Add xms-ids for RedHatOpenShift#18012
leniatgh merged 1 commit intoAzure:mainfrom
LinglingTong:dev/ltong/xmsid_redhatopenshift

LinglingTong commented Feb 25, 2022

Uh oh!

openapi-workflow-bot bot commented Feb 25, 2022

Uh oh!

openapi-workflow-bot bot commented Feb 25, 2022

Uh oh!

openapi-pipeline-app bot commented Feb 25, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Feb 25, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

LinglingTong commented Feb 25, 2022

Uh oh!

ghost commented Mar 13, 2022

Uh oh!

LinglingTong commented Mar 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LinglingTong commented Feb 25, 2022

Changelog

About this Change

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Feb 25, 2022

Uh oh!

openapi-workflow-bot bot commented Feb 25, 2022

Uh oh!

openapi-pipeline-app bot commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Feb 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

LinglingTong commented Feb 25, 2022

Uh oh!

ghost commented Mar 13, 2022

Uh oh!

LinglingTong commented Mar 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openapi-pipeline-app bot commented Feb 25, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 25, 2022 •

edited

Loading