Skip to content

Release Microsoft.sql 2021 11 01 preview#18005

Merged
raych1 merged 12 commits intoAzure:dev-sql-Microsoft.Sql-2021-11-01-previewfrom
ericshape:dev-sql-Microsoft.Sql-2021-11-01-preview
Mar 28, 2022
Merged

Release Microsoft.sql 2021 11 01 preview#18005
raych1 merged 12 commits intoAzure:dev-sql-Microsoft.Sql-2021-11-01-previewfrom
ericshape:dev-sql-Microsoft.Sql-2021-11-01-preview

Conversation

@ericshape
Copy link
Copy Markdown
Member

@ericshape ericshape commented Feb 25, 2022 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

  1. Most of the diffs are not real changes, only changing the order: in our script, we started to sort the content in the auto-generated manifest file
  2. We ignore MISSING_APIS_IN_DEFAULT_TAG
  3. We ignore ❌ R4009 - RequiredReadOnlySystemData because SQL does not fully support SystemData property. This exception has been approved by ARM in 2021.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
    Release Microsoft.sql 2021 11 01 preview #18005 (comment)
    We remove the legacy "ReplicaitonLinks_unlink" API. It is a redundant and dummy API; no user uses it.

  • Removing properties in a stable version

  • Removing API version(s) in a stable version

  • Updating API in a stable or public preview version with Breaking Change Validation errors

  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

openapi-workflow-bot Bot commented Feb 25, 2022

Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot Bot commented Feb 25, 2022

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Feb 25, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️❌LintDiff: 174 Errors, 8 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:

    Only 1 items are listed, please refer to log for more details.

    Rule Message
    ❌ R4009 - RequiredReadOnlySystemData The response of operation:'BackupShortTermRetentionPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Sql/preview/2021-11-01-preview/BackupShortTermRetentionPolicies.json#L65


    The following errors/warnings exist before current PR submission:

    Only 1 items are listed, please refer to log for more details.

    Rule Message
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.Sql/preview/2021-11-01-preview/LocationCapabilities.json#L1229
    ️❌Avocado: 2 Errors, 1 Warnings failed [Detail]

    Only 1 items are listed, please refer to log for more details.

    Rule Message
    ❌ UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
    readme: specification/sql/resource-manager/readme.md
    json: Microsoft.Sql/stable/2014-04-01-legacy/replicationLinks_legacy.json
    ️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]

    Only 1 items are listed, please refer to log for more details.

    Rule Message
    ❌ XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in ReplicationLinks_Delete.
    Url: Microsoft.Sql/stable/2014-04-01-legacy/replicationLinks_legacy.json#L20:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️SDK Track2 Validation succeeded [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ❌ "readme":"sql/resource-manager/readme.md",
    "tag":"package-preview-2021-11",
    "details":"Error: Plugin checker reported failure."
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the SQL label Feb 25, 2022
    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented Feb 25, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot Bot commented Feb 25, 2022

    Hi @ericshape, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-sdkautomation openapi-sdkautomation Bot mentioned this pull request Feb 25, 2022
    Draft
    This was referenced Feb 25, 2022
    Draft
    Draft
    Draft
    This was referenced Feb 25, 2022
    Draft
    Draft
    @openapi-workflow-bot
    Copy link
    Copy Markdown

    openapi-workflow-bot Bot commented Feb 28, 2022

    Hi @ericshape, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @ericshape
    Copy link
    Copy Markdown
    Member Author

    ericshape commented Mar 1, 2022

    SQL does not support systemData until now. The feature will be completed TBD.
    ❌ R4009 - RequiredReadOnlySystemData

    @ericshape
    Copy link
    Copy Markdown
    Member Author

    ericshape commented Mar 5, 2022 •
    edited
    Loading 

        "hubDatabasePassword": {

    Can you annotate it with x-ms-secret?

    https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret

    Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2021-11-01-preview/SyncGroups.json:947 in b3060af. [](commit_id = b3060af, deletion_comment = False)

    @j5lim addressed your x-ms-secret comments in 7d092f0
    In addition, can we address these SECRET_PROPERTY in the next API version, it will be released in May 2022.
    We have features release in Mid-March for the current API version: 2021-11-01; but fixing the Secret_Property in https://github.com/Azure/azure-rest-api-specs/pull/18005/checks?check_run_id=5431250878 needs deep refactor with SQL feature teams. Can we get exception for this API version?

    @j5lim
    Copy link
    Copy Markdown
    Contributor

    j5lim commented Mar 7, 2022 

        "hubDatabasePassword": {

    Can you annotate it with x-ms-secret?
    https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret
    Refers to: specification/sql/resource-manager/Microsoft.Sql/preview/2021-11-01-preview/SyncGroups.json:947 in b3060af. [](commit_id = b3060af, deletion_comment = False)

    @j5lim addressed your x-ms-secret comments in 7d092f0 In addition, can we address these SECRET_PROPERTY in the next API version, it will be released in May 2022. We have features release in Mid-March for the current API version: 2021-11-01; but fixing the Secret_Property in https://github.com/Azure/azure-rest-api-specs/pull/18005/checks?check_run_id=5431250878 needs deep refactor with SQL feature teams. Can we get exception for this API version?

    Yes, you can address those in the next api version.

    j5lim
    j5lim approved these changes Mar 7, 2022
    View reviewed changes
    Copy link
    Copy Markdown
    Contributor

    @j5lim j5lim left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Approved with suggestions.

    @j5lim j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMChangesRequested labels Mar 7, 2022
    @raych1
    Copy link
    Copy Markdown
    Member

    raych1 commented Mar 11, 2022

    @ericshape , can you resolve conflicts?

    @ericshape
    Copy link
    Copy Markdown
    Member Author

    ericshape commented Mar 16, 2022

    /azp run

    @ericshape
    Copy link
    Copy Markdown
    Member Author

    ericshape commented Mar 16, 2022 •
    edited
    Loading

    @raych1 do you know why the pipeline is not triggered after I submit a rebase commit?

    @ericshape ericshape changed the title Carry minor changes for microsoft.sql 2021 11 01 preview Release Microsoft.sql 2021 11 01 preview Mar 16, 2022
    @azure-pipelines
    Copy link
    Copy Markdown

    azure-pipelines Bot commented Mar 16, 2022

    Comment was made before the most recent commit for PR 18005 in repo Azure/azure-rest-api-specs

    @ericshape
    Copy link
    Copy Markdown
    Member Author

    ericshape commented Mar 28, 2022 •
    edited
    Loading

    we ignore these errors due to the existing legacy specs and example files cannot be deleted.

    Rule Message
    ❌ UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.readme: specification/sql/resource-manager/readme.mdjson: stable/2014-04-01-legacy/examples/ReplicationLinkDelete.json
    ❌ UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.readme: specification/sql/resource-manager/readme.mdjson: stable/2014-04-01-legacy/examples/ReplicationLinkFailover.json
    ❌ UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.readme: specification/sql/resource-manager/readme.mdjson: stable/2014-04-01-legacy/examples/ReplicationLinkUnlink.json
    ❌ UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.readme: specification/sql/resource-manager/readme.mdjson: Microsoft.Sql/stable/2014-04-01-legacy/replicationLinks_legacy.json
    ❌ MISSING_APIS_IN_DEFAULT_TAG The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag.readme: specification/sql/resource-manager/readme.mdjson: Microsoft.Sql/stable/2014-04-01-legacy/replicationLinks_legacy.json

    @raych1 raych1 merged commit d07d484 into Azure:dev-sql-Microsoft.Sql-2021-11-01-preview Mar 28, 2022
    raych1 pushed a commit that referenced this pull request Mar 29, 2022
    @ericshape @zhenglaizhang
    @msdogra @srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996
    Rebase Microsoft.SQL in Main Branch (#18428)
    bbf6b22 
    * Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (#17143)

* Updated Blob Auditing API Files (#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>

* Adding swagger for endpoint certificates (#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a.

* Revert "error 201"

This reverts commit 759fa4f.

* Fixed bad reverts

Co-authored-by: Ji Wang <wangjiprc@gmail.com>

* Add 201 response example so SQL clients can work correctly (#18121)

* Add examples for cross sub restore (#18135)

* Release Microsoft.sql 2021 11 01 preview (#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (#17143)

* Updated Blob Auditing API Files (#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>

* Adding swagger for endpoint certificates (#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: msdogra <msdogra@hotmail.com>
Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>
Co-authored-by: srmarkov <88828188+srmarkov@users.noreply.github.com>
Co-authored-by: Uriel Cohen <urielc@microsoft.com>
Co-authored-by: Marko Nikolic <96062747+markonikolicmicrosoft@users.noreply.github.com>
Co-authored-by: Andrija Cicovic <100755783+cicovic-andrija-msft@users.noreply.github.com>
Co-authored-by: Ishan Rajesh Madan <99760799+imadan1996@users.noreply.github.com>
    visingl pushed a commit that referenced this pull request Mar 30, 2022
    @ericshape @zhenglaizhang
    @msdogra @srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996 @visingl
    Rebase Microsoft.SQL in Main Branch (#18428)
    c4f919c 
    * Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (#17143)

* Updated Blob Auditing API Files (#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>

* Adding swagger for endpoint certificates (#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a.

* Revert "error 201"

This reverts commit 759fa4f.

* Fixed bad reverts

Co-authored-by: Ji Wang <wangjiprc@gmail.com>

* Add 201 response example so SQL clients can work correctly (#18121)

* Add examples for cross sub restore (#18135)

* Release Microsoft.sql 2021 11 01 preview (#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (#17143)

* Updated Blob Auditing API Files (#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>

* Adding swagger for endpoint certificates (#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: msdogra <msdogra@hotmail.com>
Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>
Co-authored-by: srmarkov <88828188+srmarkov@users.noreply.github.com>
Co-authored-by: Uriel Cohen <urielc@microsoft.com>
Co-authored-by: Marko Nikolic <96062747+markonikolicmicrosoft@users.noreply.github.com>
Co-authored-by: Andrija Cicovic <100755783+cicovic-andrija-msft@users.noreply.github.com>
Co-authored-by: Ishan Rajesh Madan <99760799+imadan1996@users.noreply.github.com>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    @ericshape @zhenglaizhang
    @msdogra @srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996 @FredericHeem
    Rebase Microsoft.SQL in Main Branch (Azure#18428)
    47a0dfe 
    * Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (Azure#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a.

* Revert "error 201"

This reverts commit 759fa4f.

* Fixed bad reverts

Co-authored-by: Ji Wang <wangjiprc@gmail.com>

* Add 201 response example so SQL clients can work correctly (Azure#18121)

* Add examples for cross sub restore (Azure#18135)

* Release Microsoft.sql 2021 11 01 preview (Azure#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <darinzh@microsoft.com>
Co-authored-by: msdogra <msdogra@hotmail.com>
Co-authored-by: Mukesh Dogra <mdogra@microsoft.com>
Co-authored-by: srmarkov <88828188+srmarkov@users.noreply.github.com>
Co-authored-by: Uriel Cohen <urielc@microsoft.com>
Co-authored-by: Marko Nikolic <96062747+markonikolicmicrosoft@users.noreply.github.com>
Co-authored-by: Andrija Cicovic <100755783+cicovic-andrija-msft@users.noreply.github.com>
Co-authored-by: Ishan Rajesh Madan <99760799+imadan1996@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @raych1 raych1 raych1 approved these changes

    @j5lim j5lim j5lim approved these changes

    @jamestao jamestao Awaiting requested review from jamestao

    Assignees

    @raych1 raych1

    Labels

    Approved-Avocado Approved-LintDiff Approved-ModelValidation ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-FixRequiredOnFailure SQL

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @ericshape @j5lim @raych1