Datr/05 13 fixes #17976
Closed
Datr/05 13 fixes #17976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update azure-pipelines.yml * Update ShouldSendPRToMain.yml * Update BranchProtectionForPrivateRepo.yml
* copy 2021-06-01 API * replace "2021-06-01" with "2021-12-01" * add 2021-12-01 changes * update readme * add go * add java * fix go
…e. (Azure#16395) * Adds base for updating Microsoft.Network from version stable/2021-03-01 to version 2021-05-01 * Updates readme * Updates API version in new specs and examples * Add routing intent resource to 05-01 (Azure#15998) * add routing intent resource to 05-01 * prettier fix * fix api version in examples * Update Exclusion Match Variable enum to support new values (Azure#16124) * Adding new SKU values (Azure#16112) * Adding new SKU values * Fixing basic in Tier(not name) Co-authored-by: Ishani Gupta <[email protected]> * Update WAF Policy Exclusions to include RuleSet/RuleGroup/Rule hierarchy (Azure#16154) * VNet Encryption: Add nic flag, vnet property, vnet peering property (Azure#16224) * vnet encryption change * change api version * fix prettier check * add type object for encryption * remove circle (Azure#16307) Co-authored-by: Weiheng Li <[email protected]> * move to new branch (Azure#16194) * Missed property added to LoadBalancerBackendAddress and new API (Azure#16334) * Updated load balancer swagger with missing backendAddress property and queryInboundNatRulePortMapping API * Fixed example for QueryInboundNatRulePortMapping API * Fixed warnings * Revert "Fixed warnings" This reverts commit e3e4cac. * Revert "Fixed example for QueryInboundNatRulePortMapping API" This reverts commit 5823b77. * Revert "Updated load balancer swagger with missing backendAddress property and queryInboundNatRulePortMapping API" This reverts commit e3f5bb3. * Put changes into correct API version * Fixed lint diff errors * Fixes based on CR * Fixes based on CR * Fixed warnings * Fixed example * prettier * Fixed spelling * initial PR to the new release branch (Azure#15842) * initial PR to the new release branch * moved body to end of request parameters, changed api version number in examples * Added action name for the list idps filter values * changed to match camel casing for the action added * fixed CR issues * fixing auto checks * fixed ARM cr issues * fixing the resource type to match specification * Isgu/fix/new branch SKU (Azure#16410) * changes in 05 branch * Revert "Adding new SKU values (Azure#16112)" This reverts commit bdf897a. Co-authored-by: Ishani Gupta <[email protected]> Co-authored-by: Ritvika Reddy Nagula <[email protected]> Co-authored-by: tejasshah7 <[email protected]> Co-authored-by: Ishani Gupta <[email protected]> Co-authored-by: Ishani Gupta <[email protected]> Co-authored-by: dtuCloud <[email protected]> Co-authored-by: Weiheng Li <[email protected]> Co-authored-by: Weiheng Li <[email protected]> Co-authored-by: Henry Chen <[email protected]> Co-authored-by: irrogozh <[email protected]> Co-authored-by: amosarbiv-work <[email protected]>
For AddConnectionToGroup and AddUserToGorup, if connection does not exist, or user does not exist, 404 should be considered as error response.
Co-authored-by: Alex Goldschmidt <[email protected]>
…zure#16384) * Add Microsoft.ResourceConnector [Appliance] 2021-10-31-preview API * Run prettier on violation files * Add SCVMM to custom-words.txt * Fix validation issues * Fix prettier issue with AppliancesListClusterUserCredential.json * Add multi API section for go readme and update namespace for python readme * Update Example files to be more accurate * Add None to Managed Identity typ in parity with other Azure Arc Resources * Add default value as AKSEdge for distro * Adding type object for ApplianceListResult * Update Identity to use SystemAssignedServiceIdentity from common-types v3 managedidentity.json * Reverting to using custom Identity * Update readme.md * Update readme.python.md Co-authored-by: Anirban Thakur <[email protected]> Co-authored-by: Yiming Lei <[email protected]>
* Create Sample Directory Structure for Swagger * Delete Sample Directory Structure for Swagger * Create Sample Directory Structure for Swagger * Update Getting started with OpenAPI specifications.md * Delete Sample Directory Structure for Swagger will reuse this wiki https://github.com/Azure/azure-rest-api-specs/wiki#directory-structure, instead of creating a new one. * Update Getting started with OpenAPI specifications.md reuse this wiki for sample directory https://github.com/Azure/azure-rest-api-specs/wiki#directory-structure
…ure#16433) * Rename 'whitelist' * add missing 'Group' in renamed file * add mdeOnboarding API - 2021-10-01-preview * fix json format * fix PR issues * add List operation * change to plural, set default resource type name * mismatch between GET and LIST examples * made descriptions clearer, removed unused parameter * defined explicit parameters * delete unused schema Co-authored-by: Erel Hansav <[email protected]>
…stable/2021-10-14 (Azure#16417) * Adds base for updating Microsoft.Insights from version preview/2020-06-02-preview to version 2021-10-14 * Updates readme * Updates API version in new specs and examples * Fixing a relative path * Pascal casing for the resource provider name * Attempt at fixing R4018
* swagger fix * 2016 patch Co-authored-by: Jimmy Xie <[email protected]>
…on preview/2021-09-01-preview (Azure#16468) * Add dump API * add new line at the end of line * change cases * typo * response * add api for start/stop azure spring cloud instance * fix lint error Co-authored-by: Yinglue Zhang <[email protected]> Co-authored-by: caiqing <[email protected]> Co-authored-by: YinglueZhang-MS <[email protected]>
…e#16405) * Kusto: Swagger readonly cosmetics changes * supress * prettier * fix 2017-09-07-privatepreview examples * fix 2018-09-07-preview model * 1 * 1
…entSnapshot data types (Azure#16489) * Add SubAssessment event source type and add more automations examples * Change Location isReadOnlu to false * Test * Add new read/write location and add new type TrackedResourceLocation * Minor * minor * prettier fixes * Change variable name to TrackedResourceLocation * Change type name TrackedResourceLocation to AzureTrackedResourceLocation * Update automations example * Add SecureScores & SecureScoreControls as new supported datatypes in Automations resource * [ASC.Automations] add new data type RegulatoryComplianceAssessment * Add Secure Scores and Regulatory Compliance snapshot data types * Changes * minor fix * syntax fixes * [Microsoft.Security/Automations] Add AssessmentsSnapshot & SubAssessmentSnapshot data types * minor * minor * minor * minor
…y-2021-07-01' (Azure#16435) * Adds base for updating Microsoft.Security from version preview/2021-05-01-preview to version 2021-07-01 * Updates readme * Updates API version in new specs and examples * Adding securityConnectors private API * Update the readme.md * adding custom word * Update Security Connector model in examples * Update main security connectors model with new organizational data properties, update examples as well. * added new offerings * fix pathing * fix offering name in all examples * add docs for patch endpoint * add system data resource * Remove duplication * Resolve tools issues * Change bool to boolean * Fix model validation errors * Fix lint error * CR fixes. Move systemData to root of object. Export identity type to definition * remove extra bracket * fix bracketing and pathing * lint fixes * fix camel case for linting * Fix systemData examples Co-authored-by: Sapir Elmakayes <[email protected]> Co-authored-by: Sapir Elmakayes <[email protected]>
…n preview/1.0 (Azure#16128) * Modified method GetTrafficFlowSegment to remove the Result type and return the data type directly * Revert "Modified method GetTrafficFlowSegment to remove the Result type and return the data type directly" This reverts commit 46bc557. * Flattening and renaming of several components within Traffic Segment Flow * Flattened the client for Traffic Incident Detail * More changes in flattening, now for TrafficIncident and Detail * More changes in flattening, now for TrafficIncident and Detail * More feedback addressed * prettier fixes * Clarified doc string * Added start and end time for Traffic incident * Added friendly names for x-ms-examples * Fixed avocado bugs, added query parameter as number array * Added collectionFormat to all comma separated parameters * Small changes to improve codegen * Prettier fixes * Fixed all comments from latest PR review Co-authored-by: Daniel Rocha <[email protected]>
* saving progress * fixing typos * fixing typos * fixing typo * running prettier * small comment change * minor fixes * minor fix * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * saving progress * moving shortcodes files to its own folder * saving progress * adding basic readme file * Changing message details to support adding examples for contenttypes, adding estimatedRampUpTime and directionality * adding format for urls, emails and phone numbers * renames on different fields * adding back helpMessage and optOutMessage * removing tel format
* fix missing accesslevel field in requestResponse * fix another s360 issue * fix fields in example files as well * update custom words
…n stable/2021-10-15 (Azure#15733) * Adds base for updating Microsoft.DocumentDB from version stable/2021-06-15 to version 2021-09-15 * Updates readme * Updates API version in new specs and examples * Add support for fetching continuous backup information for latest restorable timestamp. * Adding locations API and backupRedundancy * Fixing ref * Add 10-15 Preview along with ClientEncryptionKey management changes * Renaming 2021-09-15 api version to 2021-10-15 * Fixing some more renames * fix validation checks * add clientencryptionkeys to custom-words * initial commit * Swagger specifiations * readme file updated * Review comments addressed * Added TotalThroughputLimit property to Database Create and Update * Rebased and added type to capacity * Added changes to preview folder as well * Added changes to missing files * initial checkin of base version * Adding examples; /deallocate and /start api in swagger * update readme.md file * Removing 2021-10-15-preview changes * managed cassandra swagger changes for GA * Fixing linter issues * minor description fixes * adding missing example * add stable and preview swagger * revert to Thu Sep 9 2021 change * fix linter errors in swagger * fix validation errors * validation fixes * remove fetchNodeStatus from stable * remove unused example file, fix validation error * Fixing the spell check and formatting issues * remove /repair api, make /command async * remove unreferrenced example json * remove pageable link from /status api * remove backups api, add cassandraAuditLoggingEnabled property * add cassandraAuditLoggingEnabled property * make /status api async, minor fixes * remove async tag to /status * remove connectivity property, add Ldap as preview * remove unreferenced example files * use guid in subid for examples * add backupStorageCustomerKeyUri property * fix api response code * remove ldap * Changing operationId for locations API * review comments Co-authored-by: REDMOND\amisi <[email protected]> Co-authored-by: Anuj Toshniwal <[email protected]> Co-authored-by: Abhijit Karanjkar <[email protected]> Co-authored-by: Praful Johari <[email protected]> Co-authored-by: visunda <[email protected]> Co-authored-by: Vivek Sundararajan <[email protected]> Co-authored-by: vivek-microsoft <[email protected]>
* init * remove * Add 2021-10-01 * Minor update
…fields and new controller path. (Azure#16463) * Initially cut, cloned from know existing GA bits (IE \specification\monitor\resource-manager\Microsoft.Insights\stable\2015-04-01) * rev API version, add new controller API path, and update JSON showing newly added predictiveAutoscalePolicy field
* Fix LimitObject polymorphism * move properties out of allOf * add type to LimitObject * value is required * Updating Operations Tag to QuotaOperations. * Update quota.json Updating Summary field for operations. Co-authored-by: Rahul Singh <[email protected]>
* resloving s360 itme * added prettier-fix changes Co-authored-by: Gaurav Bang <[email protected]>
Co-authored-by: Xuyang Cao <[email protected]>
This was referenced Feb 24, 2022
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
Draft
|
Hi, @datr93. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @datr93. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.