Cancel pipeline run api by milantomic6 · Pull Request #1782 · Azure/azure-rest-api-specs

milantomic6 · 2017-10-02T23:50:35Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkciprbot · 2017-10-02T23:53:28Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

bgold09 · 2017-10-03T17:17:16Z

...ation/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/datafactory.json

+            "$ref": "./examples/Factories_CancelPipelineRun.json"
+          }
+        },
+        "description": "Cancel pipeline run by its run ID.",


"Cancel a pipeline run..."

bgold09 · 2017-10-03T17:17:50Z

...ation/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/datafactory.json

+            "$ref": "#/parameters/api-version"
+          }
+        ],
+        "responses": {


What happens if the pipeline run has already finished?

If pipeline run is in terminal state we return bad request.

bgold09 · 2017-10-03T17:18:59Z

...ation/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/datafactory.json

+          }
+        ],
+        "responses": {
+          "200": {


When the user gets an OK response, does that mean the run has been cancelled? Or does it mean that we've started the process of cancelling it?

Ok means it is fully cancelled.

@milantomic6 could you add to description.

sergey-shandar

Please, address comments from @bgold09

sergey-shandar · 2017-10-03T19:54:27Z

...ation/datafactory/resource-manager/Microsoft.DataFactory/2017-09-01-preview/datafactory.json

+          }
+        ],
+        "responses": {
+          "200": {


@milantomic6 could you add to description.

azuresdkciprbot · 2017-10-03T20:15:34Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2017-10-03T20:37:59Z

No modification for AutorestCI/azure-sdk-for-ruby

AutorestCI · 2017-10-03T20:38:02Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-10-03T20:54:27Z

Azure/azure-sdk-for-python#1502

AutorestCI · 2017-10-03T21:06:03Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-10-03T21:14:50Z

No modification for AutorestCI/azure-sdk-for-ruby

AutorestCI · 2017-10-03T21:52:14Z

No modification for AutorestCI/azure-sdk-for-node

Cancel pipeline run api

20e3e1f

azuresdkci assigned sergey-shandar Oct 3, 2017

bgold09 reviewed Oct 3, 2017

View reviewed changes

sergey-shandar suggested changes Oct 3, 2017

View reviewed changes

CR issues

7ed6255

sergey-shandar approved these changes Oct 3, 2017

View reviewed changes

sergey-shandar merged commit cb55c3e into Azure:current Oct 3, 2017

AutorestCI mentioned this pull request Oct 3, 2017

[DataFactoryMgmt] Cancel pipeline run api Azure/azure-sdk-for-python#1502

Merged

milantomic6 mentioned this pull request Oct 5, 2017

Cancel pipeline run API Azure/azure-sdk-for-net#3757

Closed

5 tasks

milantomic6 mentioned this pull request Oct 25, 2017

Cancel pipeline run Azure/azure-sdk-for-net#3812

Merged

8 tasks

Conversation

milantomic6 commented Oct 2, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Oct 2, 2017

Uh oh!

bgold09 Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

bgold09 Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

milantomic6 Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

bgold09 Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

milantomic6 Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

sergey-shandar Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

sergey-shandar Oct 3, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Oct 3, 2017

Uh oh!

AutorestCI commented Oct 3, 2017

Uh oh!

AutorestCI commented Oct 3, 2017

Uh oh!

AutorestCI commented Oct 3, 2017

Uh oh!

AutorestCI commented Oct 3, 2017

Uh oh!

AutorestCI commented Oct 3, 2017

Uh oh!

AutorestCI commented Oct 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

milantomic6 commented Oct 2, 2017 •

edited by azuresdkci

Loading