Add x-ms-identifiers to storagecache/resource-manager. by vukelich · Pull Request #17785 · Azure/azure-rest-api-specs

vukelich · 2022-02-10T21:14:30Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify:

EXPLANATION OF THIS CHANGE
APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-10T21:14:33Z

Hi, @vukelich Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com

openapi-workflow-bot · 2022-02-10T21:14:34Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-10T21:14:34Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-09-01/storagecache.json compared with base:stable/2021-09-01/storagecache.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- storagecache/resource-manager/readme.md tag:package-2021-09
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- storagecache/resource-manager/readme.md tag:package-2021-09

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'StorageTargetModel'. Consider using the plural form of 'StorageTarget' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1055
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'StorageTargetModel'. Consider using the plural form of 'StorageTarget' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1110
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'StorageTargetModel'. Consider using the plural form of 'StorageTarget' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1165
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1251
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: rotationToLatestKeyVersionEnabled Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1641
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: extendedGroups Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1747
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: encryptLdapConnection Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1782
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireValidCertificate Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1786
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoDownloadCertificate Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1790
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: suid Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1885
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: submountAccess Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1889
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: rootSquash Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L1893
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L2557
⚠️ R4030 - UniqueXmsExample	Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: StorageTargets_List Location: Microsoft.StorageCache/stable/2021-09-01/storagecache.json#L810

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

storagecache/resource-manager/readme.md#package-2021-09

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-10T21:14:35Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-storagecache - 1.1.0
️✔️azure-sdk-for-go - storagecache/mgmt/2021-09-01/storagecache - v61.4.0
️✔️azure-sdk-for-go - storagecache/mgmt/2021-05-01/storagecache - v61.4.0
️✔️azure-sdk-for-go - storagecache/mgmt/2021-03-01/storagecache - v61.4.0
️✔️azure-sdk-for-go - storagecache/mgmt/2020-10-01/storagecache - v61.4.0
❌azure-sdk-for-go - storagecache/mgmt/2020-03-01/storagecache - v61.4.0

+	Function `CachesClient.DeleteResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
+	Function `CachesClient.FlushResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
+	Function `CachesClient.StartResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
+	Function `CachesClient.StopResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
+	Function `CachesClient.UpgradeFirmwareResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
+	Function `StorageTargetsClient.DeleteResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
+	Struct `SetObject` has been removed
+	Type of `CachesDeleteFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
+	Type of `CachesFlushFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
+	Type of `CachesStartFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
+	Type of `CachesStopFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
+	Type of `CachesUpgradeFirmwareFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
+	Type of `StorageTargetsDeleteFuture.Result` has been changed from `func(StorageTargetsClient) (SetObject, error)` to `func(StorageTargetsClient) (autorest.Response, error)`

️✔️azure-sdk-for-go - storagecache/mgmt/2019-11-01/storagecache - v61.4.0
️✔️azure-sdk-for-go - preview/storagecache/mgmt/2019-08-01-preview/storagecache - v61.4.0
❌azure-sdk-for-go-track2 - armstoragecache - 0.3.0

+	Function `CloudErrorBody.MarshalJSON` has been removed
+	Struct `CloudErrorBody` has been removed
+	Struct `CloudError` has been removed
+	Type of `AscOperationProperties.Output` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 1278405. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.5.0` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-storagecache [View full logs] [Release SDK Changes]
- azure-mgmt-storagecache-1.0.0b1.zip
- azure_mgmt_storagecache-1.0.0b1-py3-none-any.whl
```
info	[Changelog]
```

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 1278405. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2529:8 ($.definitions.MetricSpecification.properties.dimensions)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2468:8 ($.definitions.UsageModelsResult.properties.value)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2379:8 ($.definitions.ResourceSkusResult.properties.value)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2296:8 ($.definitions.ResourceSku.properties.restrictions)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2282:8 ($.definitions.ResourceSku.properties.locationInfo)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2264:8 ($.definitions.ResourceSku.properties.capabilities)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:2113:8 ($.definitions.StorageTargetProperties.properties.junctions)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:1979:8 ($.definitions.CacheHealth.properties.conditions)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:1837:8 ($.definitions.NfsAccessPolicy.properties.accessRules)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:1651:8 ($.definitions.CacheSecuritySettings.properties.accessPolicies)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:1323:8 ($.definitions.CloudErrorBody.properties.details)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:1292:8 ($.definitions.ApiOperationListResult.properties.value)
cmderr	[Autorest] ERROR: Schema violation: Additional properties not allowed: x-ms-identifiers
cmderr	[Autorest]     - file:///home/vsts/work/1/s/azure-rest-api-specs/specification/storagecache/resource-manager/Microsoft.StorageCache/stable/2021-09-01/storagecache.json:1268:16 ($.definitions.ApiOperation.properties.properties.properties.serviceSpecification.properties.metricSpecifications)
cmderr	[Autorest] FATAL: swagger-document/individual/schema-validator - FAILED
cmderr	[Autorest] FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
cmderr	[Autorest] Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 1278405. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-11 08:39:42 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-storagecache;1.0.0-beta.4;1.0.0-beta.5"
cmderr	[generate.py] 2022-02-11 08:39:42 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.5"
cmderr	[generate.py] 2022-02-11 08:39:42 INFO autorest --version=3.6.6 --use=@autorest/java@4.0.47 --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storagecache/azure-resourcemanager-storagecache --java.namespace=com.azure.resourcemanager.storagecache   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/storagecache/resource-manager/readme.md
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-storagecache
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [POM][Skip] pom already has module azure-resourcemanager-storagecache
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [POM][Skip] pom already has module sdk/storagecache
cmderr	[generate.py] 2022-02-11 08:40:07 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-storagecache [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-02-11 08:41:26 DEBUG Got artifact_id: azure-resourcemanager-storagecache
cmderr	[Inst] 2022-02-11 08:41:26 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-11 08:41:26 DEBUG Got artifact: azure-resourcemanager-storagecache-1.0.0-beta.5.jar
cmderr	[Inst] 2022-02-11 08:41:26 DEBUG Match jar package: azure-resourcemanager-storagecache-1.0.0-beta.5.jar
cmderr	[Inst] 2022-02-11 08:41:26 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17785/azure-sdk-for-java/azure-resourcemanager-storagecache/azure-resourcemanager-storagecache-1.0.0-beta.5.jar\" -o azure-resourcemanager-storagecache-1.0.0-beta.5.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagecache -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagecache-1.0.0-beta.5.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1278405. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️storagecache/mgmt/2021-09-01/storagecache [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagecache/mgmt/2021-05-01/storagecache [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagecache/mgmt/2021-03-01/storagecache [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagecache/mgmt/2020-10-01/storagecache [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️storagecache/mgmt/2020-03-01/storagecache [View full logs]

Only show 18 items here, please refer to log for details.

info	[Changelog] - Function `CachesClient.FlushResponder` return value(s) have been changed from `(SetObject, error)` to `(autorest.Response, error)`
info	[Changelog] - Type of `CachesUpgradeFirmwareFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
info	[Changelog] - Type of `CachesFlushFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
info	[Changelog] - Type of `CachesDeleteFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
info	[Changelog] - Type of `CachesStartFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
info	[Changelog] - Type of `CachesStopFuture.Result` has been changed from `func(CachesClient) (SetObject, error)` to `func(CachesClient) (autorest.Response, error)`
info	[Changelog] - Type of `StorageTargetsDeleteFuture.Result` has been changed from `func(StorageTargetsClient) (SetObject, error)` to `func(StorageTargetsClient) (autorest.Response, error)`
info	[Changelog] - Struct `SetObject` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `*AscOperation.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `AscOperationProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `AscOperation.MarshalJSON() ([]byte, error)`
info	[Changelog] - New struct `AscOperationProperties`
info	[Changelog] - New anonymous field `*AscOperationProperties` in struct `AscOperation`
info	[Changelog]
info	[Changelog] Total 14 breaking change(s), 6 additive change(s).

️✔️storagecache/mgmt/2019-11-01/storagecache [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/storagecache/mgmt/2019-08-01-preview/storagecache [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 1278405. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armstoragecache [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `AscOperationProperties.Output` has been changed from `map[string]map[string]interface{}` to `map[string]interface{}`
info	[Changelog] - Function `CloudErrorBody.MarshalJSON` has been removed
info	[Changelog] - Struct `CloudError` has been removed
info	[Changelog] - Struct `CloudErrorBody` has been removed
info	[Changelog]
info	[Changelog] Total 6 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 1278405. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  read-package-tree@5.1.6: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh]  @octokit/plugin-request-log@1.0.4 requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️track2_@azure/arm-storagecache [View full logs] [Release SDK Changes]
- azure-arm-storagecache-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 1278405. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️storagecache [View full logs]

_{Posted by Swagger Pipeline | How to fix these errors?}

dw511214992 · 2022-02-11T07:43:06Z

/azp run

azure-pipelines · 2022-02-11T07:43:16Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Steven Vukelich <svukel@microsoft.com>

Add x-ms-identifiers to storagecache/resource-manager.

1e12acf

openapi-assignment-bot bot assigned dw511214992 Feb 10, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Feb 11, 2022

dw511214992 approved these changes Feb 11, 2022

View reviewed changes

dw511214992 merged commit 1278405 into Azure:main Feb 11, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

Add x-ms-identifiers to storagecache/resource-manager. (Azure#17785)

20ae9db

Co-authored-by: Steven Vukelich <svukel@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add x-ms-identifiers to storagecache/resource-manager.#17785

Add x-ms-identifiers to storagecache/resource-manager.#17785
dw511214992 merged 1 commit intoAzure:mainfrom
vukelich:svukel/xmsid-storagecache

vukelich commented Feb 10, 2022

Uh oh!

openapi-workflow-bot bot commented Feb 10, 2022

Uh oh!

openapi-workflow-bot bot commented Feb 10, 2022

Uh oh!

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

dw511214992 commented Feb 11, 2022

Uh oh!

azure-pipelines bot commented Feb 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vukelich commented Feb 10, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Feb 10, 2022

Uh oh!

openapi-workflow-bot bot commented Feb 10, 2022

Uh oh!

openapi-pipeline-app bot commented Feb 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Feb 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

dw511214992 commented Feb 11, 2022

Uh oh!

azure-pipelines bot commented Feb 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 10, 2022 •

edited

Loading