Skip to content

Add x-ms-identifiers to redis\resource-manager #17758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 1 commit into from
Feb 24, 2022
Merged

Add x-ms-identifiers to redis\resource-manager #17758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2056,6 +2056,9 @@
"items": {
"$ref": "#/definitions/RedisInstanceDetails"
},
"x-ms-identifiers": [
"shardId"
],
"description": "List of the Redis instances associated with the cache"
},
"privateEndpointConnections": {
Expand Down Expand Up @@ -2431,6 +2434,7 @@
"items": {
"$ref": "#/definitions/ScheduleEntry"
},
"x-ms-identifiers": [],
"description": "List of patch schedules for a Redis cache."
}
},
Expand Down Expand Up @@ -2627,6 +2631,9 @@
"items": {
"$ref": "#/definitions/Operation"
},
"x-ms-identifiers": [
"name"
],
"description": "List of operations supported by the resource provider."
},
"nextLink": {
Expand Down Expand Up @@ -2684,6 +2691,10 @@
"items": {
"$ref": "#/definitions/UpgradeNotification"
},
"x-ms-identifiers": [
"name",
"timestamp"
Copy link
Member

@TimLovellSmith TimLovellSmith Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. How do we know timestamp is a good identifier? What if it's not unique?? While it seems unlikely to be duplicated, I don't think we have a particular guarantee of uniqueness.

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vukelich Please follow-up. If required, make a new PR for fix.

],
"description": "List of all notifications."
},
"nextLink": {
Expand Down