transforms in place example#17704
Closed
iscai-msft wants to merge 1 commit intoAzure:mainfrom
iscai-msft:transforms_in_place
Closed
transforms in place example#17704iscai-msft wants to merge 1 commit intoAzure:mainfrom iscai-msft:transforms_in_place
iscai-msft wants to merge 1 commit intoAzure:mainfrom
iscai-msft:transforms_in_place
Conversation
|
Hi, @iscai-msft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The operation id has been changed from 'WebPubSub_GenerateClientToken' to 'GetClientAccessToken'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L10:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L40:7 |
|
The operation id has been changed from 'WebPubSub_CloseAllConnections' to 'CloseAllConnections'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L88:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L116:7 |
|
The operation id has been changed from 'WebPubSub_SendToAll' to 'SendToAll'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L154:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L181:7 |
|
The operation id has been changed from 'WebPubSub_ConnectionExists' to 'ConnectionExists'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L229:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L255:7 |
|
The operation id has been changed from 'WebPubSub_CloseConnection' to 'CloseConnection'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L288:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L313:7 |
|
The operation id has been changed from 'WebPubSub_SendToConnection' to 'SendToConnection'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L352:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L376:7 |
|
The operation id has been changed from 'WebPubSub_GroupExists' to 'GroupExists'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L425:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L448:7 |
|
The operation id has been changed from 'WebPubSub_CloseGroupConnections' to 'CloseGroupConnections'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L487:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L509:7 |
|
The operation id has been changed from 'WebPubSub_SendToGroup' to 'SendToGroup'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L562:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L583:7 |
|
The operation id has been changed from 'WebPubSub_AddConnectionToGroup' to 'AddConnectionToGroup'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L646:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L666:7 |
|
The operation id has been changed from 'WebPubSub_RemoveConnectionFromGroup' to 'RemoveConnectionFromGroup'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L711:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L730:7 |
|
The operation id has been changed from 'WebPubSub_UserExists' to 'UserExists'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L778:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L796:7 |
|
The operation id has been changed from 'WebPubSub_CloseUserConnections' to 'CloseUserConnections'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L839:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L856:7 |
|
The operation id has been changed from 'WebPubSub_SendToUser' to 'SendToUser'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L913:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L929:7 |
|
The operation id has been changed from 'WebPubSub_AddUserToGroup' to 'AddUserToGroup'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L986:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1001:7 |
|
The operation id has been changed from 'WebPubSub_RemoveUserFromGroup' to 'RemoveUserFromGroup'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L1051:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1065:7 |
|
The operation id has been changed from 'WebPubSub_RemoveUserFromAllGroups' to 'RemoveUserFromAllGroups'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L1118:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1131:7 |
|
The operation id has been changed from 'WebPubSub_GrantPermission' to 'GrantPermission'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L1176:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1188:7 |
|
The operation id has been changed from 'WebPubSub_RevokePermission' to 'RevokePermission'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L1253:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1264:7 |
|
The operation id has been changed from 'WebPubSub_CheckPermission' to 'HasPermission'. This will impact generated code. New: WebPubSub/stable/2021-10-01/webpubsub.json#L1330:7 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L1340:7 |
|
The new version is missing an operation that was found in the old version. Was operationId 'HealthApi_GetServiceStatus' removed or restructured? New: WebPubSub/stable/2021-10-01/webpubsub.json#L8:5 Old: WebPubSub/stable/2021-10-01/webpubsub.json#L8:5 |
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/5dd079fc54ebcebb1b510f548dd6df49e7c2ff2b/specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json", "details":"Command failed: node /home/vsts/work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@Azure+oad@0.9.1/node_modules/autorest/dist/app.js --input-file=specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Schema violation: Array is too short (0), minimum 1\n - file:///home/vsts/work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json:7416:6 ($.definitions.WebNotificationHook.required)\nERROR: Schema violation: Array is too short (0), minimum 1\n - file:///home/vsts/work/1/azure-rest-api-specs/specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json:7400:6 ($.definitions.EmailNotificationHook.required)\nERROR: Schema violation: Array is too short (0), minimum 1\n - file:///home/vsts/work/1/azure-rest-api-specs/specification/cognitiveservices/data" |
️❌LintDiff: 2 Errors, 4 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
| Rule | Message |
|---|---|
|
"readme":"cognitiveservices/data-plane/MetricsAdvisor/readme.md", "tag":"release_1_0", "details":"swagger-document/individual/schema-validator - FAILED" |
|
"readme":"cognitiveservices/data-plane/MetricsAdvisor/readme.md", "tag":"release_1_0", "details":"Error: [OperationAbortedException] Error occurred. Exiting." |
| The operation 'SendToAll' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: WebPubSub/stable/2021-10-01/webpubsub.json#L154 |
|
| The operation 'SendToConnection' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: WebPubSub/stable/2021-10-01/webpubsub.json#L352 |
|
| The operation 'SendToGroup' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: WebPubSub/stable/2021-10-01/webpubsub.json#L562 |
|
| The operation 'SendToUser' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: WebPubSub/stable/2021-10-01/webpubsub.json#L913 |
️❌Avocado: 45 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"role":"Model Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/5dd079fc54ebcebb1b510f548dd6df49e7c2ff2b/specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json" |
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"role":"Semantic Validation", "url":"https://github.com/Azure/azure-rest-api-specs/blob/5dd079fc54ebcebb1b510f548dd6df49e7c2ff2b/specification/cognitiveservices/data-plane/MetricsAdvisor/stable/v1.0/MetricsAdvisor.json" |
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄SDK Track2 Validation inProgress [Detail]
️❌PrettierCheck: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: MetricsAdvisor/stable/v1.0/MetricsAdvisor.json |
|
Code style issues found path: WebPubSub/stable/2021-10-01/webpubsub.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=276427&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from f6e09c2351d5f2ef8cfdf78d26fc2c726e5fd47b. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.Messaging.WebPubSub [View full logs] [Preview SDK Changes]- Azure.Messaging.WebPubSub.1.1.0-alpha.20220208.1.nupkg
- Azure.Messaging.WebPubSub.1.1.0-alpha.20220208.1.symbols.nupkg
info [Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from f6e09c2351d5f2ef8cfdf78d26fc2c726e5fd47b. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. cmderr [automation_init.sh] opencensus-ext-azure 1.1.1 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] azure-identity 1.7.1 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible. cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. warn specification/cognitiveservices/data-plane/MetricsAdvisor/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1> cmderr [automation_generate.sh] npm notice Run `npm install -g npm@8.4.1` to update! cmderr [automation_generate.sh] npm notice
️✔️azure-messaging-webpubsubservice [View full logs] [Preview SDK Changes]- azure_messaging_webpubsubservice-1.0.0b1-py2.py3-none-any.whl
- azure-messaging-webpubsubservice-1.0.0b1.zip
info [Changelog] data-plan skip changelog generation temporarily
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from f6e09c2351d5f2ef8cfdf78d26fc2c726e5fd47b. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-6.0 warn specification/cognitiveservices/data-plane/MetricsAdvisor/readme.md skipped due to azure-sdk-for-net not found in swagger-to-sdk command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/webpubsub/data-plane/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Azure.Messaging.WebPubSub [View full logs] [Preview SDK Changes]warn Skip artifact folder because it doesn't exist: artifacts/packages
|
Hi @iscai-msft, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @iscai-msft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.