AzureStack Admin API - Update RP APIs#17659
Merged
jianyexi merged 17 commits intoAzure:mainfrom Feb 23, 2022
Merged
Conversation
|
Hi, @LingyunSu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @LingyunSu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response of operation:'UpdateLocations_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateLocations.json#L62 |
|
The response of operation:'UpdateRuns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L68 |
|
The response of operation:'UpdateRuns_GetTopLevel' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L161 |
|
The response of operation:'Updates_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Update.Admin/stable/2021-07-01/Updates.json#L65 |
|
The top-level resource 'UpdateLocation' does not have list by subscription operation, please add it. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateLocations.json#L105 |
|
The response schema of operations API '/providers/Microsoft.Update.Admin/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Update.Admin/stable/2021-07-01/Update.json#L19 |
| The operation 'UpdateRuns_Rerun' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L206 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Update.Admin/stable/2021-07-01/Updates.json#L109 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Update.Admin/stable/2021-07-01/Updates.json#L155 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Update.Admin/stable/2021-07-01/Updates.json#L201 |
|
| The child tracked resource, 'updateRuns' with immediate parent 'Update', must have a list by immediate parent operation. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L255 |
|
| The child tracked resource, 'updateRuns' with immediate parent 'UpdateLocation', must have a list by immediate parent operation. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L255 |
|
| The child tracked resource, 'updates' with immediate parent 'UpdateLocation', must have a list by immediate parent operation. Location: Microsoft.Update.Admin/stable/2021-07-01/Updates.json#L249 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get the list of update runs. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L117 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get an update run. Location: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json#L162 |
️⚠️Avocado: 2 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: azsadmin/resource-manager/update/readme.md json: Microsoft.Update.Admin/stable/2021-07-01/Updates.json |
|
| The JSON file has a circular reference. readme: azsadmin/resource-manager/update/readme.md json: Microsoft.Update.Admin/stable/2021-07-01/UpdateRuns.json |
️❌~[Staging] ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: AuthorizationFailed, message: The client '0a32c980-8601-446c-843e-9411a8f586c7' with object id '0a32c980-8601-446c-843e-9411a8f586c7' does not have authorization to perform action 'Microsoft.Update.Admin/operations/read' over scope '/providers/Microsoft.Update.Admin' or the scope is invalid. If access was recently granted, please refresh your credentials." |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 31 Errors, 8 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2021-07-01/Update.json compared with base:preview/2016-05-01/Update.json
- current:stable/2021-07-01/UpdateLocations.json compared with base:preview/2016-05-01/UpdateLocations.json
- current:stable/2021-07-01/UpdateRuns.json compared with base:preview/2016-05-01/UpdateRuns.json
- current:stable/2021-07-01/Updates.json compared with base:preview/2016-05-01/Updates.json
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Hi @LingyunSu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
bganapa
reviewed
Feb 5, 2022
LingyunSu
requested review from
ArcturusZhang,
MS-syh2qs,
asarkar84,
dkulkarni-ms,
dpwatrous,
grizzlytheodore,
haagha,
hyonholee,
jsntcy,
kjeur,
madewithsmiles and
msyyc
as code owners
bganapa
removed request for
MS-syh2qs,
RAY-316,
Sandido,
dkulkarni-ms,
haagha and
msyyc
Member
|
@ArcturusZhang This is azure stack admin API . These APIs are not shipped in azure. We generate only powershell for these APIs. The SDK validation pipeline is still running(and stuck) as part of PR checks. We do not have any tags in the readme.md for SDK generation. Could you pls check why it is still running? Thank you! |
Contributor
Author
|
@bganapa , this liner error is: "readme":"azsadmin/resource-manager/update/readme.md", I don't think there is a real liner error here. let's sync up... |
JeffreyRichter
added
the
Approved-BreakingChange
pilor
added
ARMSignedOff
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyexi
reviewed
Feb 10, 2022
jianyexi
suggested changes
Feb 11, 2022
Invalid yaml Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
jianyexi
approved these changes
Feb 23, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
* Copy of previous API v2016-05-01 * URP api 2021-07-01 * Update examples * Validation issue fix * validateion fix * validation fix * Add API 2021-07-01 as stable version * Update readme for new api * New api in readme * Config fix * Remove input-file Invalid yaml Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com> * Correct reference readme.md Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com> * Fix validation errors * Fix validation * Validate fix * update validateion fix * Refactoring Co-authored-by: JianyeXi <59603451+jianyexi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
What's the purpose of the update?
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
03/2022
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
03/2022
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[X] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.