Skip to content

Adding xms-ids for CDN #17625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jianyexi merged 4 commits into from
Feb 10, 2022
Merged

Adding xms-ids for CDN #17625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06cc578
Adding xms-ids for CDN
agalerrotaru Feb 2, 2022
5bb56bf
Merge branch 'Azure:main' into agalerrotaru/cdn
agalerrotaru Feb 2, 2022
25bce44
corrections after rebase
agalerrotaru Feb 3, 2022
db772b4
checkout readme
agalerrotaru Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 38 additions & 14 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/afdx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4307,7 +4307,8 @@
"type": "array",
"items": {
"$ref": "#/definitions/SecurityPolicyWebApplicationFirewallAssociation"
}
},
"x-ms-identifiers": []
}
}
},
Expand Down Expand Up @@ -5266,14 +5267,20 @@
"type": "array",
"items": {
"$ref": "./cdn.json#/definitions/DeliveryRuleCondition"
}
},
"x-ms-identifiers": [
"name"
]
},
"actions": {
"description": "A list of actions that are executed when all the conditions of a rule are satisfied.",
"type": "array",
"items": {
"$ref": "./cdn.json#/definitions/DeliveryRuleAction"
}
},
"x-ms-identifiers": [
"name"
]
},
"matchProcessingBehavior": {
"description": "If this rule is a match should the rules engine continue running the remaining rules or stop. If not present, defaults to Continue.",
Expand Down Expand Up @@ -5406,7 +5413,10 @@
"type": "string"
}
}
}
},
"x-ms-identifiers": [
"name"
]
},
"data": {
"type": "array",
Expand All @@ -5421,10 +5431,12 @@
"type": "number"
}
}
}
},
"x-ms-identifiers": []
}
}
}
},
"x-ms-identifiers": []
}
}
},
Expand Down Expand Up @@ -5471,13 +5483,18 @@
"type": "number"
}
}
}
},
"x-ms-identifiers": []
}
}
}
},
"x-ms-identifiers": [
"name"
]
}
}
}
},
"x-ms-identifiers": []
}
}
},
Expand Down Expand Up @@ -5618,7 +5635,10 @@
"type": "string"
}
}
}
},
"x-ms-identifiers": [
"name"
]
},
"data": {
"type": "array",
Expand All @@ -5633,10 +5653,12 @@
"type": "number"
}
}
}
},
"x-ms-identifiers": []
}
}
}
},
"x-ms-identifiers": []
}
}
},
Expand Down Expand Up @@ -5685,10 +5707,12 @@
"format": "double"
}
}
}
},
"x-ms-identifiers": []
}
}
}
},
"x-ms-identifiers": []
}
}
},
Expand Down
85 changes: 69 additions & 16 deletions specification/cdn/resource-manager/Microsoft.Cdn/stable/2021-06-01/cdn.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2658,14 +2658,20 @@
"type": "array",
"items": {
"$ref": "#/definitions/DeepCreatedOrigin"
}
},
"x-ms-identifiers": [
"name"
]
},
"originGroups": {
"description": "The origin groups comprising of origins that are used for load balancing the traffic based on availability.",
"type": "array",
"items": {
"$ref": "#/definitions/DeepCreatedOriginGroup"
}
},
"x-ms-identifiers": [
"name"
]
},
"customDomains": {
"description": "The custom domains under the endpoint.",
Expand Down Expand Up @@ -2781,7 +2787,8 @@
"type": "array",
"items": {
"$ref": "#/definitions/GeoFilter"
}
},
"x-ms-identifiers": []
},
"defaultOriginGroup": {
"description": "A reference to the origin group.",
Expand All @@ -2793,7 +2800,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/UrlSigningKey"
}
},
"x-ms-identifiers": [
"keyId"
]
},
"deliveryPolicy": {
"description": "A policy that specifies the delivery rules to be used for an endpoint.",
Expand All @@ -2811,7 +2821,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/DeliveryRule"
}
},
"x-ms-identifiers": [
"name"
]
}
}
},
Expand Down Expand Up @@ -2849,14 +2862,20 @@
"type": "array",
"items": {
"$ref": "#/definitions/DeliveryRuleCondition"
}
},
"x-ms-identifiers": [
"name"
]
},
"actions": {
"description": "A list of actions that are executed when all the conditions of a rule are satisfied.",
"type": "array",
"items": {
"$ref": "#/definitions/DeliveryRuleAction"
}
},
"x-ms-identifiers": [
"name"
]
}
}
},
Expand Down Expand Up @@ -4373,7 +4392,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/UrlSigningParamIdentifier"
}
},
"x-ms-identifiers": [
"paramName"
]
}
}
},
Expand Down Expand Up @@ -5409,7 +5431,8 @@
"type": "array",
"items": {
"$ref": "#/definitions/HttpErrorRangeParameters"
}
},
"x-ms-identifiers": []
}
}
},
Expand Down Expand Up @@ -5867,6 +5890,9 @@
"items": {
"$ref": "#/definitions/ResourceUsage"
},
"x-ms-identifiers": [
"resourceType"
],
"description": "List of resource usages."
},
"nextLink": {
Expand Down Expand Up @@ -5923,6 +5949,9 @@
"items": {
"$ref": "#/definitions/Operation"
},
"x-ms-identifiers": [
"name"
],
"description": "List of CDN operations supported by the CDN resource provider."
},
"nextLink": {
Expand Down Expand Up @@ -6001,14 +6030,20 @@
"type": "array",
"items": {
"$ref": "#/definitions/LogSpecification"
}
},
"x-ms-identifiers": [
"name"
]
},
"metricSpecifications": {
"description": "Metric specifications of operation.",
"type": "array",
"items": {
"$ref": "#/definitions/MetricSpecification"
}
},
"x-ms-identifiers": [
"name"
]
}
}
},
Expand Down Expand Up @@ -6063,7 +6098,8 @@
"type": "array",
"items": {
"$ref": "#/definitions/MetricAvailability"
}
},
"x-ms-identifiers": []
},
"supportedTimeGrainTypes": {
"type": "array",
Expand All @@ -6077,7 +6113,10 @@
"description": "The dimensions of metric",
"items": {
"$ref": "#/definitions/DimensionProperties"
}
},
"x-ms-identifiers": [
"name"
]
},
"fillGapWithZero": {
"type": "boolean",
Expand Down Expand Up @@ -6166,7 +6205,10 @@
"type": "array",
"items": {
"$ref": "#/definitions/IpAddressGroup"
}
},
"x-ms-identifiers": [
"deliveryRegion"
]
}
}
},
Expand All @@ -6183,14 +6225,20 @@
"type": "array",
"items": {
"$ref": "#/definitions/cidrIpAddress"
}
},
"x-ms-identifiers": [
"baseIpAddress"
]
},
"ipv6Addresses": {
"description": "The list of ip v6 addresses.",
"type": "array",
"items": {
"$ref": "#/definitions/cidrIpAddress"
}
},
"x-ms-identifiers": [
"baseIpAddress"
]
}
}
},
Expand Down Expand Up @@ -6428,6 +6476,10 @@
"items": {
"$ref": "#/definitions/ErrorDetail"
},
"x-ms-identifiers": [
"message",
Copy link

@jorinmejia jorinmejia Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "target" need "message" to form a composite identifier? Would "target" by itself not be enough in this case?

Copy link
Contributor Author

@agalerrotaru agalerrotaru Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because you can have multiple error messages targeting the same RP/resource, so you need another property to identify a unique error detail.

"target"
],
"description": "The error details."
},
"additionalInfo": {
Expand All @@ -6436,6 +6488,7 @@
"items": {
"$ref": "#/definitions/ErrorAdditionalInfo"
},
"x-ms-identifiers": [],
"description": "The error additional info."
}
}
Expand Down
Loading