Skip to content

Auto code generator for .NET sdk uses master branch for code generation#17526

Closed
dabenhamMic wants to merge 702 commits intomasterfrom
main
Closed

Auto code generator for .NET sdk uses master branch for code generation#17526
dabenhamMic wants to merge 702 commits intomasterfrom
main

Conversation

@dabenhamMic
Copy link
Contributor

@dabenhamMic dabenhamMic commented Jan 27, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify

.NET auto code generation uses by default master branch.
our package rellies on latest version of our swagger - "OperationalInsights package-2021-12-01-preview"
please merge main into master if possible.

  1. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  2. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  3. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Alancere and others added 30 commits December 1, 2021 14:47
* Update README files to generate sdk in azure-sdk-for-net repo.

* Changed namespace name.

* Moved Dot NET sdk repo path up.

Co-authored-by: Santosh Mishra <sanmishra@microsoft.com>
…review (#16664)

* added Geocode API

* Fixed a few issues with swagger and examples

* Add x-ms-error-response to response codes

* Fixed the error responses in sample

* Fixed the format of sameple file

* Fixed the operation name

* Fixed spelling and prettier issues

* move geocode folder to parent folder

* update some descriptions

* add geocode batch api

* update batch geocode api example

* update goecode batch api description

* remove summayr field

* address comments

* update the strictMatch type to enum

* update forward geocode sample query

* update batchItem schema

* fix the prettier issue

* Fixed the $ref for some defitions

* apply prettier

* add readme to fix avacado error

* upper case the parameter & response definition

* address review board comments

* address review board comments

* structuralize request body of geocode batch api

* update forward geocode sample json format

* 1. adjust geocode batch api description due to the request body format
   change
2. add nextLink field to batch response

* fix sdk track2 fail

* update naming from geocode to geocoding

* address review comments

* add status code 206 to batch api

* update api version

* add optionalId

* fix prettier error, add name to enum field for better code generation

* update post api method name

* move api key from header to query

* move geocoding to search folder

* change apiKey from query to header

* improve the class name in sdk generation

* update description

* comment out python and java sdk generation since it's manually generated now

* update description

* add an api example

Co-authored-by: Hongwei Sun <hongweis@microsoft.com>
* fix for notebook activity parameter

* remove required property
* introducing 2021-11-01 version

* Adding inmage fields

* branch

* readme files

* Correcting file name

* prettier checks

* SEMANTIC VALIDATIONS

* prettier checks

* Fixes

* Fixes

* Fixes

* Fixes

* Fixes

* Update service.json

* LintDiff fix

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Vishnu Priya Ananthu Sundaram <viananth@microsoft.com>
* add LRO property

* fix the api
* remove name validation from client side

* remove name check from deploymentScripts swagger

* remove name check from previous swagger versions

* remove pattern from resourcegroupname parameter

* add missing zoneMappings property to resources

* fix linter errors
* Track2 modify readme.go.md 6

* mariadb derective description
* Fixing s360 correctness items

* Fixing spell check and prettier
…with RP behaviour (#16915)

* Duplicating common-types v3 to v4

* updating version

* adding space to SystemAssigned, UserAssigned"

* removing unchanged files.

Co-authored-by: Praveenkumar Ravikumar <prravikumar@microsoft.com>
* Add address boundingbox def

* Add entity enum
* adding data plane apis for load test service

* adding custom words

Co-authored-by: Krishna Chandak <krchanda@microsoft.com>
…dd version preview/2.0 (#16706)

* added extra fields to JSON list data response in docs

* added content-type field to request header

* took out content type from header field due to errors; JSON reponse fields for user Data are ready to commit

* added content-type header to userData update docs

* added a change which fixed prettier check

* changed name of enum

* added reference to ContentType

* trying to add contenttype to docs

* adding content type header

* trying to add content type header to userDate update docs

* adding content type header to update docs

* adding example parameter for new content-type request header

* changed xs-parameter-location

* trying to fix invalid type error

* Trying to fix model error

* trying new changes

* Making final changes: added content type header

* getting rid of content type header changes to work on a diff bug

* added corresponding content types for dataFormat in upload preview

* reverting changes due to unforseen model errors

* adding dataFormats that correspond to content-type

* was missing a quote

* changed format of some wording

* adding schema to swagger spec for 400 response for data upload preview

* fixing changes

* reverted changes

* trying to remove body from response examples

* adding schema to 400 response in data upload

* reverting changes again

* adding schema to 400 response in data upload

* removed header from 400 response

* adding schema

* reverting all changes

* trying changes

* reverting again 2.0

* moving responses to directions section

* semantic validation changes

* fixing model val errors

* fixing model val errors

* got rid of model val errors

* fixing prettier check errors

* fixing another prettier check error

* fixed error code response message

* removing required properties

* removing unneeded definitions

* fixed prettier check issues again

* deleted 200 response for data update (LRO)

* got rid of headers

* added header back for download 200

* added 200 response back to data update

* added content type header into user update

* fixing invalid type err

* trying to fix invalid type

* reverting content type header changes

* adding header to 202 response
* Track2 modify readme.go.md 8

* backup,siterecovery into recoveryservices
* require DataFlow

* ManagedPrivateEndpoint,ManagedVirtualNetwork

* fix

* xx

* ManagedPrivateEndpoint delete discriminator

* Duplicate Schema named 'BlobEventTypes'

* prettier

* keep the enum type unchanged

Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
…neral Availability (#16946)

* Adding base-line 2022-02-01 swagger

* Making updates based on REST API feedback

* Comments
- simplify the name of group/command/parameter
- add alias to parameters
* base api commit

* adding 2021-09-01-preview

* added 2021-10-01-preview

* updating readme files

* Fixing python readme

* Fixing readme

* Fixing readme

* Fixing readme

* adding elastic upgrade APIs

Co-authored-by: Utkarsh Jain <utkarshjain@microsoft.com>
Co-authored-by: pmp <pmp@microsoft.com>
This was referenced Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.