-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Microsof.app 2022 01 01 preview/add custom domains #17385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
98de6eb
8f6cb60
925c9c6
6e3b5a4
b716fd1
d47481b
436f0b7
b00c1f0
e4b0d0f
86c094e
3fce21c
7609023
b37c3ac
b9f3846
8c1cd8b
34300f3
5d9fe2c
b1f5004
8da8fa5
0fbec14
4ccd72d
a98ac1a
755f670
1a697d0
cbb2b95
64dab7a
72b90e7
3ecab2b
e9b4877
cdb52dd
6792d83
7eddc6e
37c0880
1ee5c24
cdb9674
2058c97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -309,6 +309,53 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.App/containerApps/{name}/analyzeCustomHostName": { | ||
| "get": { | ||
| "tags" : [ | ||
| "ContainerApps" | ||
| ], | ||
| "summary" : "Analyzes a custom hostname for a Container App", | ||
| "operationId": "ContainerAppsRevisions_AnalyzeCustomHostName", | ||
| "parameters" :[ | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "name": "containerAppName", | ||
| "in": "path", | ||
| "description": "Name of the Container App.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "name": "hostName", | ||
| "in": "query", | ||
| "description": "Custom hostname.", | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "schema": { | ||
| "$ref": "#/definitions/CustomHostnameAnalysisResult" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Common error response.", | ||
| "schema": { | ||
| "$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "definitions": { | ||
|
|
@@ -400,6 +447,11 @@ | |
| "type": "string", | ||
| "readOnly": true | ||
| }, | ||
| "customDomainVerificationId": { | ||
| "description": "Id used to verify domain name ownership", | ||
| "type": "string", | ||
| "readOnly": true | ||
| }, | ||
| "configuration": { | ||
| "$ref": "#/definitions/Configuration", | ||
| "description": "Non versioned Container App configuration properties." | ||
|
|
@@ -489,6 +541,13 @@ | |
| "revisionName" | ||
| ] | ||
| }, | ||
| "customDomains": { | ||
| "description": "custom domain bindings for Container Apps' hostnames.", | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/CustomDomain" | ||
| } | ||
vinisoto marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }, | ||
| "allowInsecure": { | ||
| "description": "Bool indicating if HTTP connections to is allowed. If set to false HTTP connections are automatically redirected to HTTPS connections", | ||
| "type": "boolean" | ||
|
|
@@ -551,6 +610,141 @@ | |
| "type": "boolean" | ||
| } | ||
| } | ||
| }, | ||
| "CustomDomain": { | ||
| "description": "Custom Domain of a Container App", | ||
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "description": "Hostname.", | ||
| "type": "string" | ||
| }, | ||
| "bindingType": { | ||
| "description": "Custom Domain binding type.", | ||
| "enum": [ | ||
| "Disabled", | ||
vinisoto marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "SniEnabled", | ||
| "IpBasedEnabled" | ||
|
||
| ], | ||
| "type": "string", | ||
| "x-ms-enum": { | ||
| "name": "bindingType", | ||
| "modelAsString": false | ||
ruslany marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
| }, | ||
| "virtualIP": { | ||
| "description": "Virtual IP address assigned to the hostname if IP based binding is enabled.", | ||
| "type": "string" | ||
| }, | ||
vinisoto marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "certificateName": { | ||
| "description": "Name of the Certificate to be bound to this hostname. Must exist in the Managed Environment.", | ||
| "type": "string" | ||
| }, | ||
| "hostType": { | ||
vinisoto marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "description": "Indicates whether the hostname is a standard or repository hostname.", | ||
| "enum": [ | ||
| "Standard", | ||
| "Repository" | ||
| ], | ||
| "type": "string", | ||
| "x-ms-enum": { | ||
| "name": "HostType", | ||
| "modelAsString": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "CustomHostnameAnalysisResult": { | ||
| "description": "Custom domain analysis.", | ||
| "type": "object", | ||
| "allOf": [ | ||
| { | ||
| "$ref": "./CommonDefinitions.json#/definitions/ProxyOnlyResource" | ||
| } | ||
| ], | ||
| "properties": { | ||
| "properties": { | ||
| "description": "CustomHostnameAnalysisResult resource specific properties", | ||
| "type": "object", | ||
| "properties": { | ||
| "isHostnameAlreadyVerified": { | ||
| "description": "<code>true</code> if hostname is already verified; otherwise, <code>false</code>.", | ||
| "type": "boolean", | ||
| "readOnly": true | ||
| }, | ||
| "customDomainVerificationTest": { | ||
| "description": "DNS verification test result.", | ||
| "enum": [ | ||
| "Passed", | ||
| "Failed", | ||
| "Skipped" | ||
| ], | ||
| "type": "string", | ||
| "readOnly": true, | ||
| "x-ms-enum": { | ||
| "name": "DnsVerificationTestResult", | ||
| "modelAsString": false | ||
| } | ||
| }, | ||
| "customDomainVerificationFailureInfo": { | ||
| "$ref": "./CommonDefinitions.json#/definitions/DefaultErrorResponse", | ||
| "description": "Raw failure information if DNS verification fails.", | ||
| "readOnly": true | ||
| }, | ||
| "hasConflictOnManagedEnvironment": { | ||
| "description": "<code>true</code> if there is a conflict on the Container App's managed environment; otherwise, <code>false</code>.", | ||
| "type": "boolean", | ||
| "readOnly": true | ||
| }, | ||
| "hasConflictAcrossSubscription": { | ||
| "description": "<code>true</code> if there is a conflict across subscriptions; otherwise, <code>false</code>.", | ||
| "type": "boolean", | ||
| "readOnly": true | ||
| }, | ||
| "conflictingAppResourceId": { | ||
| "description": "Name of the conflicting Container App on the Managed Environment if it's within the same subscription.", | ||
| "type": "string", | ||
| "readOnly": true | ||
| }, | ||
| "cNameRecords": { | ||
| "description": "CName records visible for this hostname.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "txtRecords": { | ||
| "description": "TXT records visible for this hostname.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "aRecords": { | ||
| "description": "A records visible for this hostname.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "alternateCNameRecords": { | ||
| "description": "Alternate CName records visible for this hostname.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "alternateTxtRecords": { | ||
| "description": "Alternate TXT records visible for this hostname.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-client-flatten": true | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "securityDefinitions": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,19 @@ | |
| "configuration": { | ||
| "ingress": { | ||
| "external": true, | ||
| "targetPort": 3000 | ||
| "targetPort": 3000, | ||
| "customDomains": [ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a non-readonly property in an api version is considered a breaking change. Some existing clients ould get broken. Consider if you need to update the api-version, but this comment is not blocking. If you do not have too many clients and are willing to work with any existing customers to update thier broken clients if any then you can go ahead with this. #Resolved
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @raosuhas we don't have any clients yet so we should be ok. |
||
| { | ||
| "name": "www.my-name.com", | ||
| "bindingType": "SniEnabled", | ||
| "certificateName": "my-certificate-for-my-name-dot-com" | ||
| }, | ||
| { | ||
| "name": "www.my--other-name.com", | ||
| "bindingType": "SniEnabled", | ||
| "certificateName": "my-certificate-for-my-other-name-dot-com" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "template": { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.