-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Microsof.app 2022 01 01 preview/add custom domains #17385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akning-ms
merged 36 commits into
Azure:Microsoft.App-2022-01-01-preview
from
vinisoto:Microsof.App-2022-01-01-preview/addCustomDomains
Feb 4, 2022
Merged
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
98de6eb
add support for Custom domains and certificates
vinisoto 8f6cb60
add Certificates
vinisoto 925c9c6
Ccertificate as child resource of Managed Env.
vinisoto 6e3b5a4
Support default custom domain
vinisoto b716fd1
PUT/DELETE certificate are not long-running
vinisoto d47481b
Add Custom Domain Verification Id
vinisoto 436f0b7
domains for all revisions and adding examples
vinisoto b00c1f0
missing examples
vinisoto e4b0d0f
one more missing example
vinisoto 86c094e
Examples+missing paths
vinisoto 3fce21c
Adding missing envelope properties
vinisoto 7609023
Addressing PR comments
vinisoto b37c3ac
Removing AKV and Free cert related properties
vinisoto b9f3846
Prettier and semantic validation fixes
vinisoto 8c1cd8b
Fixing semantic validations and examples
vinisoto 34300f3
More fixes
vinisoto 5d9fe2c
Addressing more PR comments
vinisoto b1f5004
Updating examples
vinisoto 8da8fa5
fixing type
vinisoto 0fbec14
fixing types
vinisoto 4ccd72d
Extra properties and responses
vinisoto a98ac1a
misplaced response
vinisoto 755f670
whitespace
vinisoto 1a697d0
fix security section
vinisoto cbb2b95
fixing ManageEnvironment securityDefinitions
vinisoto 64dab7a
add 204 delete response
vinisoto 72b90e7
Removing virtual IP and IP Based option
vinisoto 3ecab2b
change modelAsString
vinisoto e9b4877
Addressing ARM PR comments
vinisoto cdb52dd
Removing 404 response from example
vinisoto 6792d83
renaming custom hostname analysis operation
vinisoto 7eddc6e
mark certificate as tracked resource
ruslany 37c0880
Merge pull request #1 from ruslany/customdomaintracked
vinisoto 1ee5c24
fix sample
ruslany cdb9674
Merge pull request #2 from ruslany/fixsample
vinisoto 2058c97
Use Certificate Id instead of Certificate name
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason you are not choosing to name with list* something like .. listCustomHostProperties or something .
The reason I ask is since in ARM templates only list* operations are supported so you could do operations using the output values of this call. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See examples here : https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-functions-resource#list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raosuhas For context: This API will check if a certain hostname (e.g., my-app.com) is valid for the app by performing a number of checks (e.g., hostname not being used by another app, customer owns the domain, etc.) and returning the results. I think analyze... describes better what the API actually does but I can see the merit on having it available for ARM templates. @ruslany what do you think?