Servicebus: updated for GEO DR by v-Ajnava · Pull Request #1714 · Azure/azure-rest-api-specs

v-Ajnava · 2017-09-21T18:24:53Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

ravbhatnagar

@v-Ajnava - Some feedback for you

ravbhatnagar · 2017-09-21T23:33:59Z

specification/servicebus/resource-manager/Microsoft.ServiceBus/2017-04-01/servicebus.json

+          }
+        ],
+        "responses": {
+          "201": {


Please use 202 for delete LRO.

Reverted as delete is not async

ravbhatnagar · 2017-09-21T23:34:27Z

specification/servicebus/resource-manager/Microsoft.ServiceBus/2017-04-01/servicebus.json

+        "properties": {
+          "x-ms-client-flatten": true,
+          "properties": {
+            "provisioningState": {


make this enum

Resolved, we don't support cancel.

ravbhatnagar · 2017-09-21T23:36:19Z

specification/servicebus/resource-manager/Microsoft.ServiceBus/2017-04-01/servicebus.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfig/{alias}/breakpairing": {


breakPairing (camelcase)

ravbhatnagar · 2017-09-21T23:38:08Z

specification/servicebus/resource-manager/Microsoft.ServiceBus/2017-04-01/servicebus.json

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfig": {


pluralize resource type name? disasterRecoveryConfigs.

azuresdkciprbot · 2017-09-23T01:35:32Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/servicebus/resource-manager/readme.md
Before the PR: Warning(s): 29 Error(s): 0
After the PR: Warning(s): 31 Error(s): 0

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

salameer · 2017-09-25T19:34:04Z

@sarangan12 can you add your feedback here

azuresdkciprbot · 2017-09-25T21:25:34Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/servicebus/resource-manager/readme.md
Before the PR: Warning(s): 29 Error(s): 0
After the PR: Warning(s): 31 Error(s): 0

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

AutorestCI · 2017-09-26T18:03:25Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-09-26T18:03:30Z

Azure/azure-sdk-for-ruby#1001

AutorestCI · 2017-09-26T18:03:58Z

Azure/azure-sdk-for-python#1482

GEO DR related changes

14de4c4

msftclas added the cla-already-signed label Sep 21, 2017

azuresdkci assigned sarangan12 Sep 21, 2017

ravbhatnagar reviewed Sep 21, 2017

View reviewed changes

Ajit Navasare (MINDTREE LIMITED) added 2 commits September 21, 2017 19:11

Review comments and examples

d81e215

Geo DR - Pluralize opertionsIds and reveted delete response code to 200

840da3e

Removed LastSync Property

7e1e1b1

msftgits removed the cla-already-signed label Sep 26, 2017

sarangan12 approved these changes Sep 26, 2017

View reviewed changes

sarangan12 merged commit 072a433 into Azure:current Sep 26, 2017

AutorestCI mentioned this pull request Sep 26, 2017

Automatic PR from RestAPI-PR1714 Azure/azure-sdk-for-ruby#1001

Merged

AutorestCI mentioned this pull request Sep 26, 2017

[Servicebus] updated for GEO DR Azure/azure-sdk-for-python#1482

Merged

v-Ajnava mentioned this pull request Oct 3, 2017

Servicebus: Geo DR feature Azure/azure-sdk-for-net#3750

Merged

8 tasks

Conversation

v-Ajnava commented Sep 21, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Sep 23, 2017

Uh oh!

salameer commented Sep 25, 2017

Uh oh!

azuresdkciprbot commented Sep 25, 2017

Uh oh!

AutorestCI commented Sep 26, 2017

Uh oh!

AutorestCI commented Sep 26, 2017

Uh oh!

AutorestCI commented Sep 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

v-Ajnava commented Sep 21, 2017 •

edited by azuresdkci

Loading