Skip to content

Adding oauth2AllowImplicitFlow property to ApplicationCreateParameters and ApplicationUpdateParameters#1712

Merged
amarzavery merged 1 commit intoAzure:currentfrom
ppathan:current
Sep 21, 2017
Merged

Adding oauth2AllowImplicitFlow property to ApplicationCreateParameters and ApplicationUpdateParameters#1712
amarzavery merged 1 commit intoAzure:currentfrom
ppathan:current

Conversation

@ppathan
Copy link
Copy Markdown
Contributor

@ppathan ppathan commented Sep 21, 2017

  • Adding oauth2AllowImplicitFlow property to ApplicationCreate and ApplicationUpdate parameters.
  • Tested with local change using azure-sdk-node to see if the proprety is getting applied on newly created application.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

* Adding oauth2AllowImplicitFlow property to ApplicationCreate and ApplicationUpdate parameters.
* Tested with local change using azure-sdk-node to see if the proprety is getting applied on newly created application.
@msftclas
Copy link
Copy Markdown

@ppathan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@amarzavery amarzavery merged commit 75323f0 into Azure:current Sep 21, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/graphrbac/data-plane/readme.md
Before the PR: Warning(s): 2 Error(s): 20
After the PR: Warning(s): 2 Error(s): 20

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants