Skip to content

[Synapse] Fix for parameter in Notebook activity #16852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 2 commits into from
Dec 1, 2021
Merged

[Synapse] Fix for parameter in Notebook activity #16852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d27f3d0
fix for notebook activity parameter
wanyang7 Nov 23, 2021
8c21789
remove required property
wanyang7 Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion ...fication/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3794,6 +3794,35 @@
"modelAsString": true
}
},
"NotebookParameter": {
"description": "Notebook parameter.",
"type": "object",
"properties": {
"value": {
"type": "object",
"description": "Notebook parameter value. Type: string (or Expression with resultType string).",
"x-nullable": true
},
"type": {
"description": "Notebook parameter type.",
"$ref": "#/definitions/NotebookParameterType"
}
}
},
"NotebookParameterType": {
"description": "Notebook parameter type.",
"type": "string",
"enum": [
"string",
"int",
"float",
"bool"
],
Comment on lines +3812 to +3820
Copy link
Copy Markdown
Contributor

@idear1203 idear1203 Nov 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to support dynamic expression?

Copy link
Copy Markdown
Contributor Author

@wonner wonner Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From studio, dynamic expression is supported in value, not in type.

"x-ms-enum": {
"name": "NotebookParameterType",
"modelAsString": true
}
},
"CopySink": {
"discriminator": "type",
"description": "A copy activity sink.",
Expand Down Expand Up @@ -7180,7 +7209,10 @@
},
"parameters": {
"description": "Notebook parameters.",
"$ref": "../artifacts.json#/definitions/ParameterValueSpecification"
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/NotebookParameter"
}
}
},
"required": [
Expand Down