You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: ⚠️
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
Change to data plane APIs
Adding new properties
All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.
ghost
added
the
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
label
Nov 19, 2021
+ Field `autorest.Response` of struct `OperationListResult` has been removed
+ Function `*OperationListResultIterator.NextWithContext` has been removed
+ Function `*OperationListResultIterator.Next` has been removed
+ Function `*OperationListResultPage.NextWithContext` has been removed
+ Function `*OperationListResultPage.Next` has been removed
+ Function `NewOperationListResultIterator` has been removed
+ Function `NewOperationListResultPage` has been removed
+ Function `NewOperationsClientWithBaseURI` has been removed
+ Function `NewOperationsClient` has been removed
+ Function `OperationListResult.IsEmpty` has been removed
+ Function `OperationListResultIterator.NotDone` has been removed
+ Function `OperationListResultIterator.Response` has been removed
+ Function `OperationListResultIterator.Value` has been removed
+ Function `OperationListResultPage.NotDone` has been removed
+ Function `OperationListResultPage.Response` has been removed
+ Function `OperationListResultPage.Values` has been removed
+ Function `OperationsClient.ListComplete` has been removed
+ Function `OperationsClient.ListPreparer` has been removed
+ Function `OperationsClient.ListResponder` has been removed
+ Function `OperationsClient.ListSender` has been removed
+ Function `OperationsClient.List` has been removed
+ Struct `OperationListResultIterator` has been removed
+ Struct `OperationListResultPage` has been removed
+ Struct `OperationsClient` has been removed
+ Function `AssignmentsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `AssignmentsClient.ListForResourceComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string, string, *int32)` to `(context.Context, string, string, string, string, string, string, *int32)`
+ Function `AssignmentsClient.ListForResourceGroupComplete` parameter(s) have been changed from `(context.Context, string, string, string, *int32)` to `(context.Context, string, string, *int32)`
+ Function `AssignmentsClient.ListForResourceGroupPreparer` parameter(s) have been changed from `(context.Context, string, string, string, *int32)` to `(context.Context, string, string, *int32)`
+ Function `AssignmentsClient.ListForResourceGroup` parameter(s) have been changed from `(context.Context, string, string, string, *int32)` to `(context.Context, string, string, *int32)`
+ Function `AssignmentsClient.ListForResourcePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string, string, *int32)` to `(context.Context, string, string, string, string, string, string, *int32)`
+ Function `AssignmentsClient.ListForResource` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string, string, *int32)` to `(context.Context, string, string, string, string, string, string, *int32)`
+ Function `AssignmentsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `AssignmentsClient.List` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `AzureEntityResource.MarshalJSON` has been removed
+ Function `DefinitionsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, Definition, string)` to `(context.Context, string, Definition)`
+ Function `DefinitionsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, Definition, string)` to `(context.Context, string, Definition)`
+ Function `DefinitionsClient.DeletePreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `DefinitionsClient.Delete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `DefinitionsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `DefinitionsClient.Get` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `DefinitionsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `DefinitionsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `DefinitionsClient.List` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `ErrorDetail.MarshalJSON` has been removed
+ Function `ExemptionsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, Exemption, string, string)` to `(context.Context, string, string, Exemption)`
+ Function `ExemptionsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, Exemption, string, string)` to `(context.Context, string, string, Exemption)`
+ Function `ExemptionsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `ExemptionsClient.ListForResourceComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string, string)` to `(context.Context, string, string, string, string, string, string)`
+ Function `ExemptionsClient.ListForResourceGroupComplete` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
+ Function `ExemptionsClient.ListForResourceGroupPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
+ Function `ExemptionsClient.ListForResourceGroup` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
+ Function `ExemptionsClient.ListForResourcePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string, string)` to `(context.Context, string, string, string, string, string, string)`
+ Function `ExemptionsClient.ListForResource` parameter(s) have been changed from `(context.Context, string, string, string, string, string, string, string)` to `(context.Context, string, string, string, string, string, string)`
+ Function `ExemptionsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `ExemptionsClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `NewAssignmentsClientWithBaseURI` parameter(s) have been changed from `(string)` to `(string, string)`
+ Function `NewAssignmentsClient` parameter(s) have been changed from `()` to `(string)`
+ Function `NewDefinitionsClientWithBaseURI` parameter(s) have been changed from `(string)` to `(string, string)`
+ Function `NewDefinitionsClient` parameter(s) have been changed from `()` to `(string)`
+ Function `NewExemptionsClientWithBaseURI` parameter(s) have been changed from `(string)` to `(string, string)`
+ Function `NewExemptionsClient` parameter(s) have been changed from `()` to `(string)`
+ Function `NewSetDefinitionsClientWithBaseURI` parameter(s) have been changed from `(string)` to `(string, string)`
+ Function `NewSetDefinitionsClient` parameter(s) have been changed from `()` to `(string)`
+ Function `NewWithBaseURI` parameter(s) have been changed from `(string)` to `(string, string)`
+ Function `New` parameter(s) have been changed from `()` to `(string)`
+ Function `ProxyResource.MarshalJSON` has been removed
+ Function `Resource.MarshalJSON` has been removed
+ Function `SetDefinitionsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, SetDefinition, string)` to `(context.Context, string, SetDefinition)`
+ Function `SetDefinitionsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, SetDefinition, string)` to `(context.Context, string, SetDefinition)`
+ Function `SetDefinitionsClient.DeletePreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `SetDefinitionsClient.Delete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `SetDefinitionsClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `SetDefinitionsClient.Get` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
+ Function `SetDefinitionsClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `SetDefinitionsClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `SetDefinitionsClient.List` parameter(s) have been changed from `(context.Context, string, string, *int32)` to `(context.Context, string, *int32)`
+ Function `TrackedResource.MarshalJSON` has been removed
+ Struct `AzureEntityResource` has been removed
+ Struct `ErrorDetail` has been removed
+ Struct `ProxyResource` has been removed
+ Struct `Resource` has been removed
+ Struct `TrackedResource` has been removed
+ Type of `CloudError.Error` has been changed from `*ErrorDetail` to `*ErrorResponse`
⚠️Warning [Logs] Generate from 478bb138d082ec391dc8f5d79199030a188f0dfd. SDK Automation 14.0.0
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
❌Failed [Logs] Generate from 478bb138d082ec391dc8f5d79199030a188f0dfd. SDK Automation 14.0.0
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
cmderr [generator automation-v2] [ERROR] total 1 error(s):
cmderr [generator automation-v2] [ERROR] cannot get rp and namespaces from readme 'specification/resources/resource-manager/readme.md': cannot find any `track2` section
error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
warn Skip package processing as generation is failed
️✔️Succeeded [Logs] Generate from 478bb138d082ec391dc8f5d79199030a188f0dfd. SDK Automation 14.0.0
warn Skip initScript due to not configured
command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.typescript@4.7.0 --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/featureClient.js → ./dist/arm-features.js...
cmderr [npmPack] created ./dist/arm-features.js in 197ms
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/managementLinkClient.js → ./dist/arm-links.js...
cmderr [npmPack] created ./dist/arm-links.js in 170ms
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/managementLockClient.js → ./dist/arm-locks.js...
cmderr [npmPack] created ./dist/arm-locks.js in 203ms
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js...
cmderr [npmPack] created ./dist/arm-managedapplications.js in 295ms
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/policyClient.js → ./dist/arm-policy.js...
cmderr [npmPack] created ./dist/arm-policy.js in 337ms
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/subscriptionClient.js → ./dist/arm-resources-subscriptions.js...
cmderr [npmPack] created ./dist/arm-resources-subscriptions.js in 196ms
cmderr [npmPack] loaded rollup.config.js with warnings
cmderr [npmPack] (!) Unused external imports
cmderr [npmPack] default imported from external module 'rollup' but never used
cmderr [npmPack] ./esm/resourceManagementClient.js → ./dist/arm-resources.js...
cmderr [npmPack] created ./dist/arm-resources.js in 563ms
❌Failed [Logs] Generate from 478bb138d082ec391dc8f5d79199030a188f0dfd. Schema Automation 14.0.0
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr [initScript.sh] WARN old lockfile
cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr [initScript.sh] npm WARN old lockfile
cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr [initScript.sh] npm WARN old lockfile
warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr [generateScript.sh] (node:2548) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2016-04-01/Microsoft.Authorization.Resources.json'
cmderr [generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr [generateScript.sh] (node:2548) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr [generateScript.sh] (node:2548) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
cmderr [generateScript.sh] (node:2548) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2016-04-01/Microsoft.Authorization.Resources.json'
cmderr [generateScript.sh] (node:2548) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
warn No file changes detected after generation
cannot force update branch 'sdkAuto/16816/resources' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/16816/resources' as it is the current HEAD of the repository.
error Fatal error: cannot force update branch 'sdkAuto/16816/resources' as it is the current HEAD of the repository.
error The following packages are still pending:
error resources
error resources
error resources
error resources
Hi @KeYu-AnkhSpirit, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.
in resources-resource-manager-Microsoft.Resources-stable-2021-04-01-resources.json
"responses": {
"200": {
"description": "OK - Returns the validation result.",
"schema": {
"$ref": "#/definitions/DeploymentValidateResult"
}
},
"202": {
"description": "Accepted - The request has been accepted for processing and the operation will complete asynchronously."
},
"400": {
"description": "Returns the validation result.",
"schema": {
"$ref": "#/definitions/DeploymentValidateResult"
}
},
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
},
it will report LRO_RESPONSE_CODE error (Respond to the initial request of a long running operation, Patch/Post call must return 201 or 202, Delete call must return 202 or 204, Put call must return 202 or 201 or 200, but 400 being returned)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.