Skip to content

[Schema Registry] Update swagger #16738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 9 commits into from
Nov 12, 2021
Merged

[Schema Registry] Update swagger #16738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f5e66d8
[Schema Registry] Remove 415 response
deyaaeldeen Nov 10, 2021
b4adec6
add 415 back with a schema
deyaaeldeen Nov 10, 2021
3e5faf2
address feedback
deyaaeldeen Nov 10, 2021
77ace2a
no need to update the default case
deyaaeldeen Nov 10, 2021
f698ad5
add x-ms-error-code headers back because the guidelines require them
deyaaeldeen Nov 11, 2021
535bfc8
update the patterns
deyaaeldeen Nov 12, 2021
f01857a
factor schema name parameter into one definition
deyaaeldeen Nov 12, 2021
5f35b98
add an example for 415
deyaaeldeen Nov 12, 2021
367bb52
update examples
deyaaeldeen Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ta-plane/Microsoft.EventHub/stable/2021-10/examples/OperationSchema_QueryIdByContent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@
"Schema-Version": 3
}
},
"415": {}
"415": {
"headers": {
"x-ms-error-code": "InvalidSchemaType"
},
"body": {
"error": {
"code": "InvalidSchemaType",
"message": "Invalid schema type for POST request. 'not-valid' is not supported. TrackingId:7fe9dcfb-0fca-4ab2-9beb-473aa5fe6406_G23, SystemTracker:endpoint:$schemaGroups/sample-sr-group/schemas/sample-schema-name:get-id, Timestamp:2021-11-10T07:53:32"
}
}
}
}
}
12 changes: 11 additions & 1 deletion ...istry/data-plane/Microsoft.EventHub/stable/2021-10/examples/OperationSchema_Register.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@
"Schema-Version": 3
}
},
"415": {}
"415": {
"headers": {
"x-ms-error-code": "InvalidSchemaType"
},
"body": {
"error": {
"code": "InvalidSchemaType",
"message": "Invalid schema type for PUT request. 'not-valid' is not supported. TrackingId:a20c52d6-9818-4748-b91a-aad9ca35212e_G23, SystemTracker:endpoint:$schemaGroups/sample-sr-group/schemas/sample-schema-name, Timestamp:2021-11-10T07:53:30"
}
}
}
}
}
58 changes: 35 additions & 23 deletions ...ification/schemaregistry/data-plane/Microsoft.EventHub/stable/2021-10/schemaregistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,7 @@
"type": "string"
},
{
"name": "schemaName",
"in": "path",
"description": "Name of schema being registered.",
"required": true,
"type": "string",
"maxLength": 50,
"pattern": "^[A-Za-z0-9][A-Za-z0-9_-]*$"
"$ref": "#/parameters/SchemaName"
},
{
"$ref": "#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -228,13 +222,7 @@
"type": "string"
},
{
"name": "schemaName",
"in": "path",
"description": "Name of requested schema.",
"required": true,
"type": "string",
"maxLength": 50,
"pattern": "^[A-Za-z0-9][A-Za-z0-9_-]*$"
"$ref": "#/parameters/SchemaName"
},
{
"name": "schemaContent",
Expand Down Expand Up @@ -281,7 +269,17 @@
}
},
"415": {
"description": "Unsupported Media Type - Content type of the supplied schema is unsupported by schema group."
"description": "Unsupported Media Type - Content type of the supplied schema is unsupported by schema group.",
"headers": {
"x-ms-error-code": {
"type": "string",
"description": "Error code for specific error that occurred."
}
},
"schema": {
"$ref": "#/definitions/Error"
},
"x-ms-error-response": true
},
"default": {
"description": "An error response received from the Azure Schema Registry service.",
Expand Down Expand Up @@ -323,13 +321,7 @@
"type": "string"
},
{
"name": "schemaName",
"in": "path",
"description": "Name of schema being registered.",
"required": true,
"type": "string",
"maxLength": 50,
"pattern": "^[A-Za-z0-9][A-Za-z0-9_-]*$"
"$ref": "#/parameters/SchemaName"
},
{
"name": "schemaContent",
Expand Down Expand Up @@ -376,7 +368,17 @@
}
},
"415": {
"description": "Unsupported Media Type - Content type of the supplied schema is unsupported by schema group."
"description": "Unsupported Media Type - Content type of the supplied schema is unsupported by schema group.",
"headers": {
"x-ms-error-code": {
"type": "string",
"description": "Error code for specific error that occurred."
}
},
"schema": {
"$ref": "#/definitions/Error"
},
"x-ms-error-response": true
},
"default": {
"description": "An error response received from the Azure Schema Registry service.",
Expand Down Expand Up @@ -492,6 +494,16 @@
"in": "path",
"x-ms-skip-url-encoding": true,
"x-ms-parameter-location": "client"
},
"SchemaName": {
"name": "schemaName",
"in": "path",
"description": "Name of schema.",
"required": true,
"type": "string",
"maxLength": 50,
"pattern": "^[A-Za-z0-9][^\\\\/$:]*$",
"x-ms-parameter-location": "method"
}
}
}