Skip to content

[Maps] Review request for Geocode to add version preview/2021-11-01-preview #16664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 43 commits into from
Dec 1, 2021
Merged

[Maps] Review request for Geocode to add version preview/2021-11-01-preview #16664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
8737ce5
added Geocode API
hongweis Sep 4, 2021
37c90ce
Fixed a few issues with swagger and examples
hongweis Sep 6, 2021
efee9b1
Add x-ms-error-response to response codes
hongweis Sep 6, 2021
587df59
Fixed the error responses in sample
hongweis Sep 7, 2021
357768e
Fixed the format of sameple file
hongweis Sep 7, 2021
97c0a6d
Fixed the operation name
hongweis Sep 7, 2021
1afdcb3
Fixed spelling and prettier issues
hongweis Sep 8, 2021
3598bad
move geocode folder to parent folder
chcmsft Sep 9, 2021
7b75531
update some descriptions
chcmsft Sep 9, 2021
1edde3a
add geocode batch api
chcmsft Sep 10, 2021
00a2b7e
update batch geocode api example
chcmsft Sep 10, 2021
fa23b54
update goecode batch api description
chcmsft Sep 10, 2021
c385c0b
remove summayr field
chcmsft Sep 10, 2021
3ad91e3
address comments
chcmsft Sep 14, 2021
4647281
update the strictMatch type to enum
chcmsft Sep 14, 2021
2654423
update forward geocode sample query
chcmsft Sep 15, 2021
e916fc0
update batchItem schema
chcmsft Sep 15, 2021
0f6ece2
fix the prettier issue
chcmsft Sep 15, 2021
eb40272
Fixed the $ref for some defitions
hongweis Sep 16, 2021
d72d0b8
apply prettier
chcmsft Sep 16, 2021
bd78f44
add readme to fix avacado error
chcmsft Sep 16, 2021
5f486af
upper case the parameter & response definition
chcmsft Sep 16, 2021
086c56a
address review board comments
chcmsft Sep 17, 2021
f080ba7
address review board comments
chcmsft Sep 22, 2021
5ca59c8
structuralize request body of geocode batch api
chcmsft Sep 22, 2021
e70e8d3
update forward geocode sample json format
chcmsft Sep 22, 2021
5bf7cd1
1. adjust geocode batch api description due to the request body format
chcmsft Sep 22, 2021
a7d6b02
fix sdk track2 fail
chcmsft Sep 28, 2021
7d37906
update naming from geocode to geocoding
chcmsft Sep 29, 2021
db9c460
address review comments
chcmsft Sep 30, 2021
f6ea994
add status code 206 to batch api
chcmsft Oct 20, 2021
626aa40
update api version
chcmsft Oct 20, 2021
3b6d102
add optionalId
chcmsft Oct 20, 2021
b76498f
fix prettier error, add name to enum field for better code generation
chcmsft Oct 20, 2021
2464447
update post api method name
chcmsft Oct 21, 2021
b320305
move api key from header to query
chcmsft Oct 26, 2021
1cabc5e
move geocoding to search folder
chcmsft Oct 28, 2021
92c17a5
change apiKey from query to header
chcmsft Nov 8, 2021
7e8cd0f
improve the class name in sdk generation
chcmsft Nov 10, 2021
a2a6f38
update description
chcmsft Nov 24, 2021
75c3e67
comment out python and java sdk generation since it's manually genera…
chcmsft Nov 30, 2021
44188ba
update description
chcmsft Dec 1, 2021
92e76f8
add an api example
chcmsft Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions custom-words.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,7 @@ generatevpnclientpackage
generatevpnprofile
geobias
geocode
geocoded
geocodes
geodata
Geodata
Expand Down Expand Up @@ -1357,6 +1358,7 @@ notebookapis
notificationchannels
notificationhubs
notstarted
notstrict
nouploadcache
nowcasts
n'recognition
Expand Down
89 changes: 89 additions & 0 deletions ...aps/data-plane/Search/preview/2021-11-01-preview/examples/ForwardGeocoding.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
{
"parameters": {
"api-version": "2021-11-01-preview",
"addressLine": "15127 NE 24th Street",
"locality": "Redmond",
"adminDistrict": "WA",
"AzureKey": "[subscription-key]"
},
"responses": {
"200": {
"headers": {
"Content-Type": "application/geo+json"
},
"body": {
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"address": {
"countryRegion": {
"name": "United States"
},
"adminDistricts": [
{
"shortName": "WA"
},
{
"shortName": "King County"
}
],
"formattedAddress": "15127 NE 24th St, Redmond, WA 98052",
"locality": "Redmond",
"postalCode": "98052",
"addressLine": "15127 NE 24th St"
},
"type": "Address",
"confidence": "High",
"matchCodes": [
"Good"
],
"geocodePoints": [
{
"geometry": {
"type": "Point",
"coordinates": [
-122.138681,
47.630358
]
},
"calculationMethod": "Rooftop",
"usageTypes": [
"Display"
]
},
{
"geometry": {
"type": "Point",
"coordinates": [
-122.1386787,
47.6302179
]
},
"calculationMethod": "Rooftop",
"usageTypes": [
"Route"
]
}
]
},
"geometry": {
"type": "Point",
"coordinates": [
-122.138681,
47.630358
]
},
"bbox": [
-122.14632282407,
47.626495282429325,
-122.13103917593001,
47.63422071757068
]
}
]
}
}
}
}
258 changes: 258 additions & 0 deletions ...ata-plane/Search/preview/2021-11-01-preview/examples/ForwardGeocodingBatch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,258 @@
{
"parameters": {
"api-version": "2021-11-01-preview",
"AzureKey": "[subscription-key]",
"geocodingBatchRequestBody": {
"batchItems": [
{
"addressLine": "One, Microsoft Way, Redmond, WA 98052",
"top": 2,
"optionalId": "4C3681A6C8AA4AC3441412763A2A25C81444DC8B"
},
{
"addressLine": "Pike Pl",
"adminDistrict": "WA",
"locality": "Seattle",
"top": 3
}
]
}
},
"responses": {
"200": {
"body": {
"summary": {
"successfulRequests": 2,
"totalRequests": 2
},
"batchItems": [
{
"optionalId": "4C3681A6C8AA4AC3441412763A2A25C81444DC8B",
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"address": {
"countryRegion": {
"name": "United States"
},
"adminDistricts": [
{
"shortName": "WA"
},
{
"shortName": "King County"
}
],
"formattedAddress": "1 Microsoft Way, Redmond, WA 98052",
"locality": "Redmond",
"postalCode": "98052",
"addressLine": "1 Microsoft Way"
},
"type": "Address",
"confidence": "Medium",
"matchCodes": [
"Good"
],
"geocodePoints": [
{
"geometry": {
"type": "Point",
"coordinates": [
-122.128275,
47.639429
]
},
"calculationMethod": "Rooftop",
"usageTypes": [
"Display"
]
},
{
"geometry": {
"type": "Point",
"coordinates": [
-122.127028,
47.638545
]
},
"calculationMethod": "Rooftop",
"usageTypes": [
"Route"
]
}
]
},
"geometry": {
"type": "Point",
"coordinates": [
-122.128275,
47.639429
]
},
"bbox": [
-122.1359181505759,
47.63556628242932,
-122.1206318494241,
47.643291717570676
]
}
]
},
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"address": {
"countryRegion": {
"name": "United States"
},
"adminDistricts": [
{
"shortName": "WA"
},
{
"shortName": "King County"
}
],
"formattedAddress": "Pike Pl, Seattle, WA 98101",
"locality": "Seattle",
"postalCode": "98101",
"addressLine": "Pike Pl"
},
"type": "RoadBlock",
"confidence": "High",
"matchCodes": [
"Good"
],
"geocodePoints": [
{
"geometry": {
"type": "Point",
"coordinates": [
-122.341979399674,
47.6095253501216
]
},
"calculationMethod": "Interpolation",
"usageTypes": [
"Display"
]
}
]
},
"geometry": {
"type": "Point",
"coordinates": [
-122.341979399674,
47.6095253501216
]
},
"bbox": [
-122.34961817972945,
47.605662632550924,
-122.33434061961856,
47.61338806769228
]
}
]
}
]
}
},
"206": {
"body": {
"summary": {
"successfulRequests": 1,
"totalRequests": 2
},
"batchItems": [
{
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"type": "Address",
"confidence": "High",
"matchCodes": [
"Good"
],
"address": {
"locality": "Redmond",
"adminDistricts": [
{
"shortName": "WA"
},
{
"shortName": "King"
}
],
"countryRegion": {
"ISO": "US",
"name": "United States"
},
"postalCode": "98052",
"formattedAddress": "1 Microsoft Way, Redmond, WA 98052",
"addressLine": "1 Microsoft Way"
},
"geocodePoints": [
{
"geometry": {
"type": "Point",
"coordinates": [
-122.128275,
47.639429
]
},
"calculationMethod": "Rooftop",
"usageTypes": [
"Display",
"Route"
]
},
{
"geometry": {
"type": "Point",
"coordinates": [
-122.127028,
47.638545
]
},
"calculationMethod": "Rooftop",
"usageTypes": [
"Route"
]
}
]
},
"geometry": {
"type": "Point",
"coordinates": [
-122.128275,
47.639429
]
},
"bbox": [
-122.1359181505759,
47.63556628242932,
-122.1206318494241,
47.643291717570676
]
}
]
},
{
"error": {
"code": "400",
"message": "Invalid request."
}
}
]
}
}
}
}
Loading