Skip to content

[compute] Removing x-ms-azure-resource extension from invalid model ResourceUpdate#1658

Merged
vishrutshah merged 1 commit intoAzure:currentfrom
vishrutshah:fix-wrong-resource-marking
Sep 11, 2017
Merged

[compute] Removing x-ms-azure-resource extension from invalid model ResourceUpdate#1658
vishrutshah merged 1 commit intoAzure:currentfrom
vishrutshah:fix-wrong-resource-marking

Conversation

@vishrutshah
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah commented Sep 8, 2017 •
edited
Loading

Model ResourceUpdate is not a valid Azure resource. It should not be marked as x-ms-azure-resource: true.

cc:
@veronicagg @sarangan12

@vishrutshah vishrutshah self-assigned this Sep 8, 2017
@vishrutshah vishrutshah added ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute labels Sep 8, 2017
@veronicagg
Copy link
Copy Markdown
Contributor

veronicagg commented Sep 9, 2017

LGTM, @amarzavery @lmazuel @shahabhijeet @jianghaolu @jhendrixMSFT could removing the extension from the spec cause breaking changes/problems on your SDKs?

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 9, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 116 Error(s): 33
After the PR: Warning(s): 116 Error(s): 31

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@vishrutshah vishrutshah mentioned this pull request Sep 9, 2017
Merged
9 tasks
@amarzavery
Copy link
Copy Markdown
Contributor

amarzavery commented Sep 11, 2017

LGTM. FYI @huangpf @hyonholee

@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Sep 11, 2017

This should be fine

@vishrutshah
Copy link
Copy Markdown
Contributor Author

vishrutshah commented Sep 11, 2017

Thanks for the review everyone!!

@vishrutshah vishrutshah merged commit 6f5b90c into Azure:current Sep 11, 2017
@vishrutshah vishrutshah deleted the fix-wrong-resource-marking branch September 11, 2017 20:41
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

Build Status Azure/azure-sdk-for-ruby#967

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

Build Status Azure/azure-sdk-for-python#1432

vishrutshah added a commit to vishrutshah/azure-sdk-for-ruby that referenced this pull request Sep 11, 2017
@vishrutshah
Incorporate azure_mgmt_compute issue from Azure/azure-rest-api-specs#…
80f1460 
…1658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarangan12 sarangan12 Awaiting requested review from sarangan12

@hyonholee hyonholee Awaiting requested review from hyonholee

1 more reviewer

@veronicagg veronicagg veronicagg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vishrutshah vishrutshah

Labels

ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Compute

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vishrutshah @veronicagg @azuresdkciprbot @amarzavery @lmazuel @AutorestCI @msftclas